Closed
Conversation
dzhulgakov
approved these changes
May 30, 2019
yinghai
approved these changes
May 30, 2019
| void intraop_launch(std::function<void()> func) { | ||
| if (!in_parallel_region()) { | ||
| internal::_get_intraop_pool.run([func](){ | ||
| internal::_get_intraop_pool().run([func](){ |
Contributor
There was a problem hiding this comment.
_get_intra_op_pool() might be more readable.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
May 30, 2019
Summary: Pull Request resolved: pytorch/pytorch#21122 fix a typo Reviewed By: dzhulgakov Differential Revision: D15553921 fbshipit-source-id: 260b0be5975d49bb6d70e45d83505efcecf02875
Contributor
|
This pull request has been merged in 3805490. |
Contributor
|
It doesn't seem like this typo caused any build failures. What happened? |
Contributor
Author
|
@ezyang you need to set AT_PARALLEL_NATIVE=1 to compile it, we should add a few CI builds with it |
Contributor
|
@ilia-cher can you take point on adding the CI here? Alternately, if you can arrange to remove the compilation flag entirely, or minimize it so that only a small if statement is compiled optionally, that would be even better. |
Contributor
Author
Contributor
|
My point is, even if you don't use one of the implementations, you could
still always compile both of them.
Excerpts from ilia-cher's message of 2019-05-31 12:44:20 -0700:
…
|
Contributor
Author
|
@ezyang they're mutually exclusive, so without some trickery we can't link them both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: fix a typo
Differential Revision: D15553921