Use NamedTemporaryFile to avoid filename collisions#2069
Merged
colesbury merged 2 commits intopytorch:masterfrom Jul 12, 2017
Merged
Use NamedTemporaryFile to avoid filename collisions#2069colesbury merged 2 commits intopytorch:masterfrom
colesbury merged 2 commits intopytorch:masterfrom
Conversation
soumith
approved these changes
Jul 12, 2017
zou3519
pushed a commit
to zou3519/pytorch
that referenced
this pull request
Mar 30, 2018
…ch#2069) In pytorch, after pad_packed_sequence, the "extra" elements (after the ends of the sequences) are reset. In the equivalent Caffe2 graph exported via ONNX, they contained some leftover values, which caused tests to fail. Probably no one depends on these values, but just in case, set them to zero to mimic pytorch semantics.
houseroad
added a commit
to houseroad/pytorch
that referenced
this pull request
Jun 3, 2019
…1c4bc5 Summary: Previous import was 9005291283e943f1a91da5f0acf218bc4e8eb2ca Included changes: - **[5160f3ac](onnx/onnx@5160f3ac)**: Fix typo (pytorch#2069) <Takeshi Watanabe> - **[ac218ac6](onnx/onnx@ac218ac6)**: Add a missing step when upgrading an operator (pytorch#2071) <daquexian> - **[5972eed9](onnx/onnx@5972eed9)**: Clarify the axis/size in pads, strides, dilations (pytorch#2048) <daquexian> Differential Revision: D15612734 fbshipit-source-id: 29bec257dc0629418f30c91ced6c7ee938e4ea7e
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 4, 2019
…1c4bc5 (#21311) Summary: Pull Request resolved: #21311 Previous import was 9005291283e943f1a91da5f0acf218bc4e8eb2ca Included changes: - **[5160f3ac](onnx/onnx@5160f3ac)**: Fix typo (#2069) <Takeshi Watanabe> - **[ac218ac6](onnx/onnx@ac218ac6)**: Add a missing step when upgrading an operator (#2071) <daquexian> - **[5972eed9](onnx/onnx@5972eed9)**: Clarify the axis/size in pads, strides, dilations (#2048) <daquexian> Reviewed By: bddppq Differential Revision: D15612734 fbshipit-source-id: 235dc3d49e4a6ccd4f43e6c2f648e87611d52697
IvanYashchuk
pushed a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Oct 25, 2022
…apped with vectorized domains (pytorch#2069) * Use vectorize predicate for non-vectorized domains that are exactly mapped with vectorized domains
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We sometimes run tests in parallel. This test can fail due to filename collisions.