Modify the Insert quant-dequant test cases to look for q-dq pattern#20672
Closed
nishantpdce wants to merge 2 commits intoexport-D15202187from
Closed
Modify the Insert quant-dequant test cases to look for q-dq pattern#20672nishantpdce wants to merge 2 commits intoexport-D15202187from
nishantpdce wants to merge 2 commits intoexport-D15202187from
Conversation
Differential Revision: D15405606 Differential Version: 82212776
This was referenced May 18, 2019
ZolotukhinM
approved these changes
May 18, 2019
ZolotukhinM
left a comment
There was a problem hiding this comment.
Looks good providing the tests pass (pls see one related comment inline).
Differential Revision: D15405606 Differential Version: 82213099
Contributor
|
This pull request has been merged in 2af5911. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
:black_circle: #20672 Modify the Insert quant-dequant test cases to look for q-dq pattern 💛
:white_circle: #20107 [pt1][quant] Add dequantize_linear for JIT pass 💚
:white_circle: #19984 [pt1][quant] Add qint8 type (int8_t) 💚
Current test case looks for q->int_repr->dq pattern and constant nodes also.
The prim::Constant nodes are not guaranteed to be present at same point in graph.
So we modify the test case to only look for the q->int_repr->dq nodes.
Test Cases:
./buck-out/gen/caffe2/test/jit#binary.par -r "test_insert_quantdequant_consecutive_qnodes_script"
test_insert_quantdequant_consecutive_qnodes_script (test_jit.TestJit) ... ok
Ran 1 test in 0.599s
OK
[npandit@devvm6468.prn2 /data/users/npandit/fbsource/fbcode] ./buck-out/gen/caffe2/test/jit#binary.par -r "test_insert_quantdequant_consecutive_qnodes_trace"
test_insert_quantdequant_consecutive_qnodes_trace (test_jit.TestJit) ... ok
Ran 1 test in 0.269s
OK
[npandit@devvm6468.prn2 /data/users/npandit/fbsource/fbcode] ./buck-out/gen/caffe2/test/jit#binary.par -r "test_insert_quantdequant_single_qnode"test_insert_quantdequant_single_qnode (test_jit.TestJit) ... ok
Ran 1 test in 0.678s
OK
[npandit@devvm6468.prn2 /data/users/npandit/fbsource/fbcode] ./buck-out/gen/caffe2/test/jit#binary.par -r "test_insert_quantdequant_alternate_qnode"
test_insert_quantdequant_alternate_qnode (test_jit.TestJit) ... ok
Ran 1 test in 0.688s
OK
Differential Revision: D15405606