Move THCTensor_(geometric) to ATen#20625
Closed
syed-ahmed wants to merge 18 commits intogh/syed-ahmed/6/basefrom
Closed
Move THCTensor_(geometric) to ATen#20625syed-ahmed wants to merge 18 commits intogh/syed-ahmed/6/basefrom
syed-ahmed wants to merge 18 commits intogh/syed-ahmed/6/basefrom
Conversation
This was referenced May 17, 2019
Move THCTensor_(geometric) to ATen gh-metadata: pytorch pytorch 20625 gh/syed-ahmed/6/head
Move THCTensor_(geometric) to ATen gh-metadata: pytorch pytorch 20625 gh/syed-ahmed/6/head
Move THCTensor_(geometric) to ATen gh-metadata: pytorch pytorch 20625 gh/syed-ahmed/6/head
Move THCTensor_(geometric) to ATen gh-metadata: pytorch pytorch 20625 gh/syed-ahmed/6/head
Move THCTensor_(geometric) to ATen gh-metadata: pytorch pytorch 20625 gh/syed-ahmed/6/head
Move THCTensor_(geometric) to ATen gh-metadata: pytorch pytorch 20625 gh/syed-ahmed/6/head
Move THCTensor_(geometric) to ATen gh-metadata: pytorch pytorch 20625 gh/syed-ahmed/6/head
Move THCTensor_(geometric) to ATen gh-metadata: pytorch pytorch 20625 gh/syed-ahmed/6/head
Move THCTensor_(geometric) to ATen gh-metadata: pytorch pytorch 20625 gh/syed-ahmed/6/head
Move THCTensor_(geometric) to ATen gh-metadata: pytorch pytorch 20625 gh/syed-ahmed/6/head
Move THCTensor_(geometric) to ATen gh-metadata: pytorch pytorch 20625 gh/syed-ahmed/6/head
ezyang
reviewed
May 29, 2019
| auto p = static_cast<float>(p_); | ||
| auto geometric_func = [p] __device__ (float rand) { | ||
| // use __logf fast approximation for peak bandwidth | ||
| return static_cast<scalar_t>(::ceil(__logf(rand) / __logf(static_cast<float>(1.0)-p))); |
Contributor
There was a problem hiding this comment.
used to be ceilf, I guess it doesn't make a difference?
Collaborator
Author
There was a problem hiding this comment.
Yeah. ceil with float input will launch ceilf. These overloads are in /usr/local/cuda-10.0/include/crt/math_functions.hpp fyi
ezyang
approved these changes
May 29, 2019
Move THCTensor_(geometric) to ATen gh-metadata: pytorch pytorch 20625 gh/syed-ahmed/6/head
Move THCTensor_(geometric) to ATen gh-metadata: pytorch pytorch 20625 gh/syed-ahmed/6/head
Move THCTensor_(geometric) to ATen gh-metadata: pytorch pytorch 20625 gh/syed-ahmed/6/head
Move THCTensor_(geometric) to ATen gh-metadata: pytorch pytorch 20625 gh/syed-ahmed/6/head
Move THCTensor_(geometric) to ATen gh-metadata: pytorch pytorch 20625 gh/syed-ahmed/6/head
Move THCTensor_(geometric) to ATen gh-metadata: pytorch pytorch 20625 gh/syed-ahmed/6/head
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D15454049
Effective Bandwidth Benchmark
Float Type
Before:
After:
Double Type
Before:
After: