fix typo in adaptive methods annotation #20306
Closed
ailzhang wants to merge 1 commit intopytorch:masterfrom
Closed
fix typo in adaptive methods annotation #20306ailzhang wants to merge 1 commit intopytorch:masterfrom
ailzhang wants to merge 1 commit intopytorch:masterfrom
Conversation
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ailzhang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
cc @skrah |
Contributor
|
Nice indeed, good to know about the type annotations. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
May 9, 2019
Summary: fixes #20215 The confusing behavior was caused by typos in type annotation :( Pull Request resolved: pytorch/pytorch#20306 Differential Revision: D15276216 Pulled By: ailzhang fbshipit-source-id: 1b0c9635a72a05c9b537f80d85b117b5077fbec7
Contributor
1 similar comment
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #20215
The confusing behavior was caused by typos in type annotation :(