[Needs someone to complete] torch.einsum()#2008
Closed
vlasenkov wants to merge 1 commit intopytorch:masterfrom
Closed
[Needs someone to complete] torch.einsum()#2008vlasenkov wants to merge 1 commit intopytorch:masterfrom
vlasenkov wants to merge 1 commit intopytorch:masterfrom
Conversation
Collaborator
|
this is worth adding in tensor.py, we want it to be available not just under autograd, but also for Tensors. @rockt transpiled TensorFlow code here: https://gist.github.com/rockt/15ee013889d65342088e9260a377dc8f to get an einsum going in PyTorch, but we were hesitant to commit that exact code as-is because we weren't sure about licensing. |
Contributor
Author
|
Are you talking about |
Collaborator
|
oh, nevermind i just misread the PR. I thought it went into nn/functional.py |
|
Is this PR still on progress? |
Collaborator
|
I think this could be closed. (@fmassa ?) |
xwang233
pushed a commit
to xwang233/pytorch
that referenced
this pull request
Oct 7, 2022
* Allow non-root trivial reductions Fixes pytorch#2008 Co-authored-by: Christian Sarofeen <csarofeen@nvidia.com>
IvanYashchuk
pushed a commit
to IvanYashchuk/pytorch
that referenced
this pull request
Oct 12, 2022
* Allow non-root trivial reductions (pytorch#2037) * Allow non-root trivial reductions Fixes pytorch#2008 Co-authored-by: Christian Sarofeen <csarofeen@nvidia.com> * Test file cleanup (pytorch#2040) * Move test_gpu.cpp to test_gpu1.cpp * Split test_gpu1.cpp to test_gpu1.cpp, test_gpu2.cpp and test_gpu3.cpp. Each file should be up to 10K LoC. New tests should be added to test_gpu3.cpp until it gets 10K LoC. * format * fix merge * format Co-authored-by: Christian Sarofeen <csarofeen@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1889