Update foxi version#19793
Closed
zrphercule wants to merge 2 commits intopytorch:masterfrom
zrphercule:fix_foxi
Closed
Update foxi version#19793zrphercule wants to merge 2 commits intopytorch:masterfrom zrphercule:fix_foxi
zrphercule wants to merge 2 commits intopytorch:masterfrom
zrphercule:fix_foxi
Conversation
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@zrphercule has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@zrphercule has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
This was referenced Apr 26, 2019
yinghai
reviewed
Apr 26, 2019
Contributor
yinghai
left a comment
There was a problem hiding this comment.
I don't want to block the fix to land but .DS_Store shouldn't be committed. We should probably add it to .gitignore.
Contributor
|
@yinghai it's in there, not sure why it's changed |
Contributor
|
Looks like it needs to be removed from git also |
Contributor
Author
Member
|
we need to update the foxi, and update the submodule again |
Contributor
|
@zrphercule merged this pull request in c182824. |
zhangguanheng66
pushed a commit
to zhangguanheng66/pytorch
that referenced
this pull request
May 6, 2019
Summary: Update foxi to the latest version for group quantization. Pull Request resolved: pytorch#19793 Reviewed By: jackm321, houseroad Differential Revision: D15095982 Pulled By: zrphercule fbshipit-source-id: 0d1cb403cbda47a4fda9035e1712fced60ced283
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update foxi to the latest version for group quantization.