Skip to content

remove spmd_types dependency from nightly wheel#187015

Open
pianpwk wants to merge 1 commit into
mainfrom
pianpwk/spmd_binary_pull
Open

remove spmd_types dependency from nightly wheel#187015
pianpwk wants to merge 1 commit into
mainfrom
pianpwk/spmd_binary_pull

Conversation

@pianpwk

@pianpwk pianpwk commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Stops spmd_types being a "hard" dependency for torch, plan is to move it to torchannex and have guidance be pip install torch torchannex instead.

@pianpwk pianpwk requested a review from a team as a code owner June 11, 2026 05:05
@pytorch-bot

pytorch-bot Bot commented Jun 11, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/187015

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 4 Pending

As of commit d004e23 with merge base 5c2969a (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pianpwk pianpwk added the topic: not user facing topic category label Jun 11, 2026
@huydhn huydhn requested a review from albanD June 11, 2026 16:40
@atalman atalman added this to the 2.13.0 milestone Jun 11, 2026
@pianpwk

pianpwk commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jun 11, 2026
@pytorchmergebot

Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@fegin

fegin commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Do we still need this PR after #187067?

@pytorchmergebot

Copy link
Copy Markdown
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (mps, 1, 1, macos-m2-15)

Details for Dev Infra team Raised by workflow job

@malfet malfet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I have some problem rebuilding any docker containers now, so let's do it this way

@pianpwk

pianpwk commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

@pytorchbot merge -i

@pytorchmergebot

Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / macos-py3-arm64 / test (mps, 1, 1, macos-m2-15)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot

Copy link
Copy Markdown
Collaborator

Merge failed

Reason: Command `git -C /home/runner/work/pytorch/pytorch commit --author="Pian Pawakapan pianpwk@meta.com" -m remove spmd_types dependency from nightly wheel (#187015)

Stops spmd_types being a "hard" dependency for torch, plan is to move it to torchannex and have guidance be pip install torch torchannex instead.
Pull Request resolved: #187015
Approved by: https://github.com/atalman, https://github.com/aditvenk, https://github.com/malfet
` returned non-zero exit code 1

On branch main
Your branch is up to date with 'origin/main'.

nothing to commit, working tree clean
Details for Dev Infra team Raised by workflow job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants