Bump gloo submodule to include native CMake HIP support#186787
Closed
harkgill-amd wants to merge 1 commit into
Closed
Bump gloo submodule to include native CMake HIP support#186787harkgill-amd wants to merge 1 commit into
harkgill-amd wants to merge 1 commit into
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/186787
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 2 PendingAs of commit ee84f95 with merge base d18f5dc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jeffdaily
approved these changes
Jun 9, 2026
Collaborator
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Skylion007
approved these changes
Jun 9, 2026
Collaborator
|
Should we add cmake support this in this PR or put that in a subsequent diff? |
jemitche1
pushed a commit
to jemitche1/pytorch
that referenced
this pull request
Jun 13, 2026
Needed for ROCm/TheRock#5694. - PyTorch's LoadHIP.cmake migrated to native CMake HIP language support (enable_language(HIP) + find_package(hip CONFIG)) w/ pytorch@d921fd0 - The gloo submodule is still pinned at 3135b0b which depends on FindHIP.cmake. This leads to `lld-link: error: could not open 'gloo_hip.lib': no such file or directory` errors on Windows after gloo fails to locate HIP. - Bumping the gloo submodule to [bcd1672 ("ROCm: Migrate to native CMake HIP support")](pytorch/gloo@bcd1672) aligns gloo with the current native CMake HIP direction. **Testing** - Current nightly branch (gloo 3135b0b) -> gloo fails to find HIP leading to missing gloo_hip.lib Build Windows PyTorch Wheels (dev, 3.12, gfx1151) · ROCm/TheRock@2c48fe4 ``` Could not find a configuration file for package "HIP" that is compatible with requested version "1.0". The following configuration files were considered but not accepted: hip-config.cmake, version: 7.14.60850 The version found is not compatible with the version requested. lld-link: error: could not open 'gloo_hip.lib': no such file or directory ``` - nightly branch + bump (gloo bcd1672) -> gloo finds HIP and gloo_hip.lib is successfully linked Build Windows PyTorch Wheels (dev, 3.12, gfx1151) · ROCm/TheRock@d731f33 ``` -- Found HIP: 7.14.60850 -- GLOO_ROCM_ARCH: gfx1151 [2218/2880] Linking HIP static library lib\gloo_hip.lib ``` Pull Request resolved: pytorch#186787 Approved by: https://github.com/jeffdaily, https://github.com/Skylion007
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for ROCm/TheRock#5694.
PyTorch's LoadHIP.cmake migrated to native CMake HIP language support (enable_language(HIP) + find_package(hip CONFIG)) w/ d921fd0
The gloo submodule is still pinned at 3135b0b which depends on FindHIP.cmake. This leads to
lld-link: error: could not open 'gloo_hip.lib': no such file or directoryerrors on Windows after gloo fails to locate HIP.Bumping the gloo submodule to bcd1672 ("ROCm: Migrate to native CMake HIP support") aligns gloo with the current native CMake HIP direction.
Testing
cc @peterjc123 @mszhanyi @skyline75489 @nbcsm @iremyux @Blackhex @nkhasbag-nv