Closed
Conversation
3bac07c to
c76d5c7
Compare
63236f4 to
5c3ee8a
Compare
wanchaol
commented
Mar 29, 2019
caffe2/contrib/aten/aten_test.py
Outdated
Collaborator
Author
There was a problem hiding this comment.
removed this since we don't have ones supported either way.
jamesr66a
approved these changes
Apr 1, 2019
Collaborator
jamesr66a
left a comment
There was a problem hiding this comment.
Seems correct, thanks! Let see if this works for serialized models with a new binary
houseroad
reviewed
Apr 1, 2019
caffe2/contrib/aten/aten_test.py
Outdated
Member
|
Seems onnx failing CI is legit: https://circleci.com/api/v1.1/project/github/pytorch/pytorch/1106922/output/103/0?file=true |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@wanchaol has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
zhangguanheng66
pushed a commit
to zhangguanheng66/pytorch
that referenced
this pull request
May 6, 2019
Summary: Fixes the problem of pytorch#18391 The issue is that when we code gen the ATenOp, we always generated static number of outputs for each operator. E.g. If there's operator from a old model that only requires two outputs, in its createOperator it will only allocate two output blobs, while the newer version of the operator (`unique` in this case) requires more output blob to be allocated. Pull Request resolved: pytorch#18581 Differential Revision: D14865647 Pulled By: wanchaol fbshipit-source-id: 85f63fe16d6fe408a09eca84798c7e8cab3070e9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the problem of #18391
The issue is that when we code gen the ATenOp, we always generated static number of outputs for each operator. E.g. If there's operator from a old model that only requires two outputs, in its createOperator it will only allocate two output blobs, while the newer version of the operator (
uniquein this case) requires more output blob to be allocated.