Skip to content

[xpu][fix] Fix nn.Embedding module failures on XPU#178987

Closed
guangyey wants to merge 2 commits intogh/guangyey/306/basefrom
gh/guangyey/306/head
Closed

[xpu][fix] Fix nn.Embedding module failures on XPU#178987
guangyey wants to merge 2 commits intogh/guangyey/306/basefrom
gh/guangyey/306/head

Conversation

@guangyey
Copy link
Copy Markdown
Collaborator

@guangyey guangyey commented Apr 1, 2026 •
edited
Loading

Stack from ghstack (oldest at bottom):

Motivation

#174180 introduces nn.Embedding module, which causes CI failures on XPU.

Additional Context

fix #178854
fix #178762

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Apr 1, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/178987

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit dd95d0a with merge base 4e67aac (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Apr 1, 2026

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

guangyey added a commit that referenced this pull request Apr 1, 2026
@guangyey
[xpu][fix] Fix nn.Embedding module failures on XPU
9fea207 
ghstack-source-id: fbd22cd
Pull Request resolved: #178987
@guangyey guangyey requested a review from albanD April 1, 2026 11:15
@guangyey guangyey added the ciflow/trunk Trigger trunk jobs on your pull request label Apr 1, 2026
@guangyey guangyey added the topic: not user facing topic category label Apr 1, 2026
mikaylagawarecki
mikaylagawarecki reviewed Apr 1, 2026
View reviewed changes
torch/testing/_internal/common_modules.py Outdated
# Only test on CPU - CUDA triggers kernel assertion instead of Python exception
device_str = str(device)
if 'cuda' not in device_str and 'mps' not in device_str:
if 'cuda' not in device_str and 'mps' not in device_str and 'xpu' not in device_str:
Copy link
Copy Markdown
Contributor

@mikaylagawarecki mikaylagawarecki Apr 1, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if 'cuda' not in device_str and 'mps' not in device_str and 'xpu' not in device_str:
if device_str is 'cpu':

Copy link
Copy Markdown
Collaborator Author

@guangyey guangyey Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I use device type to explicitly detect cpu.

@guangyey
Update
3dce3b1 
[ghstack-poisoned]
guangyey added a commit that referenced this pull request Apr 2, 2026
@guangyey
[xpu][fix] Fix nn.Embedding module failures on XPU
fc73606 
ghstack-source-id: c09455f
Pull Request resolved: #178987
@guangyey
Update
dd95d0a 
[ghstack-poisoned]
@mikaylagawarecki
Copy link
Copy Markdown
Contributor

mikaylagawarecki commented Apr 2, 2026

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Apr 2, 2026

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@guangyey
Copy link
Copy Markdown
Collaborator Author

guangyey commented Apr 3, 2026

Thanks very much~

@tszulist-hbn tszulist-hbn mentioned this pull request Apr 3, 2026
Closed
weifengpy pushed a commit that referenced this pull request Apr 7, 2026
@guangyey @pytorchmergebot
[xpu][fix] Fix nn.Embedding module failures on XPU (#178987)
690b912 
# Motivation
#174180 introduces `nn.Embedding` module, which causes CI failures on XPU.

# Additional Context
fix #178854
fix #178762
Pull Request resolved: #178987
Approved by: https://github.com/mikaylagawarecki
nklshy-aws pushed a commit to nklshy-aws/pytorch that referenced this pull request Apr 7, 2026
@guangyey @nklshy-aws
[xpu][fix] Fix nn.Embedding module failures on XPU (pytorch#178987)
7af008c 
# Motivation
pytorch#174180 introduces `nn.Embedding` module, which causes CI failures on XPU.

# Additional Context
fix pytorch#178854
fix pytorch#178762
Pull Request resolved: pytorch#178987
Approved by: https://github.com/mikaylagawarecki
bobrenjc93 pushed a commit to bobrenjc93/pytorch that referenced this pull request Apr 10, 2026
@guangyey @bobrenjc93
[xpu][fix] Fix nn.Embedding module failures on XPU (pytorch#178987)
d2a7607 
# Motivation
pytorch#174180 introduces `nn.Embedding` module, which causes CI failures on XPU.

# Additional Context
fix pytorch#178854
fix pytorch#178762
Pull Request resolved: pytorch#178987
Approved by: https://github.com/mikaylagawarecki
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikaylagawarecki mikaylagawarecki mikaylagawarecki approved these changes

@albanD albanD Awaiting requested review from albanD

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@guangyey @mikaylagawarecki @pytorchmergebot @pytorchbot