Remove remaining IR Expect files#17886
Closed
eellison wants to merge 8 commits intopytorch:masterfrom
Closed
Conversation
driazati
reviewed
Mar 11, 2019
|
|
||
| #include <torch/csrc/WindowsTorchApiMacro.h> | ||
| #include <torch/csrc/jit/testing/file_check.h> | ||
| #include <torch/csrc/WindowsTorchApiMacro.h> |
driazati
approved these changes
Mar 11, 2019
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@eellison has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…ve_remaining_test_jit_expects
Contributor
Author
|
Landed, reverted, re-opening in #17886 |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 12, 2019
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Last batch of IR expect files removed. Includes some removal of expect files that are no longer used. Pull Request resolved: pytorch#17886 Differential Revision: D14414435 Pulled By: eellison fbshipit-source-id: 0bfd7ce66ac2f72a57f15f45ebd60b95e80b6c16
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Trying to reland pytorch#17886 since it broke a build and I reverted it Pull Request resolved: pytorch#17924 Differential Revision: D14423842 Pulled By: eellison fbshipit-source-id: f219e786bd07f7da3b7f9e866981199f5ccf6318
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last batch of IR expect files removed. Includes some removal of expect files that are no longer used.