Fix type annotation for _sym_get_coordinate by aorenste · Pull Request #177446 · pytorch/pytorch

aorenste · 2026-03-14T04:38:58Z

Stack from ghstack (oldest at bottom):

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @kadeng @chauhang @amjames @Lucaskabela @jataylo @xmfan @aditvenk

[ghstack-poisoned]

pytorch-bot · 2026-03-14T04:39:03Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/177446

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 2 Unrelated Failures

As of commit dac6fce with merge base 417a890 ():

NEW FAILURES - The following jobs have failed:

dtensor / dtensor-test / test (dtensor, 1, 1, linux.g5.12xlarge.nvidia.gpu) (gh)
test/distributed/tensor/test_random_ops.py::DistTensorRandomOpTest::test_pipeline_parallel_manual_seed
trunk / linux-jammy-cuda13.0-py3.10-gcc11 / test (distributed, 2, 3, lf.linux.g4dn.12xlarge.nvidia.gpu) (gh)
test/distributed/tensor/test_random_ops.py::DistTensorRandomOpTest::test_pipeline_parallel_manual_seed

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

inductor / inductor-test / test (inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (trunk failure)
vision_maskrcnn

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

inductor / inductor-cpu-test / test (cpu_inductor_torchbench, 1, 2, linux.2xlarge.amx, unstable) (gh) (#174929)
detectron2_maskrcnn_r_50_fpn

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]

aorenste · 2026-03-18T02:50:38Z

BC Error: Function Shard.local_shard_size_and_offset: curr_local_size changed from int to IntLikeType is expected.

[ghstack-poisoned]

aorenste · 2026-03-19T02:14:34Z

@pytorchbot merge

pytorchmergebot · 2026-03-19T02:23:41Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

aorenste · 2026-03-19T04:04:54Z

@pytorchbot revert -m "blocking the revert of #177445 which is failing internal tests"

pytorch-bot · 2026-03-19T04:04:56Z

❌ 🤖 pytorchbot command failed:

@pytorchbot revert: error: the following arguments are required: -c/--classification

usage: @pytorchbot revert -m MESSAGE -c
                          {nosignal,ignoredsignal,landrace,weird,ghfirst,autorevert}

Try @pytorchbot --help for more info.

aorenste · 2026-03-19T04:05:16Z

@pytorchbot revert -m "blocking the revert of #177445 which is failing internal tests" -c nosignal

yangw-dev · 2026-03-19T16:49:02Z

@pytorchbot revert -m "the pr breaks lint test, please fix it, see https://github.com/pytorch/pytorch/actions/runs/23302872205/job/67768676562" -c nosignal

pytorchmergebot · 2026-03-19T16:51:05Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

This reverts commit 2a86e11. Reverted #177446 on behalf of https://github.com/yangw-dev due to the pr breaks lint test, please fix it, see https://github.com/pytorch/pytorch/actions/runs/23302872205/job/67768676562 ([comment](#177446 (comment)))

pytorchmergebot · 2026-03-19T16:51:15Z

@aorenste your PR has been successfully reverted.

[ghstack-poisoned]

Pull Request resolved: pytorch#177446 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#172795

This reverts commit b8d53c6. Reverted pytorch#177446 on behalf of https://github.com/aorenste due to blocking the revert of pytorch#177445 which is failing internal tests ([comment](pytorch#177446 (comment)))

Pull Request resolved: pytorch#177446 Approved by: https://github.com/Skylion007

aorenste · 2026-03-20T02:02:27Z

test/distributed/tensor/test_random_ops.py::DistTensorRandomOpTest::test_pipeline_parallel_manual_seed test is pre-existing on trunk
@pytorchbot merge -i

pytorchmergebot · 2026-03-20T02:04:37Z

Merge started

Your change will be merged while ignoring the following 4 checks: dtensor / dtensor-test / test (dtensor, 1, 1, linux.g5.12xlarge.nvidia.gpu), inductor / inductor-cpu-test / test (cpu_inductor_torchbench, 1, 2, linux.2xlarge.amx, unstable), inductor / inductor-test / test (inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu), trunk / linux-jammy-cuda13.0-py3.10-gcc11 / test (distributed, 2, 3, lf.linux.g4dn.12xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Use mesh._sym_get_coordinate() in _compute_rng_offsets so that RNG offset values become symbolic SymInts (via _runtime_compute_coordinate_on_dim) when compile_on_one_rank is active. Previously, mesh.get_coordinate() returned concrete rank-specific integers that got baked into the compiled graph, producing different graphs on different ranks. Also refactors test_compile_on_one_rank.py to extract graph-comparison helpers (_assert_graphs_identical_across_ranks, _compile_and_capture_graph) and adds a test for DTensor random op graph consistency. Authored with Claude. Pull Request resolved: #177447 Approved by: https://github.com/yiming0416 ghstack dependencies: #177446

Pull Request resolved: pytorch#177446 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#172795

This reverts commit b8d53c6. Reverted pytorch#177446 on behalf of https://github.com/aorenste due to blocking the revert of pytorch#177445 which is failing internal tests ([comment](pytorch#177446 (comment)))

Pull Request resolved: pytorch#177446 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#172795

This reverts commit b8d53c6. Reverted pytorch#177446 on behalf of https://github.com/aorenste due to blocking the revert of pytorch#177445 which is failing internal tests ([comment](pytorch#177446 (comment)))

Pull Request resolved: pytorch#177446 Approved by: https://github.com/Skylion007

This reverts commit 2a86e11. Reverted pytorch#177446 on behalf of https://github.com/yangw-dev due to the pr breaks lint test, please fix it, see https://github.com/pytorch/pytorch/actions/runs/23302872205/job/67768676562 ([comment](pytorch#177446 (comment)))

Pull Request resolved: pytorch#177446 Approved by: https://github.com/Skylion007

…177447) Use mesh._sym_get_coordinate() in _compute_rng_offsets so that RNG offset values become symbolic SymInts (via _runtime_compute_coordinate_on_dim) when compile_on_one_rank is active. Previously, mesh.get_coordinate() returned concrete rank-specific integers that got baked into the compiled graph, producing different graphs on different ranks. Also refactors test_compile_on_one_rank.py to extract graph-comparison helpers (_assert_graphs_identical_across_ranks, _compile_and_capture_graph) and adds a test for DTensor random op graph consistency. Authored with Claude. Pull Request resolved: pytorch#177447 Approved by: https://github.com/yiming0416 ghstack dependencies: pytorch#177446

Pull Request resolved: pytorch#177446 Approved by: https://github.com/Skylion007

…177447) Use mesh._sym_get_coordinate() in _compute_rng_offsets so that RNG offset values become symbolic SymInts (via _runtime_compute_coordinate_on_dim) when compile_on_one_rank is active. Previously, mesh.get_coordinate() returned concrete rank-specific integers that got baked into the compiled graph, producing different graphs on different ranks. Also refactors test_compile_on_one_rank.py to extract graph-comparison helpers (_assert_graphs_identical_across_ranks, _compile_and_capture_graph) and adds a test for DTensor random op graph consistency. Authored with Claude. Pull Request resolved: pytorch#177447 Approved by: https://github.com/yiming0416 ghstack dependencies: pytorch#177446

Fix type annotation for _sym_get_coordinate

d4e33d8

[ghstack-poisoned]

pytorch-bot bot added ciflow/inductor ciflow/torchtitan Run TorchTitan integration tests release notes: distributed (dtensor) release notes category labels Mar 14, 2026

This was referenced Mar 14, 2026

Add SymInt and SymFloat to Number #177445

Open

Make run_dtensor_rng_op compatible with compile_on_one_rank #177447

Closed

Skylion007 approved these changes Mar 14, 2026

View reviewed changes

Update on "Fix type annotation for _sym_get_coordinate"

8892a28

[ghstack-poisoned]

pytorch-bot bot added the ciflow/dtensor Run DTensor specific tests label Mar 16, 2026

aorenste added 2 commits March 16, 2026 15:02

Update on "Fix type annotation for _sym_get_coordinate"

d37dfb4

[ghstack-poisoned]

Update on "Fix type annotation for _sym_get_coordinate"

7e7f760

[ghstack-poisoned]

aorenste marked this pull request as ready for review March 18, 2026 02:49

aorenste added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 18, 2026

aorenste added the suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) label Mar 18, 2026

Update on "Fix type annotation for _sym_get_coordinate"

fe5eed9

[ghstack-poisoned]

aorenste mentioned this pull request Mar 18, 2026

[coor-targets] Accept ProcessGroup directly in functional collective op schemas #172795

Closed

aorenste added 2 commits March 18, 2026 07:55

Update on "Fix type annotation for _sym_get_coordinate"

3f0699c

[ghstack-poisoned]

Update on "Fix type annotation for _sym_get_coordinate"

0caecbe

[ghstack-poisoned]

pytorchmergebot added the merging label Mar 19, 2026

pytorchmergebot closed this in b8d53c6 Mar 19, 2026

pytorchmergebot added Merged and removed merging labels Mar 19, 2026

pytorchmergebot removed the merging label Mar 19, 2026

pytorchmergebot reopened this Mar 19, 2026

Update on "Fix type annotation for _sym_get_coordinate"

dac6fce

[ghstack-poisoned]

pytorch-bot bot added module: compiled autograd compiled_autograd module: dynamo labels Mar 19, 2026

izaitsevfb mentioned this pull request Mar 19, 2026

Add AI advisor dispatch to autorevert lambda (shadow mode) pytorch/test-infra#7839

Merged

2 tasks

ryanzhang22 pushed a commit to ryanzhang22/pytorch that referenced this pull request Mar 19, 2026

Fix type annotation for _sym_get_coordinate (pytorch#177446)

0b1c3df

Pull Request resolved: pytorch#177446 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#172795

ryanzhang22 pushed a commit to ryanzhang22/pytorch that referenced this pull request Mar 19, 2026

Fix type annotation for _sym_get_coordinate (pytorch#177446)

d0234ca

Pull Request resolved: pytorch#177446 Approved by: https://github.com/Skylion007

pytorchmergebot added the merging label Mar 20, 2026

pytorchmergebot closed this in ec46212 Mar 20, 2026

pytorchmergebot removed the merging label Mar 20, 2026

EmanueleCoradin pushed a commit to EmanueleCoradin/pytorch that referenced this pull request Mar 30, 2026

Fix type annotation for _sym_get_coordinate (pytorch#177446)

ced06b9

Pull Request resolved: pytorch#177446 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#172795

AaronWang04 pushed a commit to AaronWang04/pytorch that referenced this pull request Mar 31, 2026

Fix type annotation for _sym_get_coordinate (pytorch#177446)

66fedb1

Pull Request resolved: pytorch#177446 Approved by: https://github.com/Skylion007 ghstack dependencies: pytorch#172795

AaronWang04 pushed a commit to AaronWang04/pytorch that referenced this pull request Mar 31, 2026

Fix type annotation for _sym_get_coordinate (pytorch#177446)

13bb572

Pull Request resolved: pytorch#177446 Approved by: https://github.com/Skylion007

AaronWang04 pushed a commit to AaronWang04/pytorch that referenced this pull request Mar 31, 2026

Fix type annotation for _sym_get_coordinate (pytorch#177446)

fedfc10

Pull Request resolved: pytorch#177446 Approved by: https://github.com/Skylion007

nklshy-aws pushed a commit to nklshy-aws/pytorch that referenced this pull request Apr 7, 2026

Fix type annotation for _sym_get_coordinate (pytorch#177446)

139e847

Pull Request resolved: pytorch#177446 Approved by: https://github.com/Skylion007

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix type annotation for _sym_get_coordinate#177446

Fix type annotation for _sym_get_coordinate#177446
aorenste wants to merge 9 commits intogh/aorenste/219/basefrom
gh/aorenste/219/head

aorenste commented Mar 14, 2026 •

edited by pytorch-bot bot

Loading

Uh oh!

pytorch-bot bot commented Mar 14, 2026 •

edited

Loading

Uh oh!

aorenste commented Mar 18, 2026

Uh oh!

aorenste commented Mar 19, 2026

Uh oh!

pytorchmergebot commented Mar 19, 2026

Uh oh!

aorenste commented Mar 19, 2026

Uh oh!

pytorch-bot bot commented Mar 19, 2026

Uh oh!

aorenste commented Mar 19, 2026

Uh oh!

yangw-dev commented Mar 19, 2026

Uh oh!

pytorchmergebot commented Mar 19, 2026

Uh oh!

pytorchmergebot commented Mar 19, 2026

Uh oh!

aorenste commented Mar 20, 2026

Uh oh!

pytorchmergebot commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

aorenste commented Mar 14, 2026 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/177446

❌ 2 New Failures, 2 Unrelated Failures

Uh oh!

aorenste commented Mar 18, 2026

Uh oh!

aorenste commented Mar 19, 2026

Uh oh!

pytorchmergebot commented Mar 19, 2026

Merge started

Uh oh!

aorenste commented Mar 19, 2026

Uh oh!

pytorch-bot bot commented Mar 19, 2026

Uh oh!

aorenste commented Mar 19, 2026

Uh oh!

yangw-dev commented Mar 19, 2026

Uh oh!

pytorchmergebot commented Mar 19, 2026

Uh oh!

pytorchmergebot commented Mar 19, 2026

Uh oh!

aorenste commented Mar 20, 2026

Uh oh!

pytorchmergebot commented Mar 20, 2026

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

aorenste commented Mar 14, 2026 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Mar 14, 2026 •

edited

Loading