[dynamo][hop] Add intermediate to subgraph output only if side-effect observed#177368
Open
anijain2305 wants to merge 3 commits intogh/anijain2305/1077/basefrom
Open
[dynamo][hop] Add intermediate to subgraph output only if side-effect observed#177368anijain2305 wants to merge 3 commits intogh/anijain2305/1077/basefrom
anijain2305 wants to merge 3 commits intogh/anijain2305/1077/basefrom
Conversation
… observed Only collect intermediates as extra subgraph outputs when side effects actually occurred during the trace, not whenever the HOP supports side effects. Previously, allow_side_effects=True (a static class attribute on InvokeSubgraphHigherOrderVariable) caused collect_intermediate_outputs to run unconditionally, adding spurious extra outputs to the graph. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/177368
Note: Links to docs will display an error until the docs builds have been completed. ❌ 6 New Failures, 1 Unrelated FailureAs of commit c25e877 with merge base 3fab23b ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
anijain2305
added a commit
that referenced
this pull request
Mar 13, 2026
… observed Only collect intermediates as extra subgraph outputs when side effects actually occurred during the trace, not whenever the HOP supports side effects. Previously, allow_side_effects=True (a static class attribute on InvokeSubgraphHigherOrderVariable) caused collect_intermediate_outputs to run unconditionally, adding spurious extra outputs to the graph. ghstack-source-id: 5d6207f Pull Request resolved: #177368
…side-effect observed" Only collect intermediates as extra subgraph outputs when side effects actually occurred during the trace, not whenever the HOP supports side effects. Previously, allow_side_effects=True (a static class attribute on InvokeSubgraphHigherOrderVariable) caused collect_intermediate_outputs to run unconditionally, adding spurious extra outputs to the graph. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx kadeng chauhang amjames Lucaskabela jataylo [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Mar 14, 2026
… observed Only collect intermediates as extra subgraph outputs when side effects actually occurred during the trace, not whenever the HOP supports side effects. Previously, allow_side_effects=True (a static class attribute on InvokeSubgraphHigherOrderVariable) caused collect_intermediate_outputs to run unconditionally, adding spurious extra outputs to the graph. ghstack-source-id: 6c2daa3 Pull Request resolved: #177368
…side-effect observed" Only collect intermediates as extra subgraph outputs when side effects actually occurred during the trace, not whenever the HOP supports side effects. Previously, allow_side_effects=True (a static class attribute on InvokeSubgraphHigherOrderVariable) caused collect_intermediate_outputs to run unconditionally, adding spurious extra outputs to the graph. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx kadeng chauhang amjames Lucaskabela jataylo [ghstack-poisoned]
anijain2305
added a commit
that referenced
this pull request
Mar 14, 2026
… observed Only collect intermediates as extra subgraph outputs when side effects actually occurred during the trace, not whenever the HOP supports side effects. Previously, allow_side_effects=True (a static class attribute on InvokeSubgraphHigherOrderVariable) caused collect_intermediate_outputs to run unconditionally, adding spurious extra outputs to the graph. ghstack-source-id: 889247f Pull Request resolved: #177368
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Only collect intermediates as extra subgraph outputs when side effects
actually occurred during the trace, not whenever the HOP supports side
effects. Previously, allow_side_effects=True (a static class attribute
on InvokeSubgraphHigherOrderVariable) caused
collect_intermediate_outputs to run unconditionally, adding spurious
extra outputs to the graph.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @kadeng @chauhang @amjames @Lucaskabela @jataylo