Skip to content

Revert "[Helion + torch.compile] Fix MultiOutput write deps to eliminate fusion workarounds (#177062)"#177359

Closed
yf225 wants to merge 1 commit intomainfrom
revert_177062
Closed

Revert "[Helion + torch.compile] Fix MultiOutput write deps to eliminate fusion workarounds (#177062)"#177359
yf225 wants to merge 1 commit intomainfrom
revert_177062

Conversation

@yf225
Copy link
Copy Markdown
Contributor

@yf225 yf225 commented Mar 13, 2026 •
edited
Loading

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Mar 13, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/177359

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 68 Pending

As of commit 83daeaf with merge base b989649 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ci-no-td Do not run TD on this PR ciflow/inductor ciflow/torchtitan Run TorchTitan integration tests module: inductor labels Mar 13, 2026
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Mar 13, 2026

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@yf225 yf225 added the topic: not user facing topic category label Mar 13, 2026
@yf225
Copy link
Copy Markdown
Contributor Author

yf225 commented Mar 13, 2026

@pytorchbot merge -f "revert PR"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Mar 13, 2026

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@yf225 yf225 mentioned this pull request Mar 13, 2026
Closed
pytorchmergebot pushed a commit that referenced this pull request Mar 13, 2026
@yf225 @pytorchmergebot
[Helion + torch.compile] Fix MultiOutput write deps and extend fusion…
a7322a9 
… score matching (#177302)

Give MultiOutput proper MemoryDep writes derived from its own FixedLayout
instead of inheriting StarDep from InputsKernel.  This removes the hack
in FusedSchedulerNode.fuse() that copied index expressions from the
template parent.  Extend score_fusion_memory to use name-based dep
matching for templates so that views/reshapes between template outputs
and epilogues do not block fusion.

This PR also now contains the changes from #177359, with proper fixes to avoid breaking internal tests.
Pull Request resolved: #177302
Approved by: https://github.com/shunting314, https://github.com/jansel
AaronWang04 pushed a commit to AaronWang04/pytorch that referenced this pull request Mar 24, 2026
@yf225 @AaronWang04
[Helion + torch.compile] Fix MultiOutput write deps and extend fusion…
d23592f 
… score matching (pytorch#177302)

Give MultiOutput proper MemoryDep writes derived from its own FixedLayout
instead of inheriting StarDep from InputsKernel.  This removes the hack
in FusedSchedulerNode.fuse() that copied index expressions from the
template parent.  Extend score_fusion_memory to use name-based dep
matching for templates so that views/reshapes between template outputs
and epilogues do not block fusion.

This PR also now contains the changes from pytorch#177359, with proper fixes to avoid breaking internal tests.
Pull Request resolved: pytorch#177302
Approved by: https://github.com/shunting314, https://github.com/jansel
EmanueleCoradin pushed a commit to EmanueleCoradin/pytorch that referenced this pull request Mar 30, 2026
@yf225 @EmanueleCoradin
Revert "[Helion + torch.compile] Fix MultiOutput write deps to elimin…
93ad3cf 
…ate fusion workarounds (pytorch#177062)" (pytorch#177359)

This reverts commit 648a664.

This should land after pytorch#177360.

Pull Request resolved: pytorch#177359
Approved by: https://github.com/huydhn
EmanueleCoradin pushed a commit to EmanueleCoradin/pytorch that referenced this pull request Mar 30, 2026
@yf225 @EmanueleCoradin
[Helion + torch.compile] Fix MultiOutput write deps and extend fusion…
c83dec5 
… score matching (pytorch#177302)

Give MultiOutput proper MemoryDep writes derived from its own FixedLayout
instead of inheriting StarDep from InputsKernel.  This removes the hack
in FusedSchedulerNode.fuse() that copied index expressions from the
template parent.  Extend score_fusion_memory to use name-based dep
matching for templates so that views/reshapes between template outputs
and epilogues do not block fusion.

This PR also now contains the changes from pytorch#177359, with proper fixes to avoid breaking internal tests.
Pull Request resolved: pytorch#177302
Approved by: https://github.com/shunting314, https://github.com/jansel
@github-actions github-actions bot deleted the revert_177062 branch April 12, 2026 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/inductor ciflow/torchtitan Run TorchTitan integration tests Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yf225 @pytorchmergebot @huydhn