Skip to content

Update Kineto Submodule#177298

Closed
mdlogic wants to merge 1 commit intopytorch:mainfrom
mdlogic:update-kineto-submodule
Closed

Update Kineto Submodule#177298
mdlogic wants to merge 1 commit intopytorch:mainfrom
mdlogic:update-kineto-submodule

Conversation

@mdlogic
Copy link
Copy Markdown
Contributor

@mdlogic mdlogic commented Mar 12, 2026

Bump Kineto submodule from 0035505 to 2b15a60 to include pytorch/kineto#1296 (seq_num propagation to GPU kernel events in trace output).

This is needed so that #177148 (D96145503) can use the new Kineto APIs for NCCL sequence number tracing.

Included kineto commits

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Mar 12, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/177298

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 7ed6f2a with merge base 3fab23b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot Bot added the topic: not user facing topic category label Mar 12, 2026
@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla Bot commented Mar 12, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: mdlogic / name: Marvin Dsouza (7ed6f2a)

@mdlogic mdlogic force-pushed the update-kineto-submodule branch 3 times, most recently from c8588c8 to bf164e7 Compare March 12, 2026 21:24
Copy link
Copy Markdown
Contributor

@sanrise sanrise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the update in kineto is needed to introduce process group sequence number logging, such that we can start recording collective sequence numbers from pytorch .

Bump Kineto submodule from 0035505 to 2b15a60 to include
pytorch/kineto#1296 (seq_num propagation to GPU kernel events
in trace output). This is needed for pytorch#177148
(NCCL sequence number tracing).
@mdlogic mdlogic force-pushed the update-kineto-submodule branch from bf164e7 to 7ed6f2a Compare March 13, 2026 02:36
@mdlogic
Copy link
Copy Markdown
Contributor Author

mdlogic commented Mar 13, 2026

@pytorchbot merge on PR #177298

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Mar 13, 2026

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: on PR #177298

usage: @pytorchbot [-h]
                   
                   {merge,revert,rebase,label,drci,lint,fix-lint,apply-lint,cherry-pick}
                   ...

Try @pytorchbot --help for more info.

@mdlogic
Copy link
Copy Markdown
Contributor Author

mdlogic commented Mar 13, 2026

@pytorchbot merge

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Mar 13, 2026

Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra.

@mdlogic
Copy link
Copy Markdown
Contributor Author

mdlogic commented Mar 13, 2026

@sanrise @scotts Looks like yall need to approve the CI to run on this one since I don't have privs

@mdlogic
Copy link
Copy Markdown
Contributor Author

mdlogic commented Mar 13, 2026

@sanrise @scotts Looks like yall need to approve the CI to run on this one since I don't have privs

nvm, managed to get perms

@mdlogic
Copy link
Copy Markdown
Contributor Author

mdlogic commented Mar 13, 2026

@pytorchbot merge

@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 13, 2026
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

Copy link
Copy Markdown
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we know ROCM failures are flakes, sure... But it would be nice if someone can keep an eye on timeouts (cc: @scotts , @huydhn )

@malfet
Copy link
Copy Markdown
Contributor

malfet commented Mar 13, 2026

@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

AaronWang04 pushed a commit to AaronWang04/pytorch that referenced this pull request Mar 24, 2026
Bump Kineto submodule from 0035505 to 2b15a60 to include pytorch/kineto#1296 (seq_num propagation to GPU kernel events in trace output).

This is needed so that pytorch#177148 (D96145503) can use the new Kineto APIs for NCCL sequence number tracing.

## Included kineto commits
- 2b15a60 Add seq_num propagation to GPU kernel events in Kineto trace output (pytorch#1296)
- 350b58f Refactor CuptiActivityProfiler.cpp to use CuptiCbidRegistry (pytorch#1297)
- 1f9ceb1 Use HAS_CUPTI_RANGE_PROFILER to avoid range profiler init (pytorch#1298)
- ebaac17 Add USDT log type to logger framework (pytorch#1285)
- e2e7e97 Revert D94566477: Add NCCL collective sequence number (seq_num) to Kineto profiler traces
- a7c5f4d Add NCCL collective sequence number (seq_num) to Kineto profiler traces (pytorch#1294)
Pull Request resolved: pytorch#177298
Approved by: https://github.com/sanrise, https://github.com/malfet
EmanueleCoradin pushed a commit to EmanueleCoradin/pytorch that referenced this pull request Mar 30, 2026
Bump Kineto submodule from 0035505 to 2b15a60 to include pytorch/kineto#1296 (seq_num propagation to GPU kernel events in trace output).

This is needed so that pytorch#177148 (D96145503) can use the new Kineto APIs for NCCL sequence number tracing.

## Included kineto commits
- 2b15a60 Add seq_num propagation to GPU kernel events in Kineto trace output (pytorch#1296)
- 350b58f Refactor CuptiActivityProfiler.cpp to use CuptiCbidRegistry (pytorch#1297)
- 1f9ceb1 Use HAS_CUPTI_RANGE_PROFILER to avoid range profiler init (pytorch#1298)
- ebaac17 Add USDT log type to logger framework (pytorch#1285)
- e2e7e97 Revert D94566477: Add NCCL collective sequence number (seq_num) to Kineto profiler traces
- a7c5f4d Add NCCL collective sequence number (seq_num) to Kineto profiler traces (pytorch#1294)
Pull Request resolved: pytorch#177298
Approved by: https://github.com/sanrise, https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants