Update Kineto Submodule#177298
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/177298
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7ed6f2a with merge base 3fab23b ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
c8588c8 to
bf164e7
Compare
sanrise
left a comment
There was a problem hiding this comment.
LGTM, the update in kineto is needed to introduce process group sequence number logging, such that we can start recording collective sequence numbers from pytorch .
Bump Kineto submodule from 0035505 to 2b15a60 to include pytorch/kineto#1296 (seq_num propagation to GPU kernel events in trace output). This is needed for pytorch#177148 (NCCL sequence number tracing).
bf164e7 to
7ed6f2a
Compare
|
@pytorchbot merge on PR #177298 |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot merge |
|
Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Bump Kineto submodule from 0035505 to 2b15a60 to include pytorch/kineto#1296 (seq_num propagation to GPU kernel events in trace output). This is needed so that pytorch#177148 (D96145503) can use the new Kineto APIs for NCCL sequence number tracing. ## Included kineto commits - 2b15a60 Add seq_num propagation to GPU kernel events in Kineto trace output (pytorch#1296) - 350b58f Refactor CuptiActivityProfiler.cpp to use CuptiCbidRegistry (pytorch#1297) - 1f9ceb1 Use HAS_CUPTI_RANGE_PROFILER to avoid range profiler init (pytorch#1298) - ebaac17 Add USDT log type to logger framework (pytorch#1285) - e2e7e97 Revert D94566477: Add NCCL collective sequence number (seq_num) to Kineto profiler traces - a7c5f4d Add NCCL collective sequence number (seq_num) to Kineto profiler traces (pytorch#1294) Pull Request resolved: pytorch#177298 Approved by: https://github.com/sanrise, https://github.com/malfet
Bump Kineto submodule from 0035505 to 2b15a60 to include pytorch/kineto#1296 (seq_num propagation to GPU kernel events in trace output). This is needed so that pytorch#177148 (D96145503) can use the new Kineto APIs for NCCL sequence number tracing. ## Included kineto commits - 2b15a60 Add seq_num propagation to GPU kernel events in Kineto trace output (pytorch#1296) - 350b58f Refactor CuptiActivityProfiler.cpp to use CuptiCbidRegistry (pytorch#1297) - 1f9ceb1 Use HAS_CUPTI_RANGE_PROFILER to avoid range profiler init (pytorch#1298) - ebaac17 Add USDT log type to logger framework (pytorch#1285) - e2e7e97 Revert D94566477: Add NCCL collective sequence number (seq_num) to Kineto profiler traces - a7c5f4d Add NCCL collective sequence number (seq_num) to Kineto profiler traces (pytorch#1294) Pull Request resolved: pytorch#177298 Approved by: https://github.com/sanrise, https://github.com/malfet
Bump Kineto submodule from 0035505 to 2b15a60 to include pytorch/kineto#1296 (seq_num propagation to GPU kernel events in trace output).
This is needed so that #177148 (D96145503) can use the new Kineto APIs for NCCL sequence number tracing.
Included kineto commits