Skip to content

Reland [fx] Fix quadratic name generation in create_name#177217

Closed
anijain2305 wants to merge 1 commit intogh/anijain2305/1076/basefrom
gh/anijain2305/1076/head
Closed

Reland [fx] Fix quadratic name generation in create_name#177217
anijain2305 wants to merge 1 commit intogh/anijain2305/1076/basefrom
gh/anijain2305/1076/head

Conversation

@anijain2305
Copy link
Contributor

@anijain2305 anijain2305 commented Mar 12, 2026 •
edited
Loading

Stack from ghstack (oldest at bottom):

reland of #176515 but earlier the file already moved to C++, so sending a python only change.

@anijain2305
Reland [fx] Fix quadratic name generation in create_name
2a17cf0 
reland of #176515 but earlier the file already moved to C++, so sending a python only change.

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 12, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/177217

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 8 Unrelated Failures

As of commit 2a17cf0 with merge base a12a78b (image):

NEW FAILURE - The following job has failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ci-no-td Do not run TD on this PR release notes: fx release notes category labels Mar 12, 2026
anijain2305 added a commit that referenced this pull request Mar 12, 2026
@anijain2305
Reland [fx] Fix quadratic name generation in create_name
9017aa0 
reland of #176515 but earlier the file already moved to C++, so sending a python only change.

ghstack-source-id: e0bdb29
Pull Request resolved: #177217
@anijain2305 anijain2305 requested a review from jansel March 12, 2026 00:17
@anijain2305 anijain2305 added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 12, 2026
@anijain2305 anijain2305 requested a review from zou3519 March 12, 2026 00:17
@anijain2305
Copy link
Contributor Author

anijain2305 commented Mar 12, 2026

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Mar 12, 2026

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Mar 12, 2026

Merge failed

Reason: HTTP Error 502: Bad Gateway

Details for Dev Infra team Raised by workflow job

@anijain2305
Copy link
Contributor Author

anijain2305 commented Mar 12, 2026

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Mar 12, 2026

Merge started

Your change will be merged while ignoring the following 8 checks: pull / linux-jammy-py3.14-clang15 / test (dynamo_wrapped, 1, 3, lf.linux.2xlarge), pull / linux-jammy-py3.14-clang15 / test (crossref, 1, 2, lf.linux.2xlarge), pull / linux-jammy-py3.14t-clang15 / test (crossref, 1, 2, lf.linux.2xlarge), pull / linux-jammy-py3.14t-clang15 / test (dynamo_wrapped, 2, 3, lf.linux.2xlarge), pull / linux-jammy-py3.10-clang15 / test (dynamo_wrapped, 1, 3, lf.linux.2xlarge), pull / linux-jammy-py3.10-clang15 / test (crossref, 2, 2, lf.linux.2xlarge), pull / linux-jammy-py3.10-gcc11 / test (distributed, 2, 2, lf.linux.2xlarge), trunk / linux-jammy-cuda13.0-py3.10-gcc11 / test (default, 4, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

@zou3519 zou3519 zou3519 approved these changes

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: fx release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@anijain2305 @pytorchmergebot @jansel @zou3519