Fixes assertEqual and assert_close for DTensor by arkadip-maitra · Pull Request #176895 · pytorch/pytorch

arkadip-maitra · 2026-03-09T17:14:38Z

assertEqual and assert_close crashed when given DTensors with plain tensor with ambiguous message. Now checks specs, unwraps to local tensors and gives clean error message.

modified some existing test asserts

Authored with Claude

pytorch-bot · 2026-03-09T17:14:45Z

This PR needs a `release notes:` label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

pytorch-bot · 2026-03-09T17:14:48Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/176895

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 7ab42be with merge base 99dee05 ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

trunk / linux-jammy-cuda13.0-py3.10-gcc11 / test (default, 3, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu) (gh) (similar failure)
test/export/test_hop.py::TestHOPCUDA::test_aot_export_inline_asm_elementwise_simple_cuda_float32

This comment was automatically generated by Dr. CI and updates every 15 minutes.

arkadip-maitra · 2026-03-10T09:39:25Z

@pytorchbot rebase -b viable/strict

pytorchmergebot · 2026-03-10T09:41:10Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2026-03-10T09:41:13Z

Tried to rebase and push PR #176895, but it was already up to date. Try rebasing against main by issuing:
@pytorchbot rebase -b main

arkadip-maitra · 2026-03-10T14:00:05Z

@pytorchbot rebase

pytorchmergebot · 2026-03-10T14:01:49Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2026-03-10T14:01:54Z

Successfully rebased fix_167549 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix_167549 && git pull --rebase)

wconstab · 2026-03-13T17:47:32Z

torch/testing/_internal/common_utils.py

+        # handle DTensor cases explicitly
+        try:
+            from torch.distributed.tensor import DTensor
+        except ImportError:


We shouldn't use the try/except pattern for cases wehre we have to conditionally import- search the code for uses of importlib.find.. something like that. also, it'd be better to do the HAS_DTENSOR check once at common_utils.py import time and then check that constant from here than run the find import function on every call

thanks, updated.

wconstab · 2026-03-13T17:57:05Z

torch/testing/_internal/common_utils.py

+                y = y.to_local()
+            elif x_dt != y_dt:
+                non_dt = y if x_dt else x
+                if isinstance(non_dt, torch.Tensor):


kinda confused what you want to happen here.

The TypeError is a hard error when we do DT+T comparisons right?
Then why do we have the if/else later to 'make it work' by doing .to_local() - should we just always error in this x_dt != y_dt block?

it was because i wanted scalar comparison without doing .full_tensor() but it should fail to be consistent. so changed it

arkadip-maitra · 2026-03-14T14:44:32Z

@pytorchbot rebase

pytorchmergebot · 2026-03-14T14:46:13Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2026-03-14T14:46:17Z

Successfully rebased fix_167549 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix_167549 && git pull --rebase)

arkadip-maitra · 2026-03-16T08:00:38Z

@pytorchbot merge

pytorchmergebot · 2026-03-16T08:03:29Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2026-03-16T08:14:16Z

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (mps, 1, 1, macos-m2-15)

Details for Dev Infra team

Raised by workflow job

arkadip-maitra · 2026-03-16T10:54:36Z

had to make changes to has_dtensor check cus macos trunk was failing

pytorchmergebot · 2026-03-22T08:36:54Z

Successfully rebased fix_167549 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix_167549 && git pull --rebase)

arkadip-maitra · 2026-03-24T07:55:17Z

@pytorchbot merge

pytorchmergebot · 2026-03-24T07:57:25Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2026-03-24T11:11:57Z

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-jammy-cuda13.0-py3.10-gcc11 / test (distributed, 3, 3, lf.linux.g4dn.12xlarge.nvidia.gpu)

Details for Dev Infra team

Raised by workflow job

arkadip-maitra · 2026-03-24T14:06:58Z

hey @wconstab so this test failure was because of that test being added after my last commit. i rebased and that test failed. sorry for that. i think this pr should be merged before merging prs involving dtensor tests. thanks!

wconstab · 2026-03-24T19:31:15Z

@pytorchbot merge

pytorchmergebot · 2026-03-24T19:33:28Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Fixes #167549 `assertEqual` and `assert_close` crashed when given DTensors with plain tensor with ambiguous message. Now checks specs, unwraps to local tensors and gives clean error message. modified some existing test asserts Authored with Claude Pull Request resolved: #176895 Approved by: https://github.com/mlazos, https://github.com/wconstab Co-authored-by: Xia-Weiwen <12522207+Xia-Weiwen@users.noreply.github.com>

Fixes pytorch#167549 `assertEqual` and `assert_close` crashed when given DTensors with plain tensor with ambiguous message. Now checks specs, unwraps to local tensors and gives clean error message. modified some existing test asserts Authored with Claude Pull Request resolved: pytorch#176895 Approved by: https://github.com/mlazos, https://github.com/wconstab

This reverts commit b9720a4. Reverted pytorch#176895 on behalf of https://github.com/malfet due to I could be wrong, but it broke some distribtued tests, see https://hud.pytorch.org/hud/pytorch/pytorch/5d775ad0cbde7690840ab9ebe95fd3f75b2fb156/1?per_page=50&name_filter=distributed&mergeEphemeralLF=true ([comment](pytorch#176895 (comment)))

Fixes pytorch#167549 `assertEqual` and `assert_close` crashed when given DTensors with plain tensor with ambiguous message. Now checks specs, unwraps to local tensors and gives clean error message. modified some existing test asserts Authored with Claude Pull Request resolved: pytorch#176895 Approved by: https://github.com/mlazos, https://github.com/wconstab

arkadip-maitra requested a review from a team as a code owner March 9, 2026 17:14

arkadip-maitra added the topic: not user facing topic category label Mar 9, 2026

pytorchbot added the open source label Mar 9, 2026

pytorchmergebot force-pushed the fix_167549 branch from 8f8c034 to 4b0d99c Compare March 10, 2026 14:01

arkadip-maitra requested a review from wconstab March 11, 2026 14:04

wconstab reviewed Mar 13, 2026

View reviewed changes

pytorchmergebot force-pushed the fix_167549 branch from 1e15886 to 612f4af Compare March 14, 2026 14:46

arkadip-maitra requested a review from wconstab March 15, 2026 07:48

mlazos previously approved these changes Mar 16, 2026

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 16, 2026

pytorchmergebot added the merging label Mar 16, 2026

pytorchmergebot removed the merging label Mar 16, 2026

pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Mar 16, 2026

arkadip-maitra requested a review from mlazos March 16, 2026 13:14

pytorchmergebot force-pushed the fix_167549 branch from da3fdb1 to 43b50fc Compare March 22, 2026 08:36

wconstab approved these changes Mar 24, 2026

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 24, 2026

pytorchmergebot added the merging label Mar 24, 2026

pytorchmergebot removed the merging label Mar 24, 2026

fixing new test so it does not fail

7ab42be

arkadip-maitra force-pushed the fix_167549 branch from 43b50fc to 7ab42be Compare March 24, 2026 14:05

pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Mar 24, 2026

arkadip-maitra requested a review from wconstab March 24, 2026 14:05

wconstab approved these changes Mar 24, 2026

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 24, 2026

pytorchmergebot added the merging label Mar 24, 2026

mlazos approved these changes Mar 24, 2026

View reviewed changes

pytorchmergebot closed this in 10ba77a Mar 25, 2026

pytorchmergebot removed the merging label Mar 25, 2026

Lucaskabela mentioned this pull request Mar 25, 2026

[Bugfix] Fix by copying sym shapes as needed #178210

Closed

Conversation

arkadip-maitra commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Mar 9, 2026

This PR needs a release notes: label

Uh oh!

pytorch-bot bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/176895

✅ You can merge normally! (1 Unrelated Failure)

Uh oh!

arkadip-maitra commented Mar 10, 2026

Uh oh!

pytorchmergebot commented Mar 10, 2026

Uh oh!

pytorchmergebot commented Mar 10, 2026

Uh oh!

arkadip-maitra commented Mar 10, 2026

Uh oh!

pytorchmergebot commented Mar 10, 2026

Uh oh!

pytorchmergebot commented Mar 10, 2026

Uh oh!

wconstab Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

arkadip-maitra Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

wconstab Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

arkadip-maitra Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

arkadip-maitra commented Mar 14, 2026

Uh oh!

pytorchmergebot commented Mar 14, 2026

Uh oh!

pytorchmergebot commented Mar 14, 2026

Uh oh!

arkadip-maitra commented Mar 16, 2026

Uh oh!

pytorchmergebot commented Mar 16, 2026

Merge started

Uh oh!

pytorchmergebot commented Mar 16, 2026

Merge failed

Uh oh!

arkadip-maitra commented Mar 16, 2026

Uh oh!

pytorchmergebot commented Mar 22, 2026

Uh oh!

arkadip-maitra commented Mar 24, 2026

Uh oh!

pytorchmergebot commented Mar 24, 2026

Merge started

Uh oh!

pytorchmergebot commented Mar 24, 2026

Merge failed

Uh oh!

arkadip-maitra commented Mar 24, 2026

Uh oh!

wconstab commented Mar 24, 2026

Uh oh!

pytorchmergebot commented Mar 24, 2026

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

arkadip-maitra commented Mar 9, 2026 •

edited

Loading

This PR needs a `release notes:` label

pytorch-bot bot commented Mar 9, 2026 •

edited

Loading