[Inductor][NVGEMM] Refactor tests#176847
Closed
NikhilAPatel wants to merge 10 commits intogh/NikhilAPatel/123/basefrom
Closed
[Inductor][NVGEMM] Refactor tests#176847NikhilAPatel wants to merge 10 commits intogh/NikhilAPatel/123/basefrom
NikhilAPatel wants to merge 10 commits intogh/NikhilAPatel/123/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/176847
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 1 Unrelated FailureAs of commit df2f946 with merge base 572f0d0 ( NEW FAILURES - The following jobs have failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Mar 8, 2026
This PR needs a
|
Shared helpers (module-level):
- _round_up — deduplicated from two test methods
- _prep_k — deduplicated from two test methods
- _create_tensor_with_layout — unified layout creation for all dtypes (float16, bf16, fp8, fp4)
- _nvgemm_config — standard config dict with autotune_fallback_to_aten: False always set
Bug fixes:
- Added missing torch._dynamo.reset() to test_scaled_gemm_mxfp8, test_scaled_gemm_nvf4, test_grouped_gemm, test_grouped_gemm_varying_offsets
- ceildiv moved to top-level import (was imported inside two test methods)
New test coverage:
- test_matmul: added ("contiguous", "aligned_offset") and ("contiguous", "padded") layout combos (7 combos, up from 5)
- test_scaled_gemm_mxfp8: added shape parametrization (4 shapes, was 1)
- test_grouped_gemm: added layout_a parametrization (contiguous, aligned_offset, view, padded)
- test_grouped_gemm_varying_offsets: split out from original test_grouped_gemm — tests different offset distributions separately
- test_fp8_heuristic_configs: new heuristics integration test for FP8 precision strings
Consistency fixes:
- All tests now use _nvgemm_config() with autotune_fallback_to_aten: False
- TestNVUniversalGemmDynamicShapes also uses _nvgemm_config()
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo
[ghstack-poisoned]
Shared helpers (module-level):
- _round_up — deduplicated from two test methods
- _prep_k — deduplicated from two test methods
- _create_tensor_with_layout — unified layout creation for all dtypes (float16, bf16, fp8, fp4)
- _nvgemm_config — standard config dict with autotune_fallback_to_aten: False always set
Bug fixes:
- Added missing torch._dynamo.reset() to test_scaled_gemm_mxfp8, test_scaled_gemm_nvf4, test_grouped_gemm, test_grouped_gemm_varying_offsets
- ceildiv moved to top-level import (was imported inside two test methods)
New test coverage:
- test_matmul: added ("contiguous", "aligned_offset") and ("contiguous", "padded") layout combos (7 combos, up from 5)
- test_scaled_gemm_mxfp8: added shape parametrization (4 shapes, was 1)
- test_grouped_gemm: added layout_a parametrization (contiguous, aligned_offset, view, padded)
- test_grouped_gemm_varying_offsets: split out from original test_grouped_gemm — tests different offset distributions separately
- test_fp8_heuristic_configs: new heuristics integration test for FP8 precision strings
Consistency fixes:
- All tests now use _nvgemm_config() with autotune_fallback_to_aten: False
- TestNVUniversalGemmDynamicShapes also uses _nvgemm_config()
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo
[ghstack-poisoned]
Shared helpers (module-level):
- _round_up — deduplicated from two test methods
- _prep_k — deduplicated from two test methods
- _create_tensor_with_layout — unified layout creation for all dtypes (float16, bf16, fp8, fp4)
- _nvgemm_config — standard config dict with autotune_fallback_to_aten: False always set
Bug fixes:
- Added missing torch._dynamo.reset() to test_scaled_gemm_mxfp8, test_scaled_gemm_nvf4, test_grouped_gemm, test_grouped_gemm_varying_offsets
- ceildiv moved to top-level import (was imported inside two test methods)
New test coverage:
- test_matmul: added ("contiguous", "aligned_offset") and ("contiguous", "padded") layout combos (7 combos, up from 5)
- test_scaled_gemm_mxfp8: added shape parametrization (4 shapes, was 1)
- test_grouped_gemm: added layout_a parametrization (contiguous, aligned_offset, view, padded)
- test_grouped_gemm_varying_offsets: split out from original test_grouped_gemm — tests different offset distributions separately
- test_fp8_heuristic_configs: new heuristics integration test for FP8 precision strings
Consistency fixes:
- All tests now use _nvgemm_config() with autotune_fallback_to_aten: False
- TestNVUniversalGemmDynamicShapes also uses _nvgemm_config()
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo
[ghstack-poisoned]
Shared helpers (module-level):
- _round_up — deduplicated from two test methods
- _prep_k — deduplicated from two test methods
- _create_tensor_with_layout — unified layout creation for all dtypes (float16, bf16, fp8, fp4)
- _nvgemm_config — standard config dict with autotune_fallback_to_aten: False always set
Bug fixes:
- Added missing torch._dynamo.reset() to test_scaled_gemm_mxfp8, test_scaled_gemm_nvf4, test_grouped_gemm, test_grouped_gemm_varying_offsets
- ceildiv moved to top-level import (was imported inside two test methods)
New test coverage:
- test_matmul: added ("contiguous", "aligned_offset") and ("contiguous", "padded") layout combos (7 combos, up from 5)
- test_scaled_gemm_mxfp8: added shape parametrization (4 shapes, was 1)
- test_grouped_gemm: added layout_a parametrization (contiguous, aligned_offset, view, padded)
- test_grouped_gemm_varying_offsets: split out from original test_grouped_gemm — tests different offset distributions separately
- test_fp8_heuristic_configs: new heuristics integration test for FP8 precision strings
Consistency fixes:
- All tests now use _nvgemm_config() with autotune_fallback_to_aten: False
- TestNVUniversalGemmDynamicShapes also uses _nvgemm_config()
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo
[ghstack-poisoned]
Shared helpers (module-level):
- _round_up — deduplicated from two test methods
- _prep_k — deduplicated from two test methods
- _create_tensor_with_layout — unified layout creation for all dtypes (float16, bf16, fp8, fp4)
- _nvgemm_config — standard config dict with autotune_fallback_to_aten: False always set
Bug fixes:
- Added missing torch._dynamo.reset() to test_scaled_gemm_mxfp8, test_scaled_gemm_nvf4, test_grouped_gemm, test_grouped_gemm_varying_offsets
- ceildiv moved to top-level import (was imported inside two test methods)
New test coverage:
- test_matmul: added ("contiguous", "aligned_offset") and ("contiguous", "padded") layout combos (7 combos, up from 5)
- test_scaled_gemm_mxfp8: added shape parametrization (4 shapes, was 1)
- test_grouped_gemm: added layout_a parametrization (contiguous, aligned_offset, view, padded)
- test_grouped_gemm_varying_offsets: split out from original test_grouped_gemm — tests different offset distributions separately
- test_fp8_heuristic_configs: new heuristics integration test for FP8 precision strings
Consistency fixes:
- All tests now use _nvgemm_config() with autotune_fallback_to_aten: False
- TestNVUniversalGemmDynamicShapes also uses _nvgemm_config()
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo
[ghstack-poisoned]
Shared helpers (module-level):
- _round_up — deduplicated from two test methods
- _prep_k — deduplicated from two test methods
- _create_tensor_with_layout — unified layout creation for all dtypes (float16, bf16, fp8, fp4)
- _nvgemm_config — standard config dict with autotune_fallback_to_aten: False always set
Bug fixes:
- Added missing torch._dynamo.reset() to test_scaled_gemm_mxfp8, test_scaled_gemm_nvf4, test_grouped_gemm, test_grouped_gemm_varying_offsets
- ceildiv moved to top-level import (was imported inside two test methods)
New test coverage:
- test_matmul: added ("contiguous", "aligned_offset") and ("contiguous", "padded") layout combos (7 combos, up from 5)
- test_scaled_gemm_mxfp8: added shape parametrization (4 shapes, was 1)
- test_grouped_gemm: added layout_a parametrization (contiguous, aligned_offset, view, padded)
- test_grouped_gemm_varying_offsets: split out from original test_grouped_gemm — tests different offset distributions separately
- test_fp8_heuristic_configs: new heuristics integration test for FP8 precision strings
Consistency fixes:
- All tests now use _nvgemm_config() with autotune_fallback_to_aten: False
- TestNVUniversalGemmDynamicShapes also uses _nvgemm_config()
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo
[ghstack-poisoned]
sandy-gags
pushed a commit
to sandy-gags/pytorch
that referenced
this pull request
Mar 12, 2026
ghstack-source-id: c3b4ae3 Pull Request resolved: pytorch/pytorch#176847
mlazos
approved these changes
Mar 16, 2026
Shared helpers (module-level):
- _round_up — deduplicated from two test methods
- _prep_k — deduplicated from two test methods
- _create_tensor_with_layout — unified layout creation for all dtypes (float16, bf16, fp8, fp4)
- _nvgemm_config — standard config dict with autotune_fallback_to_aten: False always set
Bug fixes:
- Added missing torch._dynamo.reset() to test_scaled_gemm_mxfp8, test_scaled_gemm_nvf4, test_grouped_gemm, test_grouped_gemm_varying_offsets
- ceildiv moved to top-level import (was imported inside two test methods)
New test coverage:
- test_matmul: added ("contiguous", "aligned_offset") and ("contiguous", "padded") layout combos (7 combos, up from 5)
- test_scaled_gemm_mxfp8: added shape parametrization (4 shapes, was 1)
- test_grouped_gemm: added layout_a parametrization (contiguous, aligned_offset, view, padded)
- test_grouped_gemm_varying_offsets: split out from original test_grouped_gemm — tests different offset distributions separately
- test_fp8_heuristic_configs: new heuristics integration test for FP8 precision strings
Consistency fixes:
- All tests now use _nvgemm_config() with autotune_fallback_to_aten: False
- TestNVUniversalGemmDynamicShapes also uses _nvgemm_config()
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo
[ghstack-poisoned]
Shared helpers (module-level):
- _round_up — deduplicated from two test methods
- _prep_k — deduplicated from two test methods
- _create_tensor_with_layout — unified layout creation for all dtypes (float16, bf16, fp8, fp4)
- _nvgemm_config — standard config dict with autotune_fallback_to_aten: False always set
Bug fixes:
- Added missing torch._dynamo.reset() to test_scaled_gemm_mxfp8, test_scaled_gemm_nvf4, test_grouped_gemm, test_grouped_gemm_varying_offsets
- ceildiv moved to top-level import (was imported inside two test methods)
New test coverage:
- test_matmul: added ("contiguous", "aligned_offset") and ("contiguous", "padded") layout combos (7 combos, up from 5)
- test_scaled_gemm_mxfp8: added shape parametrization (4 shapes, was 1)
- test_grouped_gemm: added layout_a parametrization (contiguous, aligned_offset, view, padded)
- test_grouped_gemm_varying_offsets: split out from original test_grouped_gemm — tests different offset distributions separately
- test_fp8_heuristic_configs: new heuristics integration test for FP8 precision strings
Consistency fixes:
- All tests now use _nvgemm_config() with autotune_fallback_to_aten: False
- TestNVUniversalGemmDynamicShapes also uses _nvgemm_config()
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo
[ghstack-poisoned]
Shared helpers (module-level):
- _round_up — deduplicated from two test methods
- _prep_k — deduplicated from two test methods
- _create_tensor_with_layout — unified layout creation for all dtypes (float16, bf16, fp8, fp4)
- _nvgemm_config — standard config dict with autotune_fallback_to_aten: False always set
Bug fixes:
- Added missing torch._dynamo.reset() to test_scaled_gemm_mxfp8, test_scaled_gemm_nvf4, test_grouped_gemm, test_grouped_gemm_varying_offsets
- ceildiv moved to top-level import (was imported inside two test methods)
New test coverage:
- test_matmul: added ("contiguous", "aligned_offset") and ("contiguous", "padded") layout combos (7 combos, up from 5)
- test_scaled_gemm_mxfp8: added shape parametrization (4 shapes, was 1)
- test_grouped_gemm: added layout_a parametrization (contiguous, aligned_offset, view, padded)
- test_grouped_gemm_varying_offsets: split out from original test_grouped_gemm — tests different offset distributions separately
- test_fp8_heuristic_configs: new heuristics integration test for FP8 precision strings
Consistency fixes:
- All tests now use _nvgemm_config() with autotune_fallback_to_aten: False
- TestNVUniversalGemmDynamicShapes also uses _nvgemm_config()
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo
[ghstack-poisoned]
Collaborator
|
Starting merge as part of PR stack under #176859 |
1 similar comment
Collaborator
|
Starting merge as part of PR stack under #176859 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 22, 2026
dshi7
pushed a commit
to dshi7/pytorch
that referenced
this pull request
Mar 23, 2026
Shared helpers (module-level):
- _round_up — deduplicated from two test methods
- _prep_k — deduplicated from two test methods
- _create_tensor_with_layout — unified layout creation for all dtypes (float16, bf16, fp8, fp4)
- _nvgemm_config — standard config dict with autotune_fallback_to_aten: False always set
Bug fixes:
- Added missing torch._dynamo.reset() to test_scaled_gemm_mxfp8, test_scaled_gemm_nvf4, test_grouped_gemm, test_grouped_gemm_varying_offsets
- ceildiv moved to top-level import (was imported inside two test methods)
New test coverage:
- test_matmul: added ("contiguous", "aligned_offset") and ("contiguous", "padded") layout combos (7 combos, up from 5)
- test_scaled_gemm_mxfp8: added shape parametrization (4 shapes, was 1)
- test_grouped_gemm: added layout_a parametrization (contiguous, aligned_offset, view, padded)
- test_grouped_gemm_varying_offsets: split out from original test_grouped_gemm — tests different offset distributions separately
- test_fp8_heuristic_configs: new heuristics integration test for FP8 precision strings
Consistency fixes:
- All tests now use _nvgemm_config() with autotune_fallback_to_aten: False
- TestNVUniversalGemmDynamicShapes also uses _nvgemm_config()
Pull Request resolved: pytorch#176847
Approved by: https://github.com/mlazos
ghstack dependencies: pytorch#176543, pytorch#176544, pytorch#176545, pytorch#176546, pytorch#176547, pytorch#176548, pytorch#176549, pytorch#176845
dshi7
pushed a commit
to dshi7/pytorch
that referenced
this pull request
Mar 23, 2026
…ytorch#176859) Pull Request resolved: pytorch#176859 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#176543, pytorch#176544, pytorch#176545, pytorch#176546, pytorch#176547, pytorch#176548, pytorch#176549, pytorch#176845, pytorch#176847
cyyever
pushed a commit
to cyyever/pytorch
that referenced
this pull request
Mar 24, 2026
…ytorch#176859) Pull Request resolved: pytorch#176859 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#176543, pytorch#176544, pytorch#176545, pytorch#176546, pytorch#176547, pytorch#176548, pytorch#176549, pytorch#176845, pytorch#176847
AaronWang04
pushed a commit
to AaronWang04/pytorch
that referenced
this pull request
Mar 31, 2026
Shared helpers (module-level):
- _round_up — deduplicated from two test methods
- _prep_k — deduplicated from two test methods
- _create_tensor_with_layout — unified layout creation for all dtypes (float16, bf16, fp8, fp4)
- _nvgemm_config — standard config dict with autotune_fallback_to_aten: False always set
Bug fixes:
- Added missing torch._dynamo.reset() to test_scaled_gemm_mxfp8, test_scaled_gemm_nvf4, test_grouped_gemm, test_grouped_gemm_varying_offsets
- ceildiv moved to top-level import (was imported inside two test methods)
New test coverage:
- test_matmul: added ("contiguous", "aligned_offset") and ("contiguous", "padded") layout combos (7 combos, up from 5)
- test_scaled_gemm_mxfp8: added shape parametrization (4 shapes, was 1)
- test_grouped_gemm: added layout_a parametrization (contiguous, aligned_offset, view, padded)
- test_grouped_gemm_varying_offsets: split out from original test_grouped_gemm — tests different offset distributions separately
- test_fp8_heuristic_configs: new heuristics integration test for FP8 precision strings
Consistency fixes:
- All tests now use _nvgemm_config() with autotune_fallback_to_aten: False
- TestNVUniversalGemmDynamicShapes also uses _nvgemm_config()
Pull Request resolved: pytorch#176847
Approved by: https://github.com/mlazos
ghstack dependencies: pytorch#176543, pytorch#176544, pytorch#176545, pytorch#176546, pytorch#176547, pytorch#176548, pytorch#176549, pytorch#176845
AaronWang04
pushed a commit
to AaronWang04/pytorch
that referenced
this pull request
Mar 31, 2026
…ytorch#176859) Pull Request resolved: pytorch#176859 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#176543, pytorch#176544, pytorch#176545, pytorch#176546, pytorch#176547, pytorch#176548, pytorch#176549, pytorch#176845, pytorch#176847
This was referenced Apr 1, 2026
nklshy-aws
pushed a commit
to nklshy-aws/pytorch
that referenced
this pull request
Apr 7, 2026
Shared helpers (module-level):
- _round_up — deduplicated from two test methods
- _prep_k — deduplicated from two test methods
- _create_tensor_with_layout — unified layout creation for all dtypes (float16, bf16, fp8, fp4)
- _nvgemm_config — standard config dict with autotune_fallback_to_aten: False always set
Bug fixes:
- Added missing torch._dynamo.reset() to test_scaled_gemm_mxfp8, test_scaled_gemm_nvf4, test_grouped_gemm, test_grouped_gemm_varying_offsets
- ceildiv moved to top-level import (was imported inside two test methods)
New test coverage:
- test_matmul: added ("contiguous", "aligned_offset") and ("contiguous", "padded") layout combos (7 combos, up from 5)
- test_scaled_gemm_mxfp8: added shape parametrization (4 shapes, was 1)
- test_grouped_gemm: added layout_a parametrization (contiguous, aligned_offset, view, padded)
- test_grouped_gemm_varying_offsets: split out from original test_grouped_gemm — tests different offset distributions separately
- test_fp8_heuristic_configs: new heuristics integration test for FP8 precision strings
Consistency fixes:
- All tests now use _nvgemm_config() with autotune_fallback_to_aten: False
- TestNVUniversalGemmDynamicShapes also uses _nvgemm_config()
Pull Request resolved: pytorch#176847
Approved by: https://github.com/mlazos
ghstack dependencies: pytorch#176543, pytorch#176544, pytorch#176545, pytorch#176546, pytorch#176547, pytorch#176548, pytorch#176549, pytorch#176845
nklshy-aws
pushed a commit
to nklshy-aws/pytorch
that referenced
this pull request
Apr 7, 2026
…ytorch#176859) Pull Request resolved: pytorch#176859 Approved by: https://github.com/mlazos ghstack dependencies: pytorch#176543, pytorch#176544, pytorch#176545, pytorch#176546, pytorch#176547, pytorch#176548, pytorch#176549, pytorch#176845, pytorch#176847
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
[Inductor] Fix benchmark_example_value losing dtype on view unwrap #176859
-> [Inductor][NVGEMM] Refactor tests #176847
[Inductor][NVGEMM] Drop tile_k from nvMatmulHeuristics matching #176845
[Inductor][NVGEMM] Restore fp4 kernel docstrings #176549
[Inductor][NVGEMM] Enable nvMatmulHeuristics for FP4 blockscaled GEMM #176548
[Inductor][NVGEMM] Register CuTeDSL Blockscaled GEMM with NVGEMM Backend #176547
[Inductor][NVGEMM] Add CuTeDSL Blockscaled GEMM Kernel #176546
[Inductor][NVGEMM] Patch cutlass_api FP4 dtype mapping #176545
[Inductor] Add FP4 tensor creation support for autotuning #176544
[Inductor][NVGEMM] Add infrastructure for registering custom kernels with NVGEMM Cutlass API #176543
Shared helpers (module-level):
Bug fixes:
New test coverage:
Consistency fixes:
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @jataylo