[Inductor] Fallback to super().get_read_writes when epilogue_fusion_user_defined_triton_kernel is disabled#176832
Closed
coufon wants to merge 1 commit intopytorch:mainfrom
Closed
[Inductor] Fallback to super().get_read_writes when epilogue_fusion_user_defined_triton_kernel is disabled#176832coufon wants to merge 1 commit intopytorch:mainfrom
coufon wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/176832
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit 904933b with merge base 82374f2 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
AmesingFlank
approved these changes
Mar 8, 2026
coufon
added a commit
to coufon/pytorch
that referenced
this pull request
Mar 8, 2026
…ser_defined_triton_kernel is disabled (pytorch#176832) Summary: PR pytorch#173662 introduces a new fusion `epilogue_fusion_user_defined_triton_kernel`. It overrides the `get_read_writes` method of `UserDefinedTritonKernel`, even when `epilogue_fusion_user_defined_triton_kernel` is disabled. This may cause regression to existing Triton kernel CUDA graph for other models. This diff fixed the regression by falling back to the original `get_read_writes` when `epilogue_fusion_user_defined_triton_kernel` is disabled Reviewed By: AmesingFlank Differential Revision: D95727036
coufon
added a commit
to coufon/pytorch
that referenced
this pull request
Mar 8, 2026
…ser_defined_triton_kernel is disabled (pytorch#176832) Summary: PR pytorch#173662 introduces a new fusion `epilogue_fusion_user_defined_triton_kernel`. It overrides the `get_read_writes` method of `UserDefinedTritonKernel`, even when `epilogue_fusion_user_defined_triton_kernel` is disabled. This may cause regression to existing Triton kernel CUDA graph for other models. This diff fixed the regression by falling back to the original `get_read_writes` when `epilogue_fusion_user_defined_triton_kernel` is disabled Reviewed By: AmesingFlank Differential Revision: D95727036
…ser_defined_triton_kernel is disabled (pytorch#176832) Summary: Pull Request resolved: pytorch#176832 PR pytorch#173662 introduces a new fusion `epilogue_fusion_user_defined_triton_kernel`. It overrides the `get_read_writes` method of `UserDefinedTritonKernel`, even when `epilogue_fusion_user_defined_triton_kernel` is disabled. This may cause regression to existing Triton kernel CUDA graph for other models. This diff fixed the regression by falling back to the original `get_read_writes` when `epilogue_fusion_user_defined_triton_kernel` is disabled Reviewed By: AmesingFlank Differential Revision: D95727036
Contributor
|
@pytorchmergebot merge |
Collaborator
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
This PR needs a
|
Contributor
|
@pytorchmergebot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
v0i0
added a commit
to pytorch/helion
that referenced
this pull request
Mar 11, 2026
The inductor NameError flake (buf1 not defined) that prompted the pin has been fixed upstream by multiple PyTorch PRs: - pytorch/pytorch#176772 (fix is_unfusable scheduler logic) - pytorch/pytorch#176832 (guard get_read_writes behind config flag) - pytorch/pytorch#177062 (fix MultiOutput write deps) The root cause was pytorch/pytorch#173662 which overrode UserDefinedTritonKernel.get_read_writes() even when the epilogue fusion feature was disabled, breaking buffer scheduling for TritonTemplateBuffer subclasses like Helion's HelionTemplateBuffer. Verified the previously-failing test passes against current PyTorch main. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
v0i0
added a commit
to pytorch/helion
that referenced
this pull request
Mar 12, 2026
The inductor NameError flake (buf1 not defined) that prompted the pin has been fixed upstream by multiple PyTorch PRs: - pytorch/pytorch#176772 (fix is_unfusable scheduler logic) - pytorch/pytorch#176832 (guard get_read_writes behind config flag) - pytorch/pytorch#177062 (fix MultiOutput write deps) The root cause was pytorch/pytorch#173662 which overrode UserDefinedTritonKernel.get_read_writes() even when the epilogue fusion feature was disabled, breaking buffer scheduling for TritonTemplateBuffer subclasses like Helion's HelionTemplateBuffer. Verified the previously-failing test passes against current PyTorch main. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
v0i0
added a commit
to pytorch/helion
that referenced
this pull request
Mar 12, 2026
The inductor NameError flake (buf1 not defined) that prompted the pin has been fixed upstream by multiple PyTorch PRs: - pytorch/pytorch#176772 (fix is_unfusable scheduler logic) - pytorch/pytorch#176832 (guard get_read_writes behind config flag) - pytorch/pytorch#177062 (fix MultiOutput write deps) The root cause was pytorch/pytorch#173662 which overrode UserDefinedTritonKernel.get_read_writes() even when the epilogue fusion feature was disabled, breaking buffer scheduling for TritonTemplateBuffer subclasses like Helion's HelionTemplateBuffer. Verified the previously-failing test passes against current PyTorch main. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
EmanueleCoradin
pushed a commit
to EmanueleCoradin/pytorch
that referenced
this pull request
Mar 30, 2026
…ser_defined_triton_kernel is disabled (pytorch#176832) Summary: PR pytorch#173662 introduces a new fusion `epilogue_fusion_user_defined_triton_kernel`. It overrides the `get_read_writes` method of `UserDefinedTritonKernel`, even when `epilogue_fusion_user_defined_triton_kernel` is disabled. This may cause regression to existing Triton kernel CUDA graph for other models. This diff fixed the regression by falling back to the original `get_read_writes` when `epilogue_fusion_user_defined_triton_kernel` is disabled Differential Revision: D95727036 Pull Request resolved: pytorch#176832 Approved by: https://github.com/AmesingFlank
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: PR #173662 introduces a new fusion
epilogue_fusion_user_defined_triton_kernel. It overrides theget_read_writesmethod ofUserDefinedTritonKernel, even whenepilogue_fusion_user_defined_triton_kernelis disabled. This may cause regression to existing Triton kernel CUDA graph for other models. This diff fixed the regression by falling back to the originalget_read_writeswhenepilogue_fusion_user_defined_triton_kernelis disabledDifferential Revision: D95727036
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @jataylo