Skip to content

[dynamo] Add validation for config override env vars#176735

Closed
desertfire wants to merge 3 commits intogh/desertfire/666/basefrom
gh/desertfire/666/head
Closed

[dynamo] Add validation for config override env vars#176735
desertfire wants to merge 3 commits intogh/desertfire/666/basefrom
gh/desertfire/666/head

Conversation

@desertfire
Copy link
Copy Markdown
Contributor

@desertfire desertfire commented Mar 6, 2026 •
edited by pytorch-bot bot
Loading

Stack from ghstack (oldest at bottom):

Validate config keys at parse time for both
dynamo and inductor overrides, surfacing typos as clear ValueErrors
instead of deep InternalTorchDynamoError stack traces.

Authored with Claude.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @kadeng @chauhang @amjames @Lucaskabela @jataylo

@desertfire
[dynamo] Add validation for config override env vars
39fea49 
Validate config keys at parse time for both
dynamo and inductor overrides, surfacing typos as clear ValueErrors
instead of deep InternalTorchDynamoError stack traces.

Authored with Claude.

[ghstack-poisoned]
@desertfire desertfire mentioned this pull request Mar 6, 2026
Closed
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Mar 6, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/176735

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 2 Unrelated Failures

As of commit 1a235f5 with merge base 3258b18 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

desertfire added a commit that referenced this pull request Mar 6, 2026
@desertfire
[dynamo] Add validation for config override env vars
877a8c6 
Validate config keys at parse time for both
dynamo and inductor overrides, surfacing typos as clear ValueErrors
instead of deep InternalTorchDynamoError stack traces.

Authored with Claude.

ghstack-source-id: 273195b
Pull Request resolved: #176735
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Mar 6, 2026

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@desertfire desertfire marked this pull request as ready for review March 10, 2026 18:52
@desertfire desertfire requested a review from williamwen42 March 12, 2026 14:49
@desertfire desertfire added the topic: not user facing topic category label Mar 12, 2026
@desertfire
Update on "[dynamo] Add validation for config override env vars"
de7c043 
Validate config keys at parse time for both
dynamo and inductor overrides, surfacing typos as clear ValueErrors
instead of deep InternalTorchDynamoError stack traces.

Authored with Claude.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx kadeng chauhang amjames Lucaskabela jataylo

[ghstack-poisoned]
desertfire added a commit that referenced this pull request Mar 12, 2026
@desertfire
[dynamo] Add validation for config override env vars
15a707b 
Validate config keys at parse time for both
dynamo and inductor overrides, surfacing typos as clear ValueErrors
instead of deep InternalTorchDynamoError stack traces.

Authored with Claude.

ghstack-source-id: 0b1ff46
Pull Request resolved: #176735
@pytorch-bot pytorch-bot bot added the ciflow/torchtitan Run TorchTitan integration tests label Mar 12, 2026
williamwen42
williamwen42 reviewed Mar 12, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@williamwen42 williamwen42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test?

@desertfire
Update on "[dynamo] Add validation for config override env vars"
1a235f5 
Validate config keys at parse time for both
dynamo and inductor overrides, surfacing typos as clear ValueErrors
instead of deep InternalTorchDynamoError stack traces.

Authored with Claude.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx kadeng chauhang amjames Lucaskabela jataylo

[ghstack-poisoned]
desertfire added a commit that referenced this pull request Mar 13, 2026
@desertfire
[dynamo] Add validation for config override env vars
edbb920 
Validate config keys at parse time for both
dynamo and inductor overrides, surfacing typos as clear ValueErrors
instead of deep InternalTorchDynamoError stack traces.

Authored with Claude.

ghstack-source-id: 55e9e33
Pull Request resolved: #176735
@desertfire desertfire requested a review from williamwen42 March 13, 2026 19:07
@desertfire
Copy link
Copy Markdown
Contributor Author

desertfire commented Mar 13, 2026

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 13, 2026
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Mar 13, 2026

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Mar 13, 2026

Merge failed

Reason: 2 jobs have failed, first few of them are: inductor / unit-test / inductor-test / test (inductor_cpp_wrapper, 2, 2, linux.g5.4xlarge.nvidia.gpu), inductor / unit-test / inductor-test / test (inductor_cpp_wrapper, 1, 2, linux.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@desertfire
Copy link
Copy Markdown
Contributor Author

desertfire commented Mar 14, 2026

@pytorchbot merge -i

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Mar 14, 2026

Merge started

Your change will be merged while ignoring the following 5 checks: inductor / inductor-cpu-test / test (cpu_inductor_torchbench, 1, 2, linux.2xlarge.amx, unstable), inductor / unit-test / inductor-test / test (inductor_cpp_wrapper, 2, 2, linux.g5.4xlarge.nvidia.gpu), inductor / unit-test / inductor-test / test (inductor_cpp_wrapper, 1, 2, linux.g5.4xlarge.nvidia.gpu), trunk / linux-jammy-cuda13.0-py3.10-gcc11 / test (default, 2, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu), trunk / linux-jammy-rocm-py3.10 / test (default, 5, 6, linux.rocm.gpu.gfx950.1)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

EmanueleCoradin pushed a commit to EmanueleCoradin/pytorch that referenced this pull request Mar 30, 2026
@desertfire @EmanueleCoradin
[dynamo] Add validation for config override env vars (pytorch#176735)
888355d 
Validate config keys at parse time for both
dynamo and inductor overrides, surfacing typos as clear ValueErrors
instead of deep InternalTorchDynamoError stack traces.

Authored with Claude.

Pull Request resolved: pytorch#176735
Approved by: https://github.com/williamwen42
ghstack dependencies: pytorch#176734
AaronWang04 pushed a commit to AaronWang04/pytorch that referenced this pull request Mar 31, 2026
@desertfire @AaronWang04
[dynamo] Add validation for config override env vars (pytorch#176735)
821ccf4 
Validate config keys at parse time for both
dynamo and inductor overrides, surfacing typos as clear ValueErrors
instead of deep InternalTorchDynamoError stack traces.

Authored with Claude.

Pull Request resolved: pytorch#176735
Approved by: https://github.com/williamwen42
ghstack dependencies: pytorch#176734
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@williamwen42 williamwen42 williamwen42 approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/torchtitan Run TorchTitan integration tests ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@desertfire @pytorchmergebot @williamwen42