[CI] Disable TRANSFORMERS_OFFLINE for nightly vLLM benchmark runs#176553
Closed
huydhn wants to merge 1 commit intopytorch:mainfrom
Closed
[CI] Disable TRANSFORMERS_OFFLINE for nightly vLLM benchmark runs#176553huydhn wants to merge 1 commit intopytorch:mainfrom
huydhn wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/176553
Note: Links to docs will display an error until the docs builds have been completed. ⏳ 25 Pending, 1 Unrelated FailureAs of commit 067833d with merge base 9dfac50 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
Nightly scheduled runs should be able to download from HuggingFace directly rather than being restricted to the local cache. This adds an `is_nightly` input to the reusable workflow, set to true when the caller detects `github.event_name == 'schedule'`. Manual dispatch runs continue to use the cache (TRANSFORMERS_OFFLINE=1). Includes a comment explaining the rationale for the nightly override. Signed-off-by: Huy Do <huydhn@gmail.com>
789b1dc to
067833d
Compare
zou3519
approved these changes
Mar 5, 2026
Contributor
Author
|
@pytorchbot merge -f 'CI only tweak, should be fine' |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Vighaneshs
pushed a commit
to Vighaneshs/pytorch
that referenced
this pull request
Mar 5, 2026
…torch#176553) Instead of always using offline mode, we need to have a way to periodically refresh the local cache. This job runs only once per day, so rate limit wouldn't be an issue I observe [a failure in trunk](https://github.com/pytorch/pytorch/actions/runs/22625578355/job/65575251092#step:15:13837) for `pytorch/gemma-3-12b-it-int4` where the local cache doesn't seem to work anymore, not sure why, could be due to the recent transformers version update. The failure goes away when I turn off TRANSFORMERS_OFFLINE to refresh the local cache. Pull Request resolved: pytorch#176553 Approved by: https://github.com/zou3519
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of always using offline mode, we need to have a way to periodically refresh the local cache. This job runs only once per day, so rate limit wouldn't be an issue
I observe a failure in trunk for
pytorch/gemma-3-12b-it-int4where the local cache doesn't seem to work anymore, not sure why, could be due to the recent transformers version update. The failure goes away when I turn off TRANSFORMERS_OFFLINE to refresh the local cache.