[claude code review] Add CONTRIBUTOR role to Claude Code precheck conditions#176522
[claude code review] Add CONTRIBUTOR role to Claude Code precheck conditions#176522izaitsevfb wants to merge 1 commit intomainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/176522
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 52 PendingAs of commit da0ea6e with merge base 23c859c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
left a comment
There was a problem hiding this comment.
Why not delete this check altogether, as bar for being a contributor is very low (you need to submit one typo fixing PR)
just to prevent somebody spamming |
|
@pytorchbot merge -f 'lint passed' |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
What prevents them from creating issues that would spawn claude jobs as well? |
good question. we should probably limit concurrency of the triage jobs by the author |
…ditions (pytorch#176522) There is a bug in github webhooks. When fired for `pull_request_review_comment` trigger, the `author_association` is `CONTRIBUTOR` (always?). This messes up the pre-check logic for review workflow, causing it to skip. This PR relaxes the pre-check (it's an optimization anyway), and I also relaxed `bedrock` environment protection rules, allowing PR merge branches. [tested in ciforge](https://github.com/pytorch/ciforge/pull/145#discussion_r2886777001) Pull Request resolved: pytorch#176522 Approved by: https://github.com/drisspg
- Add CONTRIBUTOR to author_association check per pytorch/pytorch#176522 - Clarify setup script comment references pytorch/test-infra
There is a bug in github webhooks.
When fired for
pull_request_review_commenttrigger, theauthor_associationisCONTRIBUTOR(always?).This messes up the pre-check logic for review workflow, causing it to skip.
This PR relaxes the pre-check (it's an optimization anyway), and I also relaxed
bedrockenvironment protection rules, allowing PR merge branches.tested in ciforge