[DTensor] Track per-output placements for multi-output ops in strategy_validation#176361
Closed
pianpwk wants to merge 1 commit intogh/pianpwk/108/basefrom
Closed
[DTensor] Track per-output placements for multi-output ops in strategy_validation#176361pianpwk wants to merge 1 commit intogh/pianpwk/108/basefrom
pianpwk wants to merge 1 commit intogh/pianpwk/108/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/176361
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 1 Unrelated FailureAs of commit c9ab0d5 with merge base ea9fce2 ( NEW FAILURE - The following job has failed:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
sandy-gags
pushed a commit
to sandy-gags/pytorch
that referenced
this pull request
Mar 12, 2026
…y_validation For multi-output ops like aten.min.dim (returns values + indices), the tool now tracks each output's placement separately instead of using a single output placement for all outputs. This makes the display explicit: `S(1) -> (P(min), P(min))` shows both outputs get P(min). ComboKey changes from (inputs, single_output_str) to (inputs, output_strs_tuple). PlacementCombination is simplified to a plain type alias. normalize_combo_key normalizes each output against its own shape. ghstack-source-id: cf4804a Pull request resolved: pytorch/pytorch#175893 ghstack-source-id: 456408c Pull-Request: pytorch/pytorch#176361
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
For multi-output ops like aten.min.dim (returns values + indices), the
tool now tracks each output's placement separately instead of using a
single output placement for all outputs. This makes the display explicit:
S(1) -> (P(min), P(min))shows both outputs get P(min).ComboKey changes from (inputs, single_output_str) to (inputs,
output_strs_tuple). PlacementCombination is simplified to a plain type
alias. normalize_combo_key normalizes each output against its own shape.
Pull request resolved: #175893