Skip to content

Enable FMA-based addcdiv lowering for XPU#176163

Closed
guangyey wants to merge 2 commits intogh/guangyey/294/basefrom
gh/guangyey/294/head
Closed

Enable FMA-based addcdiv lowering for XPU#176163
guangyey wants to merge 2 commits intogh/guangyey/294/basefrom
gh/guangyey/294/head

Conversation

@guangyey
Copy link
Copy Markdown
Collaborator

@guangyey guangyey commented Mar 2, 2026 •
edited
Loading

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Mar 2, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/176163

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (5 Unrelated Failures)

As of commit 8799a71 with merge base 915982a (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@guangyey guangyey mentioned this pull request Mar 2, 2026
Closed
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Mar 2, 2026

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

guangyey added a commit that referenced this pull request Mar 2, 2026
@guangyey
Enable FMA-based addcdiv lowering for XPU
17ec68c 
ghstack-source-id: a025f55
Pull Request resolved: #176163
guangyey added a commit that referenced this pull request Mar 2, 2026
@guangyey
Enable FMA-based addcdiv lowering for XPU
63a8c6b 
ghstack-source-id: a025f55
Pull Request resolved: #176163
@guangyey guangyey requested review from desertfire and jansel March 2, 2026 14:42
@guangyey guangyey added ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks labels Mar 2, 2026
@guangyey
Update
0b844b0 
[ghstack-poisoned]
guangyey added a commit that referenced this pull request Mar 4, 2026
@guangyey
Enable FMA-based addcdiv lowering for XPU
ad2aa2c 
ghstack-source-id: 375e243
Pull Request resolved: #176163
@guangyey
Copy link
Copy Markdown
Collaborator Author

guangyey commented Mar 4, 2026

Thanks!
@pytorchbot merge

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Mar 4, 2026

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Mar 4, 2026

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@guangyey
Copy link
Copy Markdown
Collaborator Author

guangyey commented Mar 4, 2026

The unrelated test failure will be fixed in #176057. Land this PR to fix the #176152 first
@pytorchbot merge

@guangyey guangyey added the release notes: xpu release notes category label Mar 4, 2026
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Mar 4, 2026

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@guangyey
Update
8799a71 
[ghstack-poisoned]
@guangyey guangyey mentioned this pull request Mar 16, 2026
Closed
EmanueleCoradin pushed a commit to EmanueleCoradin/pytorch that referenced this pull request Mar 30, 2026
@guangyey @EmanueleCoradin
Enable FMA-based addcdiv lowering for XPU (pytorch#176163)
cd43f4c 
# Motivation
pytorch#174912 introduces this feature on CUDA, this PR aims to enable it for XPU.

# Additional Context
fix pytorch#176152
fix pytorch#176157
fix pytorch#176168
fix pytorch#176407

Pull Request resolved: pytorch#176163
Approved by: https://github.com/jansel
@github-actions github-actions Bot deleted the gh/guangyey/294/head branch April 4, 2026 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jansel jansel jansel approved these changes

@desertfire desertfire Awaiting requested review from desertfire

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request ciflow/xpu Run XPU CI tasks Merged module: inductor open source release notes: xpu release notes category

Projects

PyTorch Intel
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@guangyey @pytorchmergebot @jansel @pytorchbot