Store ScalarType and Backend instead of Type in TensorIterator#17601
Closed
li-roy wants to merge 69 commits intoexport-D14443117from
Closed
Store ScalarType and Backend instead of Type in TensorIterator#17601li-roy wants to merge 69 commits intoexport-D14443117from
li-roy wants to merge 69 commits intoexport-D14443117from
Conversation
added 13 commits
February 26, 2019 14:15
Differential Revision: D14233250 Differential Version: 73474786
Differential Revision: D14233250 Differential Version: 73486177
Differential Revision: D14235395 Differential Version: 73486176
Differential Revision: D14237932 Differential Version: 73508674
Differential Revision: D14237931 Differential Version: 73508673
Differential Revision: D14235395 Differential Version: 73589963
Differential Revision: D14237932 Differential Version: 73589962
Differential Revision: D14237931 Differential Version: 73589961
Differential Revision: D14237932 Differential Version: 73659349
Differential Revision: D14237931 Differential Version: 73659351
Differential Revision: D14237932 Differential Version: 73714105
Differential Revision: D14237931 Differential Version: 73714104
Differential Revision: D14274754 Differential Version: 73828025
This was referenced Mar 1, 2019
Differential Revision: D14274754 Differential Version: 73946909
added 10 commits
March 5, 2019 15:03
Differential Revision: D14274754 Differential Version: 74349068
Differential Revision: D14235395 Differential Version: 74395307
Differential Revision: D14233250 Differential Version: 74395306
Differential Revision: D14237932 Differential Version: 74395305
Differential Revision: D14237931 Differential Version: 74395302
Differential Revision: D14274754 Differential Version: 74395303
Differential Revision: D14235395 Differential Version: 74488005
Differential Revision: D14237932 Differential Version: 74488004
Differential Revision: D14237931 Differential Version: 74488002
Differential Revision: D14274754 Differential Version: 74488003
added 12 commits
March 8, 2019 13:27
Differential Revision: D14237932 Differential Version: 74811463
Differential Revision: D14237931 Differential Version: 74811456
Differential Revision: D14274754 Differential Version: 74811462
Differential Revision: D14235395 Differential Version: 74818459
Differential Revision: D14237932 Differential Version: 74818452
Differential Revision: D14237931 Differential Version: 74818453
Differential Revision: D14274754 Differential Version: 74818462
Differential Revision: D14237931 Differential Version: 74843005
Differential Revision: D14274754 Differential Version: 74842999
Differential Revision: D14237931 Differential Version: 74983509
Differential Revision: D14274754 Differential Version: 74983510
Differential Revision: D14274754 Differential Version: 77464129
added 9 commits
April 1, 2019 12:26
Differential Revision: D14274754 Differential Version: 77644958
Differential Revision: D14274754 Differential Version: 77671915
Differential Revision: D14274754 Differential Version: 77808609
Differential Revision: D14274754 Differential Version: 77838951
Differential Revision: D14274754 Differential Version: 78000627
Differential Revision: D14274754 Differential Version: 78016244
Differential Revision: D14274754 Differential Version: 78021890
Differential Revision: D14274754 Differential Version: 78048256
Differential Revision: D14274754 Differential Version: 78065246
Contributor
|
This pull request has been merged in f5741eb. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Apr 4, 2019
Summary: Pull Request resolved: pytorch/pytorch#17601 Reviewed By: ezyang Differential Revision: D14274754 fbshipit-source-id: b08880ae586b6ae57d4c0bbeb203796d087926c4
Contributor
|
Was the |
Contributor
Author
|
There wasn't really anything preventing people from trying to use sparse Type with the old TensorIterator, so I don't think this patch made anything worse. If we want to fix this, I think keeping Backend and erroring out on bad Backends is a better alternative to using DeviceType. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #17991 Introduce DeprecatedTypeProperties class 💚
:black_circle: #17601 Store ScalarType and Backend instead of Type in TensorIterator 💚
:white_circle: #17786 Pass ScalarType separately from Type in python constructors 💚
Differential Revision: D14274754