Use TORCH_SYM_CHECK in nll_loss_nd_symint for symbolic size comparison to avoid DDE #175956
Closed
laithsakka wants to merge 11 commits intogh/laithsakka/412/basefrom
Closed
Use TORCH_SYM_CHECK in nll_loss_nd_symint for symbolic size comparison to avoid DDE #175956laithsakka wants to merge 11 commits intogh/laithsakka/412/basefrom
laithsakka wants to merge 11 commits intogh/laithsakka/412/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/175956
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit c1ab3be with merge base 07efc60 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Feb 27, 2026
This PR needs a
|
This was referenced Feb 27, 2026
Skylion007
reviewed
Feb 27, 2026
torch/_decomp/decompositions.py
Outdated
| raise AssertionError( | ||
| f"size mismatch (got input: {self.shape}, target: {target.shape})" | ||
| ) | ||
| torch._check( |
Collaborator
There was a problem hiding this comment.
Double check, we might have Python bindings to torch._check_sym or something? Even if it's not documented well? Or at least torch._check_assert
Contributor
Author
There was a problem hiding this comment.
torch._check shall behave like TORCH_SYM_CHECK
the issue was sym_or does not short circuit addressed, so i get access out of bounds.
addressed
…ze comparison to avoid DDE " encountered while running python benchmarks/dynamo/huggingface.py --only AllenaiLongformerBase --backend inductor --performance --inference --unbacked-batch-only [ghstack-poisoned]
…ze comparison to avoid DDE " encountered while running python benchmarks/dynamo/huggingface.py --only AllenaiLongformerBase --backend inductor --performance --inference --unbacked-batch-only [ghstack-poisoned]
…ze comparison to avoid DDE " encountered while running python benchmarks/dynamo/huggingface.py --only AllenaiLongformerBase --backend inductor --performance --inference --unbacked-batch-only [ghstack-poisoned]
…ze comparison to avoid DDE " encountered while running python benchmarks/dynamo/huggingface.py --only AllenaiLongformerBase --backend inductor --performance --inference --unbacked-batch-only [ghstack-poisoned]
ColinPeppler
approved these changes
Mar 2, 2026
…ze comparison to avoid DDE " encountered while running python benchmarks/dynamo/huggingface.py --only AllenaiLongformerBase --backend inductor --performance --inference --unbacked-batch-only [ghstack-poisoned]
…ze comparison to avoid DDE " encountered while running python benchmarks/dynamo/huggingface.py --only AllenaiLongformerBase --backend inductor --performance --inference --unbacked-batch-only [ghstack-poisoned]
This was referenced Mar 3, 2026
Contributor
Author
i messed up the rebase it was clean |
…ze comparison to avoid DDE " encountered while running python benchmarks/dynamo/huggingface.py --only AllenaiLongformerBase --backend inductor --performance --inference --unbacked-batch-only [ghstack-poisoned]
…ze comparison to avoid DDE " encountered while running python benchmarks/dynamo/huggingface.py --only AllenaiLongformerBase --backend inductor --performance --inference --unbacked-batch-only [ghstack-poisoned]
This was referenced Mar 3, 2026
jansel
approved these changes
Mar 4, 2026
…ze comparison to avoid DDE " encountered while running python benchmarks/dynamo/huggingface.py --only AllenaiLongformerBase --backend inductor --performance --inference --unbacked-batch-only [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Mar 10, 2026
Adds min and max parameters to mark_unbacked() to allow specifying value range constraints for unbacked dimensions. When an unbacked symbol is created with min/max bounds, torch._check() calls are emitted to establish the constraints (e.g., torch._check(u0 >= 1)). Pull Request resolved: #176313 Approved by: https://github.com/Lucaskabela, https://github.com/mlazos ghstack dependencies: #175946, #175956
sandy-gags
pushed a commit
to sandy-gags/pytorch
that referenced
this pull request
Mar 12, 2026
ghstack-source-id: d1f66c0 Pull Request resolved: pytorch/pytorch#175956
sandy-gags
pushed a commit
to sandy-gags/pytorch
that referenced
this pull request
Mar 12, 2026
ghstack-source-id: 5491787 Pull Request resolved: pytorch/pytorch#175956
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
encountered while running
python benchmarks/dynamo/huggingface.py --only AllenaiLongformerBase --backend inductor --performance --inference --unbacked-batch-only