[DTensor] Report strategy_validation results per aten op variant#175892
Closed
pianpwk wants to merge 2 commits intogh/pianpwk/104/basefrom
Closed
[DTensor] Report strategy_validation results per aten op variant#175892pianpwk wants to merge 2 commits intogh/pianpwk/104/basefrom
pianpwk wants to merge 2 commits intogh/pianpwk/104/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/175892
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit a65416d with merge base 7e0feca ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
wconstab
reviewed
Feb 26, 2026
| _assert_keys_normalized(ground_truth_valid, input_shapes, output_shape) | ||
| _assert_keys_normalized(dtensor_rules, input_shapes, output_shape) | ||
|
|
||
| op_str = str(aten_op) if aten_op else "(unknown)" |
Contributor
There was a problem hiding this comment.
when can aten_op be unknown- is it just for the case the aten op was not found and we are basically going to abort the validator?
Contributor
Author
There was a problem hiding this comment.
ah seems like defensive code, we shouldn't reach this
wconstab
approved these changes
Feb 26, 2026
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 1, 3, macos-m1-stable) Details for Dev Infra teamRaised by workflow job |
Contributor
Author
|
@pytorchbot merge -i |
Collaborator
Merge startedYour change will be merged while ignoring the following 1 checks: trunk / macos-py3-arm64 / test (default, 1, 3, macos-m1-stable) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Feb 28, 2026
…y validation (#175893) For multi-output ops like aten.min.dim (returns values + indices), the tool now tracks each output's placement separately instead of using a single output placement for all outputs. This makes the display explicit: `S(1) -> (P(min), P(min))` shows both outputs get P(min). ComboKey changes from (inputs, single_output_str) to (inputs, output_strs_tuple). PlacementCombination is simplified to a plain type alias. normalize_combo_key normalizes each output against its own shape. Pull Request resolved: #175893 Approved by: https://github.com/wconstab ghstack dependencies: #175892
sandy-gags
pushed a commit
to sandy-gags/pytorch
that referenced
this pull request
Mar 13, 2026
When an OpInfo covers multiple aten variants (e.g. aten.min.default, aten.min.dim, aten.minimum.default), break down the correct/incorrect/ missing counts per variant so it's clear which variant has issues. ghstack-source-id: 927212a Pull-Request: pytorch/pytorch#175892
EmanueleCoradin
pushed a commit
to EmanueleCoradin/pytorch
that referenced
this pull request
Mar 30, 2026
…orch#175892) When an OpInfo covers multiple aten variants (e.g. aten.min.default, aten.min.dim, aten.minimum.default), break down the correct/incorrect/ missing counts per variant so it's clear which variant has issues. Pull Request resolved: pytorch#175892 Approved by: https://github.com/wconstab
EmanueleCoradin
pushed a commit
to EmanueleCoradin/pytorch
that referenced
this pull request
Mar 30, 2026
…y validation (pytorch#175893) For multi-output ops like aten.min.dim (returns values + indices), the tool now tracks each output's placement separately instead of using a single output placement for all outputs. This makes the display explicit: `S(1) -> (P(min), P(min))` shows both outputs get P(min). ComboKey changes from (inputs, single_output_str) to (inputs, output_strs_tuple). PlacementCombination is simplified to a plain type alias. normalize_combo_key normalizes each output against its own shape. Pull Request resolved: pytorch#175893 Approved by: https://github.com/wconstab ghstack dependencies: pytorch#175892
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
When an OpInfo covers multiple aten variants (e.g. aten.min.default,
aten.min.dim, aten.minimum.default), break down the correct/incorrect/
missing counts per variant so it's clear which variant has issues.