[MPS] Return pivots from linalg_solve_out_mps_impl#175284
Closed
malfet wants to merge 1 commit intogh/malfet/711/basefrom
Closed
[MPS] Return pivots from linalg_solve_out_mps_impl#175284malfet wants to merge 1 commit intogh/malfet/711/basefrom
linalg_solve_out_mps_impl#175284malfet wants to merge 1 commit intogh/malfet/711/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/175284
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ef1180e with merge base c931944 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
added a commit
that referenced
this pull request
Feb 18, 2026
manuelcandales
approved these changes
Feb 18, 2026
Contributor
Author
|
@pytorchbot merge -f "Lint + MPS are green" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
norx1991
pushed a commit
that referenced
this pull request
Feb 24, 2026
I should have been more careful while reviewing #146531 which initialized pivot tensors but never copied them back (nor offset them by 1 as LAPACK/Fortran expects) Fixes #175192 Pull Request resolved: #175284 Approved by: https://github.com/manuelcandales
EmanueleCoradin
pushed a commit
to EmanueleCoradin/pytorch
that referenced
this pull request
Mar 30, 2026
I should have been more careful while reviewing pytorch#146531 which initialized pivot tensors but never copied them back (nor offset them by 1 as LAPACK/Fortran expects) Fixes pytorch#175192 Pull Request resolved: pytorch#175284 Approved by: https://github.com/manuelcandales
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
linalg_solve_out_mps_impl#175284I should have been more careful while reviewing #146531 which initialized pivot tensors but never copied them back (nor offset them by 1 as LAPACK/Fortran expects)
Fixes #175192