[inductor] Add bitwise tests for compiled Adam/AdamW#174911
Closed
mlazos wants to merge 40 commits intogh/mlazos/100/basefrom
Closed
[inductor] Add bitwise tests for compiled Adam/AdamW#174911mlazos wants to merge 40 commits intogh/mlazos/100/basefrom
mlazos wants to merge 40 commits intogh/mlazos/100/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/174911
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit 2dda222 with merge base a6beff3 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Feb 12, 2026
mlazos
added a commit
that referenced
this pull request
Feb 12, 2026
Add CompiledOptimizerBitwiseTests test suite that verifies compiled optimizers produce bitwise identical results to eager when precision configs are enabled: - eager_numerics.division_rounding = True - eager_numerics.pow_precision = True - emulate_precision_casts = True Tests cover Adam and AdamW with various configurations including amsgrad, maximize, and weight_decay options. ghstack-source-id: a1c6174 Pull-Request: #174911
mlazos
added a commit
that referenced
this pull request
Feb 18, 2026
Add CompiledOptimizerBitwiseTests test suite that verifies compiled optimizers produce bitwise identical results to eager when precision configs are enabled: - eager_numerics.division_rounding = True - eager_numerics.pow_precision = True - emulate_precision_casts = True Tests cover Adam and AdamW with various configurations including amsgrad, maximize, and weight_decay options. ghstack-source-id: 95f8455 Pull-Request: #174911
mlazos
added a commit
that referenced
this pull request
Feb 18, 2026
Add CompiledOptimizerBitwiseTests test suite that verifies compiled optimizers produce bitwise identical results to eager when precision configs are enabled: - eager_numerics.division_rounding = True - eager_numerics.pow_precision = True - emulate_precision_casts = True Tests cover Adam and AdamW with various configurations including amsgrad, maximize, and weight_decay options. ghstack-source-id: 2460231 Pull-Request: #174911
mlazos
added a commit
that referenced
this pull request
Feb 18, 2026
Add CompiledOptimizerBitwiseTests test suite that verifies compiled optimizers produce bitwise identical results to eager when precision configs are enabled: - eager_numerics.division_rounding = True - eager_numerics.pow_precision = True - emulate_precision_casts = True Tests cover Adam and AdamW with various configurations including amsgrad, maximize, and weight_decay options. ghstack-source-id: 2460231 Pull-Request: #174911
mlazos
added a commit
that referenced
this pull request
Feb 18, 2026
Add CompiledOptimizerBitwiseTests test suite that verifies compiled optimizers produce bitwise identical results to eager when precision configs are enabled: - eager_numerics.division_rounding = True - eager_numerics.pow_precision = True - emulate_precision_casts = True Tests cover Adam and AdamW with various configurations including amsgrad, maximize, and weight_decay options. ghstack-source-id: c708d67 Pull-Request: #174911
mlazos
added a commit
that referenced
this pull request
Feb 19, 2026
Add CompiledOptimizerBitwiseTests test suite that verifies compiled optimizers produce bitwise identical results to eager when precision configs are enabled: - eager_numerics.division_rounding = True - eager_numerics.pow_precision = True - emulate_precision_casts = True Tests cover Adam and AdamW with various configurations including amsgrad, maximize, and weight_decay options. ghstack-source-id: 2e46fb4 Pull-Request: #174911
mlazos
added a commit
that referenced
this pull request
Feb 28, 2026
Add CompiledOptimizerBitwiseTests test suite that verifies compiled optimizers produce bitwise identical results to eager when precision configs are enabled: - eager_numerics.division_rounding = True - eager_numerics.pow_precision = True - emulate_precision_casts = True Tests cover Adam and AdamW with various configurations including amsgrad, maximize, and weight_decay options. ghstack-source-id: ee65756 Pull-Request: #174911
mlazos
added a commit
that referenced
this pull request
Feb 28, 2026
Add CompiledOptimizerBitwiseTests test suite that verifies compiled optimizers produce bitwise identical results to eager when precision configs are enabled: - eager_numerics.division_rounding = True - eager_numerics.pow_precision = True - emulate_precision_casts = True Tests cover Adam and AdamW with various configurations including amsgrad, maximize, and weight_decay options. ghstack-source-id: 28662ba Pull-Request: #174911
mlazos
added a commit
that referenced
this pull request
Mar 2, 2026
Add CompiledOptimizerBitwiseTests test suite that verifies compiled optimizers produce bitwise identical results to eager when precision configs are enabled: - eager_numerics.division_rounding = True - eager_numerics.pow_precision = True - emulate_precision_casts = True Tests cover Adam and AdamW with various configurations including amsgrad, maximize, and weight_decay options. ghstack-source-id: 9032d6c Pull-Request: #174911
mlazos
added a commit
that referenced
this pull request
Mar 2, 2026
Add CompiledOptimizerBitwiseTests test suite that verifies compiled optimizers produce bitwise identical results to eager when precision configs are enabled: - eager_numerics.division_rounding = True - eager_numerics.pow_precision = True - emulate_precision_casts = True Tests cover Adam and AdamW with various configurations including amsgrad, maximize, and weight_decay options. ghstack-source-id: 13a2da2 Pull-Request: #174911
mlazos
added a commit
that referenced
this pull request
Mar 2, 2026
Add CompiledOptimizerBitwiseTests test suite that verifies compiled optimizers produce bitwise identical results to eager when precision configs are enabled: - eager_numerics.division_rounding = True - eager_numerics.pow_precision = True - emulate_precision_casts = True Tests cover Adam and AdamW with various configurations including amsgrad, maximize, and weight_decay options. ghstack-source-id: 13a2da2 Pull-Request: #174911
mlazos
added a commit
that referenced
this pull request
Mar 2, 2026
Add CompiledOptimizerBitwiseTests test suite that verifies compiled optimizers produce bitwise identical results to eager when precision configs are enabled: - eager_numerics.division_rounding = True - eager_numerics.pow_precision = True - emulate_precision_casts = True Tests cover Adam and AdamW with various configurations including amsgrad, maximize, and weight_decay options. ghstack-source-id: 1b160e5 Pull-Request: #174911
mlazos
added a commit
that referenced
this pull request
Mar 2, 2026
Add CompiledOptimizerBitwiseTests test suite that verifies compiled optimizers produce bitwise identical results to eager when precision configs are enabled: - eager_numerics.division_rounding = True - eager_numerics.pow_precision = True - emulate_precision_casts = True Tests cover Adam and AdamW with various configurations including amsgrad, maximize, and weight_decay options. ghstack-source-id: 7ddcd24 Pull-Request: #174911
mlazos
added a commit
that referenced
this pull request
Mar 2, 2026
Add CompiledOptimizerBitwiseTests test suite that verifies compiled optimizers produce bitwise identical results to eager when precision configs are enabled: - eager_numerics.division_rounding = True - eager_numerics.pow_precision = True - emulate_precision_casts = True Tests cover Adam and AdamW with various configurations including amsgrad, maximize, and weight_decay options. ghstack-source-id: a7031f2 Pull-Request: #174911
mlazos
added a commit
that referenced
this pull request
Mar 3, 2026
Add CompiledOptimizerBitwiseTests test suite that verifies compiled optimizers produce bitwise identical results to eager when precision configs are enabled: - eager_numerics.division_rounding = True - eager_numerics.pow_precision = True - emulate_precision_casts = True Tests cover Adam and AdamW with various configurations including amsgrad, maximize, and weight_decay options. ghstack-source-id: b59afbb Pull-Request: #174911
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
postmath
pushed a commit
to postmath/pytorch
that referenced
this pull request
Mar 3, 2026
Add CompiledOptimizerBitwiseTests test suite that verifies compiled optimizers produce bitwise identical results to eager when precision configs are enabled: - eager_numerics.division_rounding = True - eager_numerics.pow_precision = True - emulate_precision_casts = True Tests cover Adam and AdamW with various configurations including amsgrad, maximize, and weight_decay options. Pull Request resolved: pytorch#174911 Approved by: https://github.com/v0i0 ghstack dependencies: pytorch#176237, pytorch#175839
EmanueleCoradin
pushed a commit
to EmanueleCoradin/pytorch
that referenced
this pull request
Mar 30, 2026
Add CompiledOptimizerBitwiseTests test suite that verifies compiled optimizers produce bitwise identical results to eager when precision configs are enabled: - eager_numerics.division_rounding = True - eager_numerics.pow_precision = True - emulate_precision_casts = True Tests cover Adam and AdamW with various configurations including amsgrad, maximize, and weight_decay options. Pull Request resolved: pytorch#174911 Approved by: https://github.com/v0i0 ghstack dependencies: pytorch#176237, pytorch#175839
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Add CompiledOptimizerBitwiseTests test suite that verifies compiled
optimizers produce bitwise identical results to eager when precision
configs are enabled:
Tests cover Adam and AdamW with various configurations including
amsgrad, maximize, and weight_decay options.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @jataylo