[dynamo][index] Speedup index method for constant data structures#173612
[dynamo][index] Speedup index method for constant data structures#173612anijain2305 wants to merge 1 commit intogh/anijain2305/990/basefrom
Conversation
This PR needs a
|
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/173612
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b5d19f4 with merge base cec00df ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Lucaskabela
left a comment
There was a problem hiding this comment.
Generally LGTM - I think for posterity we can comment an example of what the "constant data structure" is
| kwargs, | ||
| ) | ||
| try: | ||
| # Speedup trace times for constant data structures |
There was a problem hiding this comment.
nit: Let's add a comment like:
# example would be a variable for a list like x = [1, 2, 3, 4]
|
Starting merge as part of PR stack under #173645 |
Saves 0.3 second on 14.8 seconds of compile time. Pull Request resolved: #173645 Approved by: https://github.com/Lucaskabela ghstack dependencies: #173582, #173612
…torch#173612) Saves 0.5 seconds on 15.3 seconds of compile time of a model Pull Request resolved: pytorch#173612 Approved by: https://github.com/Lucaskabela ghstack dependencies: pytorch#173582
Saves 0.3 second on 14.8 seconds of compile time. Pull Request resolved: pytorch#173645 Approved by: https://github.com/Lucaskabela ghstack dependencies: pytorch#173582, pytorch#173612
Stack from ghstack (oldest at bottom):
Saves 0.5 seconds on 15.3 seconds of compile time of a model
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @kadeng @chauhang @amjames @Lucaskabela @jataylo