Skip to content

[DTensor] Update TP api to support single-dim strategies#173567

Closed
wconstab wants to merge 3 commits intogh/wconstab/507/basefrom
gh/wconstab/507/head
Closed

[DTensor] Update TP api to support single-dim strategies#173567
wconstab wants to merge 3 commits intogh/wconstab/507/basefrom
gh/wconstab/507/head

Conversation

@wconstab
Copy link
Copy Markdown
Contributor

@wconstab wconstab commented Jan 27, 2026 •
edited
Loading

@wconstab wconstab mentioned this pull request Jan 27, 2026
Closed
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Jan 27, 2026

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@wconstab wconstab mentioned this pull request Jan 27, 2026
Closed
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Jan 27, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/173567

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit 0e325ed with merge base 7754b55 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot Bot added the release notes: distributed (dtensor) release notes category label Jan 27, 2026
@wconstab wconstab mentioned this pull request Jan 27, 2026
Closed
@wconstab wconstab mentioned this pull request Jan 27, 2026
Closed
@wconstab wconstab requested review from fegin and tianyu-l January 28, 2026 03:34
@wconstab wconstab mentioned this pull request Jan 28, 2026
Closed
tianyu-l
tianyu-l approved these changes Jan 28, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@tianyu-l tianyu-l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually don't know where this file is used. The change seems harmless though.

@wconstab
Copy link
Copy Markdown
Contributor Author

wconstab commented Jan 28, 2026

I don't know the use case for this file other than some unit test failed when I enabled single dim point wise rule without this change.

@wconstab
Copy link
Copy Markdown
Contributor Author

wconstab commented Jan 28, 2026

@pytorchbot merge

@pytorch-bot pytorch-bot Bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 28, 2026
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jan 28, 2026

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jan 28, 2026

Merge failed

Reason: 2 jobs have failed, first few of them are: trunk / win-vs2022-cpu-py3 / build, trunk / win-vs2022-cuda12.8-py3 / build

Details for Dev Infra team Raised by workflow job

@wconstab
Copy link
Copy Markdown
Contributor Author

wconstab commented Jan 28, 2026

@pytorchbot merge -i

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jan 28, 2026

Merge started

Your change will be merged while ignoring the following 0 checks:

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

kapilsh pushed a commit to kapilsh/pytorch that referenced this pull request Feb 2, 2026
@wconstab @kapilsh
[DTensor] Update TP api to support single-dim strategies (pytorch#173567
f2a23f4 
)

Pull Request resolved: pytorch#173567
Approved by: https://github.com/tianyu-l, https://github.com/fegin
ghstack dependencies: pytorch#172479, pytorch#173572
@github-actions github-actions Bot deleted the gh/wconstab/507/head branch February 28, 2026 02:21
sandy-gags pushed a commit to sandy-gags/pytorch that referenced this pull request Mar 12, 2026
@wconstab
[DTensor] Update TP api to support single-dim strategies
94375a9 
ghstack-source-id: a6fca05
Pull Request resolved: pytorch/pytorch#173567
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fegin fegin fegin approved these changes

@tianyu-l tianyu-l tianyu-l approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: distributed (dtensor) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wconstab @pytorchmergebot @fegin @tianyu-l