Skip to content

add hasattr check when print 'triton not found' warning#173397

Closed
blchxfm wants to merge 1 commit intopytorch:mainfrom
blchxfm:export-D91038779
Closed

add hasattr check when print 'triton not found' warning#173397
blchxfm wants to merge 1 commit intopytorch:mainfrom
blchxfm:export-D91038779

Conversation

@blchxfm
Copy link
Copy Markdown
Contributor

@blchxfm blchxfm commented Jan 26, 2026

Summary:
D90903684 is breaking our torchstream tests and this should fix it.
see https://www.internalfb.com/intern/test/562950222982678.

Test Plan: buck test -j 18 fbsource//arvr/mode/mac-arm/opt fbcode//frl/ctrl/src2-main/platform/torchstream_ctrl/torchstream_ctrl/prod/tests:test_modules-arvr -- --exact 'fbcode//frl/ctrl/src2-main/platform/torchstream_ctrl/torchstream_ctrl/prod/tests:test_modules-arvr - test_ptq_compatibility (torchstream_ctrl.prod.tests.test_modules.Test_TdsBlock)' --stress-runs 20 --record-results

Reviewed By: ogbiggles

Differential Revision: D91038779

Regression caused by #172614

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Jan 26, 2026

This appears to be a diff that was exported from phabricator, but the PR author does not have sufficient permissions to run CI. @blchxfm, please do step 2 of internal wiki to get write access so you do not need to get CI approvals in the future. If you think this is a mistake, please contact the Pytorch Dev Infra team.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Jan 26, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/173397

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 2f29543 with merge base e9e4275 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link
Copy Markdown

linux-foundation-easycla bot commented Jan 26, 2026

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: blchxfm / name: Lei Zhou (2f29543)

@meta-codesync
Copy link
Copy Markdown

meta-codesync bot commented Jan 26, 2026

@blchxfm has exported this pull request. If you are a Meta employee, you can view the originating Diff in D91038779.

blchxfm added a commit to blchxfm/pytorch that referenced this pull request Jan 26, 2026
Summary:

D90903684 is breaking our torchstream tests and this should fix it.
see https://www.internalfb.com/intern/test/562950222982678.

Test Plan: buck test -j 18 fbsource//arvr/mode/mac-arm/opt fbcode//frl/ctrl/src2-main/platform/torchstream_ctrl/torchstream_ctrl/prod/tests:test_modules-arvr -- --exact 'fbcode//frl/ctrl/src2-main/platform/torchstream_ctrl/torchstream_ctrl/prod/tests:test_modules-arvr - test_ptq_compatibility (torchstream_ctrl.prod.tests.test_modules.Test_TdsBlock)' --stress-runs 20 --record-results

Reviewed By: ogbiggles

Differential Revision: D91038779
@malfet
Copy link
Copy Markdown
Contributor

malfet commented Jan 26, 2026

/easycla

1 similar comment
@malfet
Copy link
Copy Markdown
Contributor

malfet commented Jan 26, 2026

/easycla

@malfet malfet added the topic: not user facing topic category label Jan 26, 2026
Summary:

D90903684 is breaking our torchstream tests and this should fix it.
see https://www.internalfb.com/intern/test/562950222982678.

Test Plan: buck test -j 18 fbsource//arvr/mode/mac-arm/opt fbcode//frl/ctrl/src2-main/platform/torchstream_ctrl/torchstream_ctrl/prod/tests:test_modules-arvr -- --exact 'fbcode//frl/ctrl/src2-main/platform/torchstream_ctrl/torchstream_ctrl/prod/tests:test_modules-arvr - test_ptq_compatibility (torchstream_ctrl.prod.tests.test_modules.Test_TdsBlock)' --stress-runs 20 --record-results

Reviewed By: ogbiggles

Differential Revision: D91038779
@malfet
Copy link
Copy Markdown
Contributor

malfet commented Jan 27, 2026

@pytorchbot merge -f "Landed internally"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

riccardofelluga pushed a commit to riccardofelluga/pytorch that referenced this pull request Jan 27, 2026
Summary:
D90903684 is breaking our torchstream tests and this should fix it.
see https://www.internalfb.com/intern/test/562950222982678.

Test Plan: buck test -j 18 fbsource//arvr/mode/mac-arm/opt fbcode//frl/ctrl/src2-main/platform/torchstream_ctrl/torchstream_ctrl/prod/tests:test_modules-arvr -- --exact 'fbcode//frl/ctrl/src2-main/platform/torchstream_ctrl/torchstream_ctrl/prod/tests:test_modules-arvr - test_ptq_compatibility (torchstream_ctrl.prod.tests.test_modules.Test_TdsBlock)' --stress-runs 20 --record-results

Reviewed By: ogbiggles

Differential Revision: D91038779

Regression caused by pytorch#172614
Pull Request resolved: pytorch#173397
Approved by: https://github.com/malfet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants