Skip to content

fix effect token handling when graph contains subgraphs without tokens#173226

Closed
bdhirsh wants to merge 1 commit intogh/bdhirsh/698/basefrom
gh/bdhirsh/698/head
Closed

fix effect token handling when graph contains subgraphs without tokens#173226
bdhirsh wants to merge 1 commit intogh/bdhirsh/698/basefrom
gh/bdhirsh/698/head

Conversation

@bdhirsh
Copy link
Collaborator

@bdhirsh bdhirsh commented Jan 23, 2026 •
edited
Loading

@bdhirsh bdhirsh requested a review from aorenste as a code owner January 23, 2026 23:10
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 23, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/173226

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 1 Unrelated Failure

As of commit a3d86d1 with merge base dad2e55 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

bdhirsh added a commit that referenced this pull request Jan 23, 2026
@bdhirsh
fix effect token handling when graph contains subgraphs without tokens
7b0e5e7 
ghstack-source-id: 9ec2346
Pull Request resolved: #173226
@bdhirsh bdhirsh added ciflow/trunk Trigger trunk jobs on your pull request release notes: aotdispatcher labels Jan 23, 2026
@bdhirsh
Copy link
Collaborator Author

bdhirsh commented Jan 26, 2026

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 26, 2026

Merge started

Your change will be merged while ignoring the following 4 checks: inductor / inductor-test-cuda13 / test (inductor_huggingface, 1, 1, linux.g5.4xlarge.nvidia.gpu), trunk / linux-jammy-cuda12.8-py3.10-gcc11 / test (default, 3, 5, linux.g6.4xlarge.experimental.nvidia.gpu), trunk / linux-jammy-cuda13.0-py3.10-gcc11 / test (default, 3, 5, linux.g6.4xlarge.experimental.nvidia.gpu), trunk / linux-jammy-rocm-py3.10 / test (default, 5, 6, linux.rocm.gpu.gfx942.1)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

riccardofelluga pushed a commit to riccardofelluga/pytorch that referenced this pull request Jan 27, 2026
@bdhirsh @riccardofelluga
fix effect token handling when graph contains subgraphs without tokens (
5bf4c65 
pytorch#173226)

Fixes pytorch#173222

Pull Request resolved: pytorch#173226
Approved by: https://github.com/angelayi
@github-actions github-actions bot deleted the gh/bdhirsh/698/head branch February 26, 2026 02:22
eqy pushed a commit to eqy/pytorch that referenced this pull request Mar 4, 2026
@aorenste
Complete aotdispatcher release notes for 2.11.0 (pytorch#177)
8e9abd6 
Categorized 1 PR:
- bug fixes: effect token handling fix for subgraphs without tokens (pytorch#173226)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@angelayi angelayi angelayi approved these changes

@aorenste aorenste Awaiting requested review from aorenste

@albanD albanD Awaiting requested review from albanD

@antoniojkim antoniojkim Awaiting requested review from antoniojkim

@ezyang ezyang Awaiting requested review from ezyang

@miladm miladm Awaiting requested review from miladm

@SherlockNoMad SherlockNoMad Awaiting requested review from SherlockNoMad

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: aotdispatcher

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bdhirsh @pytorchmergebot @angelayi