[dynamo] add USER_ERROR graph break hint to some dynamic shapes errors, chain underlying exceptions#172694
[dynamo] add USER_ERROR graph break hint to some dynamic shapes errors, chain underlying exceptions#172694williamwen42 wants to merge 6 commits intogh/williamwen42/380/basefrom
Conversation
…s, chain underlying exceptions [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/172694
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a213749 with merge base 1a7a87d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…hapes errors, chain underlying exceptions" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx kadeng chauhang amjames Lucaskabela jataylo [ghstack-poisoned]
…hapes errors, chain underlying exceptions" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx kadeng chauhang amjames Lucaskabela jataylo [ghstack-poisoned]
…hapes errors, chain underlying exceptions" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx kadeng chauhang amjames Lucaskabela jataylo [ghstack-poisoned]
| "Context": "fn={fn}, args={args}, kwargs={kwargs}", | ||
| "Explanation": "All __torch_function__ overrides for for function {fn} returned NotImplemented", | ||
| "Hints": [ | ||
| "Dynamo has detected that tracing the code will result in an error when running in eager. Please double check that your code doesn't contain a similar error when actually running eager/uncompiled." |
There was a problem hiding this comment.
Editing the entries directly (instead of adding new ones) should be fine since the graph break link generator (https://github.com/meta-pytorch/compile-graph-break-site/blob/main/generate-site.py and
Line 561 in a7d0474
…hapes errors, chain underlying exceptions" This is to improve error messages of Dynamo FX node failures, in particular: - we suggest the user to run their code in eager to see if the error occurs - we chain exceptions wherever we were missing them in torch/_dynamo/utils.py cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx kadeng chauhang amjames Lucaskabela jataylo [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 6 mandatory check(s) failed. The first few are:
Dig deeper by viewing the failures on hud |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 6 mandatory check(s) failed. The first few are:
Dig deeper by viewing the failures on hud |
|
@pytorchbot rebase |
|
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
|
Successfully rebased |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…underlying exceptions (#172694) Summary: This is to improve error messages of Dynamo FX node failures, in particular: - we suggest the user to run their code in eager to see if the error occurs - we chain exceptions wherever we were missing them in torch/_dynamo/utils.py X-link: pytorch/pytorch#172694 Approved by: https://github.com/pianpwk Reviewed By: izaitsevfb Differential Revision: D92237542 fbshipit-source-id: a627dc45275af5463928fe92bb9ec8c8ab1e6385
…s, chain underlying exceptions (pytorch#172694) This is to improve error messages of Dynamo FX node failures, in particular: - we suggest the user to run their code in eager to see if the error occurs - we chain exceptions wherever we were missing them in torch/_dynamo/utils.py Pull Request resolved: pytorch#172694 Approved by: https://github.com/pianpwk
…s, chain underlying exceptions (pytorch#172694) This is to improve error messages of Dynamo FX node failures, in particular: - we suggest the user to run their code in eager to see if the error occurs - we chain exceptions wherever we were missing them in torch/_dynamo/utils.py Pull Request resolved: pytorch#172694 Approved by: https://github.com/pianpwk
Stack from ghstack (oldest at bottom):
This is to improve error messages of Dynamo FX node failures, in particular:
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @kadeng @chauhang @amjames @Lucaskabela @jataylo