[DTensor] make expand_to_full_mesh_op_strategy filter incompatible out= strategies#172420
Closed
wconstab wants to merge 8 commits intogh/wconstab/497/basefrom
Closed
[DTensor] make expand_to_full_mesh_op_strategy filter incompatible out= strategies#172420wconstab wants to merge 8 commits intogh/wconstab/497/basefrom
wconstab wants to merge 8 commits intogh/wconstab/497/basefrom
Conversation
…t= strategies [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/172420
Note: Links to docs will display an error until the docs builds have been completed. ❌ 7 New Failures, 1 Pending, 1 Unrelated FailureAs of commit 2647e22 with merge base 879fd46 ( NEW FAILURES - The following jobs have failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jan 13, 2026
…mpatible out= strategies" [ghstack-poisoned]
…mpatible out= strategies" [ghstack-poisoned]
This was referenced Jan 14, 2026
pianpwk
reviewed
Jan 14, 2026
| if ( | ||
| op_schema.is_out_variant_op() | ||
| and "out" in op_schema.kwargs_schema | ||
| and isinstance(op_schema.kwargs_schema["out"], OpStrategy) |
Contributor
There was a problem hiding this comment.
nit: is there a TupleStrategy case we need to consider?
Contributor
Author
There was a problem hiding this comment.
are you talking about a case where out= provides a list of output tensors instead of a single tensor? I am not sure if such an op exists, trying to find one
pianpwk
approved these changes
Jan 14, 2026
…mpatible out= strategies" [ghstack-poisoned]
…mpatible out= strategies" [ghstack-poisoned]
…mpatible out= strategies" [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge failedReason: PR 172477 is out of sync with the corresponding revision 27ce290 on branch gh/wconstab/499/orig that would be merged into main. This usually happens because there is a non ghstack change in the PR. Please sync them and try again (ex. make the changes on origin/gh/wconstab/497/orig and run ghstack). Details for Dev Infra teamRaised by workflow job |
SergeyTyshkevich
pushed a commit
to SergeyTyshkevich/chart2
that referenced
this pull request
Jan 19, 2026
…t= strategies ghstack-source-id: 1a0ef00 Pull Request resolved: pytorch/pytorch#172420
…mpatible out= strategies" [ghstack-poisoned]
Collaborator
|
Starting merge as part of PR stack under #172477 |
…mpatible out= strategies" [ghstack-poisoned]
Collaborator
|
Starting merge as part of PR stack under #172477 |
1 similar comment
Collaborator
|
Starting merge as part of PR stack under #172477 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Jan 20, 2026
This enables the inplace filtering logic that skips strategies with incompatible input placements. Previously, inplace ops were able to generate expanded strategies incompatible with the current input placements, which aren't allowed to be modified by redistribution. Pull Request resolved: #172477 Approved by: https://github.com/zpcore ghstack dependencies: #172420
suncapitalllc007-star
pushed a commit
to suncapitalllc007-star/pytorch
that referenced
this pull request
Jan 25, 2026
…t= strategies ghstack-source-id: cec0535 Pull Request resolved: pytorch/pytorch#172420
suncapitalllc007-star
pushed a commit
to suncapitalllc007-star/pytorch
that referenced
this pull request
Jan 25, 2026
…t= strategies ghstack-source-id: 59a1306 Pull Request resolved: pytorch/pytorch#172420
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):