Skip to content

[SymmMem] Use initializer for devComm requirement#172400

Closed
kwen2501 wants to merge 1 commit intogh/kwen2501/309/basefrom
gh/kwen2501/309/head
Closed

[SymmMem] Use initializer for devComm requirement#172400
kwen2501 wants to merge 1 commit intogh/kwen2501/309/basefrom
gh/kwen2501/309/head

Conversation

@kwen2501
Copy link
Copy Markdown
Collaborator

@kwen2501 kwen2501 commented Jan 14, 2026 •
edited
Loading

Stack from ghstack (oldest at bottom):

Fixes #172398

NCCL_DEV_COMM_REQUIREMENTS_INITIALIZER available in NCCL 2.29.

@kwen2501
Update
b0c451f 
[ghstack-poisoned]
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Jan 14, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/172400

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit b0c451f with merge base 8cfe6f1 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

kwen2501 added a commit that referenced this pull request Jan 14, 2026
@kwen2501
[SymmMem] Use initializer for devComm requirement
ef94b6f 
ghstack-source-id: 57784f1
Pull-Request: #172400
@kwen2501 kwen2501 mentioned this pull request Jan 14, 2026
Open
@kwen2501 kwen2501 requested a review from Skylion007 January 14, 2026 00:43
@kwen2501 kwen2501 added the module: symm_mem Issues and PRs of Symmetric Memory label Jan 14, 2026
@fduwjj
Copy link
Copy Markdown
Contributor

fduwjj commented Jan 14, 2026

thank you thank you and looks like there are CI failure?

@kwen2501
Copy link
Copy Markdown
Collaborator Author

kwen2501 commented Jan 14, 2026

CI is a docker pull issue:

+ docker pull 308535385114.dkr.ecr.us-east-1.amazonaws.com/pytorch/ci-image:pytorch-linux-jammy-cuda12.8-cudnn9-py3-gcc11-bfafaf0e518ed45e732eaef14740ce84d523e20a
permission denied while trying to connect to the docker API at unix:///var/run/docker.sock

@kwen2501
Copy link
Copy Markdown
Collaborator Author

kwen2501 commented Jan 14, 2026

@pytorchbot merge -f "CI failure is caused by docker permission denial tracked in #172427"

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Jan 14, 2026

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

mattteochen pushed a commit to mattteochen/pytorch that referenced this pull request Jan 15, 2026
@kwen2501 @mattteochen
[SymmMem] Use initializer for devComm requirement (pytorch#172400)
ef24f99 
Fixes pytorch#172398

`NCCL_DEV_COMM_REQUIREMENTS_INITIALIZER` available in NCCL 2.29.
Pull Request resolved: pytorch#172400
Approved by: https://github.com/dzmitry-huba, https://github.com/fduwjj
ghstack dependencies: pytorch#172163
gderossi pushed a commit to gderossi/pytorch that referenced this pull request Feb 10, 2026
@kwen2501 @nWEIdia
[SymmMem] Use initializer for devComm requirement (pytorch#172400)
fa6760c 
Fixes pytorch#172398

`NCCL_DEV_COMM_REQUIREMENTS_INITIALIZER` available in NCCL 2.29.
Pull Request resolved: pytorch#172400
Approved by: https://github.com/dzmitry-huba, https://github.com/fduwjj
ghstack dependencies: pytorch#172163
@github-actions github-actions bot deleted the gh/kwen2501/309/head branch February 14, 2026 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fduwjj fduwjj fduwjj approved these changes

@fegin fegin Awaiting requested review from fegin

@Skylion007 Skylion007 Awaiting requested review from Skylion007

+1 more reviewer

@dzmitry-huba dzmitry-huba dzmitry-huba approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/h100-symm-mem Merged module: symm_mem Issues and PRs of Symmetric Memory open source release notes: distributed (c10d) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kwen2501 @fduwjj @pytorchmergebot @dzmitry-huba @pytorchbot