Skip to content

[DTensor] Add support for torch.linalg operators#171935

Closed
wconstab wants to merge 19 commits intogh/wconstab/486/basefrom
gh/wconstab/486/head
Closed

[DTensor] Add support for torch.linalg operators#171935
wconstab wants to merge 19 commits intogh/wconstab/486/basefrom
gh/wconstab/486/head

Conversation

@wconstab
Copy link
Copy Markdown
Contributor

@wconstab wconstab commented Jan 7, 2026

Stack from ghstack (oldest at bottom):

Add DTensor support for 18 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Jan 7, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/171935

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 5d4aa43 with merge base 4b0f7fb (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

wconstab added a commit that referenced this pull request Jan 7, 2026
Claude

ghstack-source-id: d1e3d4e
Pull Request resolved: #171935
wconstab added a commit that referenced this pull request Jan 12, 2026
Claude

ghstack-source-id: 1a607de
Pull Request resolved: #171935
@wconstab wconstab added the release notes: distributed (dtensor) release notes category label Jan 12, 2026
wconstab added a commit that referenced this pull request Jan 12, 2026
Add DTensor support for 18 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

ghstack-source-id: 1279075
Pull Request resolved: #171935
Add DTensor support for 18 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

[ghstack-poisoned]
wconstab added a commit that referenced this pull request Jan 13, 2026
Add DTensor support for 18 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

ghstack-source-id: 1279075
Pull Request resolved: #171935
Add DTensor support for 18 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

[ghstack-poisoned]
wconstab added a commit that referenced this pull request Jan 13, 2026
Add DTensor support for 18 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

ghstack-source-id: 6724af6
Pull Request resolved: #171935
Add DTensor support for 18 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

[ghstack-poisoned]
wconstab added a commit that referenced this pull request Jan 13, 2026
Add DTensor support for 19 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

ghstack-source-id: 3e8683a
Pull Request resolved: #171935
Add DTensor support for 18 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

[ghstack-poisoned]
wconstab added a commit that referenced this pull request Jan 14, 2026
Add DTensor support for 20 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

ghstack-source-id: 464e83b
Pull Request resolved: #171935
Add DTensor support for 18 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

[ghstack-poisoned]
wconstab added a commit that referenced this pull request Jan 14, 2026
Add DTensor support for 20 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

ghstack-source-id: cf586a2
Pull Request resolved: #171935
Add DTensor support for 18 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

[ghstack-poisoned]
wconstab added a commit that referenced this pull request Jan 14, 2026
Add DTensor support for 20 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

ghstack-source-id: 34f161b
Pull Request resolved: #171935
Add DTensor support for 18 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

[ghstack-poisoned]
wconstab added a commit that referenced this pull request Jan 14, 2026
Add DTensor support for 20 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

ghstack-source-id: ff82add
Pull Request resolved: #171935
Add DTensor support for 18 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

[ghstack-poisoned]
wconstab added a commit that referenced this pull request Jan 15, 2026
Add DTensor support for 20 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

ghstack-source-id: 18e8e56
Pull Request resolved: #171935
Copy link
Copy Markdown
Contributor

@pianpwk pianpwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just from prompting claude, it's saying the existing rules are valid, but there's more rules for two/three_input_solve: https://gist.github.com/pianpwk/51d442ffb8e1e6d5a751dd07bafd30d5

Add DTensor support for 18 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

[ghstack-poisoned]
wconstab added a commit that referenced this pull request Jan 20, 2026
Add DTensor support for 20 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

ghstack-source-id: ef07fda
Pull Request resolved: #171935
Add DTensor support for 18 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

[ghstack-poisoned]
wconstab added a commit that referenced this pull request Jan 20, 2026
Add DTensor support for 20 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

ghstack-source-id: 101138c
Pull Request resolved: #171935
Add DTensor support for 18 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

[ghstack-poisoned]
wconstab added a commit that referenced this pull request Jan 22, 2026
Add DTensor support for 20 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

ghstack-source-id: 61c26b7
Pull Request resolved: #171935
Add DTensor support for 18 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

[ghstack-poisoned]
wconstab added a commit that referenced this pull request Jan 31, 2026
Add DTensor support for 20 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

ghstack-source-id: 54e6ad8
Pull Request resolved: #171935
Add DTensor support for 18 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

[ghstack-poisoned]
Add DTensor support for 18 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

[ghstack-poisoned]
Add DTensor support for 18 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

[ghstack-poisoned]
Add DTensor support for 18 torch.linalg operators including solve, decompositions (cholesky, qr, lu, svd), eigenvalue operations (eig, eigh,
eigvals), and determinants.

Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

Claude

[ghstack-poisoned]
wconstab added a commit that referenced this pull request Feb 3, 2026
Add DTensor support for 19 operators

- Adds helper functions to single_dim_strategy.py for batching rules and replicate-only rules.

- Includes: linalg.cholesky, cholesky_ex, eig, eigvals,
  householder_product, inv, inv_ex, ldl_factor, ldl_factor_ex, lu,
  lu_factor, lu_factor_ex, pinv, slogdet,
  tensorinv, logdet, lu, lu_solve, pinverse

Shardigng validator says 0 incorrect and 0 missing rules

Claude

ghstack-source-id: 153a8e5
Pull Request resolved: #171935
@wconstab
Copy link
Copy Markdown
Contributor Author

wconstab commented Mar 6, 2026

closing as mostly covered by decomps. need to redo the PR to enable specific other ops that are still missing

@wconstab wconstab closed this Mar 6, 2026
@wconstab wconstab deleted the gh/wconstab/486/head branch March 6, 2026 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants