Skip to content

[vLLM] Remove xformers in vLLM build workflow#169914

Closed
huydhn wants to merge 1 commit intopytorch:mainfrom
huydhn:clean-up-vllm-xformers-build
Closed

[vLLM] Remove xformers in vLLM build workflow#169914
huydhn wants to merge 1 commit intopytorch:mainfrom
huydhn:clean-up-vllm-xformers-build

Conversation

@huydhn
Copy link
Copy Markdown
Contributor

@huydhn huydhn commented Dec 9, 2025

This is not needed anymore after vllm-project/vllm#29262. So, we only need to build vLLM wheel on PyTorch CI now.

  1. [Core] Deprecate xformers vllm-project/vllm#29262 has removed xformers from vLLM, and this PR applies that change to our end
  2. This vLLM nightly wheel will be used to power nightly benchmark runs on PyTorch CI. It's good that we just need to rebuild vLLM now and none of its dependencies
  3. I'm trying to get rid of the Dockerfile on PyTorch eventually, and just use the official one from vLLM instead. This is a work in progress

Signed-off-by: Huy Do <huydhn@gmail.com>
@huydhn huydhn requested review from zhxchen17 and zou3519 December 9, 2025 02:10
@huydhn huydhn requested a review from a team as a code owner December 9, 2025 02:10
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Dec 9, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/169914

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 00fd789 with merge base e701379 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: releng release notes category label Dec 9, 2025
@huydhn
Copy link
Copy Markdown
Contributor Author

huydhn commented Dec 9, 2025

@pytorchbot merge -f 'vLLM tests are passing, there is an existing broken trunk failure'

@pytorchmergebot
Copy link
Copy Markdown
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

liangxs pushed a commit to liangxs/pytorch that referenced this pull request Dec 9, 2025
This is not needed anymore after vllm-project/vllm#29262.  So, we only need to build vLLM wheel on PyTorch CI now.

1. vllm-project/vllm#29262 has removed xformers from vLLM, and this PR applies that change to our end
2. This vLLM nightly wheel will be used to power nightly benchmark runs on PyTorch CI.  It's good that we just need to rebuild vLLM now and none of its dependencies
3. I'm trying to get rid of the Dockerfile on PyTorch eventually, and just use the official one from vLLM instead.  This is a work in progress

Pull Request resolved: pytorch#169914
Approved by: https://github.com/zou3519
skpark-rh pushed a commit to skpark-rh/pytorch that referenced this pull request Dec 10, 2025
This is not needed anymore after vllm-project/vllm#29262.  So, we only need to build vLLM wheel on PyTorch CI now.

1. vllm-project/vllm#29262 has removed xformers from vLLM, and this PR applies that change to our end
2. This vLLM nightly wheel will be used to power nightly benchmark runs on PyTorch CI.  It's good that we just need to rebuild vLLM now and none of its dependencies
3. I'm trying to get rid of the Dockerfile on PyTorch eventually, and just use the official one from vLLM instead.  This is a work in progress

Pull Request resolved: pytorch#169914
Approved by: https://github.com/zou3519
@huydhn huydhn deleted the clean-up-vllm-xformers-build branch February 18, 2026 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants