Add element_size, storage_offset and set_requires_grad to stable Tensor by mikaylagawarecki · Pull Request #169703 · pytorch/pytorch

mikaylagawarecki · 2025-12-05T19:40:24Z

Stack from ghstack (oldest at bottom):

[ghstack-poisoned]

pytorch-bot · 2025-12-05T19:40:28Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/169703

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit a0a2ea1 with merge base 5d1459a ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ghstack-source-id: 006b37f Pull Request resolved: #169703

github-actions · 2025-12-05T19:44:47Z

Attention! PyTorch one of the C-stable API file was changed

You MUST NOT change existing function declarations in this, as this header defines a stable C ABI. If you need to change the signature for a function, introduce a new v2 version of the function and modify code generation to target the new version of the function.

Caused by:

torch/csrc/stable/c/shim.h

…stable Tensor" [ghstack-poisoned]

albanD

SGTM

torch/csrc/stable/tensor_struct.h

…stable Tensor" [ghstack-poisoned]

pytorchmergebot · 2025-12-08T17:09:09Z

Starting merge as part of PR stack under #169711

…stable Tensor" [ghstack-poisoned]

pytorchmergebot · 2025-12-08T18:06:36Z

Starting merge as part of PR stack under #169711

pytorchmergebot · 2025-12-08T21:24:42Z

Starting merge as part of PR stack under #169711

contiguous is also a method on the non-stable Tensor, but we don't add it to stable::Tensor (yet) Pull Request resolved: #169709 Approved by: https://github.com/albanD ghstack dependencies: #169703

… version (#169711) Pull Request resolved: #169711 Approved by: https://github.com/albanD ghstack dependencies: #169703, #169709

…or (#169703) Pull Request resolved: #169703 Approved by: https://github.com/albanD

contiguous is also a method on the non-stable Tensor, but we don't add it to stable::Tensor (yet) Pull Request resolved: #169709 Approved by: https://github.com/albanD ghstack dependencies: #169703

… version (#169711) Pull Request resolved: #169711 Approved by: https://github.com/albanD ghstack dependencies: #169703, #169709

Pull Request resolved: #168062 Approved by: https://github.com/albanD ghstack dependencies: #169703, #169709, #169711

…ch_call_dispatcher) (#169872) Scalar's StableIValue conversion is not supported yet. If we don't land this we can recommend `fill_(empty(...))` instead Pull Request resolved: #169872 Approved by: https://github.com/albanD ghstack dependencies: #169703, #169709, #169711, #168062

…or (pytorch#169703) Pull Request resolved: pytorch#169703 Approved by: https://github.com/albanD

contiguous is also a method on the non-stable Tensor, but we don't add it to stable::Tensor (yet) Pull Request resolved: pytorch#169709 Approved by: https://github.com/albanD ghstack dependencies: pytorch#169703

… version (pytorch#169711) Pull Request resolved: pytorch#169711 Approved by: https://github.com/albanD ghstack dependencies: pytorch#169703, pytorch#169709

Pull Request resolved: pytorch#168062 Approved by: https://github.com/albanD ghstack dependencies: pytorch#169703, pytorch#169709, pytorch#169711

…ch_call_dispatcher) (pytorch#169872) Scalar's StableIValue conversion is not supported yet. If we don't land this we can recommend `fill_(empty(...))` instead Pull Request resolved: pytorch#169872 Approved by: https://github.com/albanD ghstack dependencies: pytorch#169703, pytorch#169709, pytorch#169711, pytorch#168062

From https://github.com/pytorch/audio/blob/main/src/libtorchaudio/stable/ops.h Technically it should have been ok not to port these but looking at these carefully I realized the subtract ported to audio ~would have undefined behavior :/~ is broken ``` inline Tensor subtract(const Tensor& self, const Tensor& other) { const auto num_args = 2; std::array<StableIValue, num_args> stack{ torch::stable::detail::from(self), torch::stable::detail::from(other)}; TORCH_ERROR_CODE_CHECK(torch_call_dispatcher( "aten::subtract", "Tensor", stack.data(), TORCH_ABI_VERSION)); return torch::stable::detail::to<torch::stable::Tensor>(stack[0]); } ``` as it missed `alpha` the signature for `subtract.Tensor` is `func: subtract.Tensor(Tensor self, Tensor other, *, Scalar alpha=1) -> Tensor`. ~This is also our bad as although out of bounds reads on the stableivalue stack would be caught by asan, without asan they are silent correctness issues (PR coming to fix).~ Use the old path to support this as we don't support stableivalue conversion for Scalar yet. Pull Request resolved: #169880 Approved by: https://github.com/albanD ghstack dependencies: #169703, #169709, #169711, #168062, #169872

ghstack-source-id: 3daf10c Pull Request resolved: pytorch/pytorch#169703

…or (pytorch#169703) Pull Request resolved: pytorch#169703 Approved by: https://github.com/albanD

contiguous is also a method on the non-stable Tensor, but we don't add it to stable::Tensor (yet) Pull Request resolved: pytorch#169709 Approved by: https://github.com/albanD ghstack dependencies: pytorch#169703

… version (pytorch#169711) Pull Request resolved: pytorch#169711 Approved by: https://github.com/albanD ghstack dependencies: pytorch#169703, pytorch#169709

Pull Request resolved: pytorch#168062 Approved by: https://github.com/albanD ghstack dependencies: pytorch#169703, pytorch#169709, pytorch#169711

…ch_call_dispatcher) (pytorch#169872) Scalar's StableIValue conversion is not supported yet. If we don't land this we can recommend `fill_(empty(...))` instead Pull Request resolved: pytorch#169872 Approved by: https://github.com/albanD ghstack dependencies: pytorch#169703, pytorch#169709, pytorch#169711, pytorch#168062

…ch#169880) From https://github.com/pytorch/audio/blob/main/src/libtorchaudio/stable/ops.h Technically it should have been ok not to port these but looking at these carefully I realized the subtract ported to audio ~would have undefined behavior :/~ is broken ``` inline Tensor subtract(const Tensor& self, const Tensor& other) { const auto num_args = 2; std::array<StableIValue, num_args> stack{ torch::stable::detail::from(self), torch::stable::detail::from(other)}; TORCH_ERROR_CODE_CHECK(torch_call_dispatcher( "aten::subtract", "Tensor", stack.data(), TORCH_ABI_VERSION)); return torch::stable::detail::to<torch::stable::Tensor>(stack[0]); } ``` as it missed `alpha` the signature for `subtract.Tensor` is `func: subtract.Tensor(Tensor self, Tensor other, *, Scalar alpha=1) -> Tensor`. ~This is also our bad as although out of bounds reads on the stableivalue stack would be caught by asan, without asan they are silent correctness issues (PR coming to fix).~ Use the old path to support this as we don't support stableivalue conversion for Scalar yet. Pull Request resolved: pytorch#169880 Approved by: https://github.com/albanD ghstack dependencies: pytorch#169703, pytorch#169709, pytorch#169711, pytorch#168062, pytorch#169872

Add element_size, storage_offset and set_requires_grad to stable Tensor

87544b5

[ghstack-poisoned]

mikaylagawarecki added a commit that referenced this pull request Dec 5, 2025

Add element_size, storage_offset and set_requires_grad to stable Tensor

a94973f

ghstack-source-id: 006b37f Pull Request resolved: #169703

mikaylagawarecki added the ciflow/trunk Trigger trunk jobs on your pull request label Dec 5, 2025

mikaylagawarecki added release notes: cpp release notes category topic: new features topic category labels Dec 5, 2025

Update on "Add element_size, storage_offset and set_requires_grad to …

0373771

…stable Tensor" [ghstack-poisoned]

mikaylagawarecki mentioned this pull request Dec 5, 2025

Add to and contiguous to stable ops #169709

Closed

mikaylagawarecki marked this pull request as ready for review December 5, 2025 20:30

mikaylagawarecki requested a review from janeyx99 as a code owner December 5, 2025 20:30

mikaylagawarecki requested a review from albanD December 5, 2025 20:30

albanD approved these changes Dec 5, 2025

View reviewed changes

mikaylagawarecki commented Dec 5, 2025

View reviewed changes

torch/csrc/stable/tensor_struct.h Outdated Show resolved Hide resolved

mikaylagawarecki mentioned this pull request Dec 5, 2025

Upgrade stable new_{empty/zeros} that had only dtype argument to full version #169711

Closed

Update on "Add element_size, storage_offset and set_requires_grad to …

8e9bcf8

…stable Tensor" [ghstack-poisoned]

Update on "Add element_size, storage_offset and set_requires_grad to …

a0a2ea1

…stable Tensor" [ghstack-poisoned]

This was referenced Nov 19, 2025

Add sum and sum_out to stable ops #168062

Closed

Add full to stable ops (supported via generate c shim rather than torch_call_dispatcher) #169872

Closed

mikaylagawarecki mentioned this pull request Dec 8, 2025

Add squeeze, unsqueeze, matmul, select, subtract to stable ops #169880

Closed

pytorchmergebot closed this in b6c54e4 Dec 8, 2025

pytorchmergebot pushed a commit that referenced this pull request Dec 8, 2025

Upgrade stable new_{empty/zeros} that had only dtype argument to full…

a717ab2

… version (#169711) Pull Request resolved: #169711 Approved by: https://github.com/albanD ghstack dependencies: #169703, #169709

pytorchmergebot added the Merged label Dec 8, 2025

JacobSzwejbka pushed a commit that referenced this pull request Dec 8, 2025

Add element_size, storage_offset and set_requires_grad to stable Tens…

30f9928

…or (#169703) Pull Request resolved: #169703 Approved by: https://github.com/albanD

JacobSzwejbka pushed a commit that referenced this pull request Dec 8, 2025

Upgrade stable new_{empty/zeros} that had only dtype argument to full…

a188f1b

… version (#169711) Pull Request resolved: #169711 Approved by: https://github.com/albanD ghstack dependencies: #169703, #169709

pytorchmergebot pushed a commit that referenced this pull request Dec 8, 2025

Add sum and sum_out to stable ops (#168062)

78501a0

Pull Request resolved: #168062 Approved by: https://github.com/albanD ghstack dependencies: #169703, #169709, #169711

liangxs pushed a commit to liangxs/pytorch that referenced this pull request Dec 9, 2025

Add element_size, storage_offset and set_requires_grad to stable Tens…

4b6a35a

…or (pytorch#169703) Pull Request resolved: pytorch#169703 Approved by: https://github.com/albanD

liangxs pushed a commit to liangxs/pytorch that referenced this pull request Dec 9, 2025

Add sum and sum_out to stable ops (pytorch#168062)

4016658

Pull Request resolved: pytorch#168062 Approved by: https://github.com/albanD ghstack dependencies: pytorch#169703, pytorch#169709, pytorch#169711

tiendatngcs pushed a commit to tiendatngcs/pytorch-Dec25 that referenced this pull request Dec 9, 2025

Add element_size, storage_offset and set_requires_grad to stable Tensor

801aeff

ghstack-source-id: 3daf10c Pull Request resolved: pytorch/pytorch#169703

skpark-rh pushed a commit to skpark-rh/pytorch that referenced this pull request Dec 10, 2025

Add element_size, storage_offset and set_requires_grad to stable Tens…

e84f9cb

…or (pytorch#169703) Pull Request resolved: pytorch#169703 Approved by: https://github.com/albanD

github-actions bot deleted the gh/mikaylagawarecki/395/head branch January 8, 2026 02:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add element_size, storage_offset and set_requires_grad to stable Tensor#169703

Add element_size, storage_offset and set_requires_grad to stable Tensor#169703
mikaylagawarecki wants to merge 4 commits intogh/mikaylagawarecki/395/basefrom
gh/mikaylagawarecki/395/head

mikaylagawarecki commented Dec 5, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Dec 5, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 5, 2025

Uh oh!

albanD left a comment

Uh oh!

Uh oh!

pytorchmergebot commented Dec 8, 2025

Uh oh!

pytorchmergebot commented Dec 8, 2025

Uh oh!

pytorchmergebot commented Dec 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

mikaylagawarecki commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/169703

⏳ No Failures, 1 Pending

Uh oh!

github-actions bot commented Dec 5, 2025

Attention! PyTorch one of the C-stable API file was changed

Uh oh!

albanD left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pytorchmergebot commented Dec 8, 2025

Uh oh!

pytorchmergebot commented Dec 8, 2025

Uh oh!

pytorchmergebot commented Dec 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mikaylagawarecki commented Dec 5, 2025 •

edited

Loading

pytorch-bot bot commented Dec 5, 2025 •

edited

Loading