[coor-slicing] _select_split_tensor#169551
Closed
aorenste wants to merge 10 commits intogh/aorenste/158/basefrom
Closed
[coor-slicing] _select_split_tensor#169551aorenste wants to merge 10 commits intogh/aorenste/158/basefrom
aorenste wants to merge 10 commits intogh/aorenste/158/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/169551
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 127 PendingAs of commit 3307b34 with merge base dc48fef ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Dec 4, 2025
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
tiendatngcs
pushed a commit
to tiendatngcs/pytorch-Dec25
that referenced
this pull request
Dec 10, 2025
ghstack-source-id: 5a03dff Pull Request resolved: pytorch/pytorch#169551
[ghstack-poisoned]
`Placement._split_tensor()` computes and returns too much information - in general most callers call it and then throw away most of the results. Added `Placement._select_split_tensor()` which allows the caller to say which parts they want so we can compute only those bits - in essence it is the combination of `Placement._split_tensor()` and `Shard._select_shard()`. [ghstack-poisoned]
ezyang
approved these changes
Jan 8, 2026
`Placement._split_tensor()` computes and returns too much information - in general most callers call it and then throw away most of the results. Added `Placement._select_split_tensor()` which allows the caller to say which parts they want so we can compute only those bits - in essence it is the combination of `Placement._split_tensor()` and `Shard._select_shard()`. [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
`Placement._split_tensor()` computes and returns too much information - in general most callers call it and then throw away most of the results. Added `Placement._select_split_tensor()` which allows the caller to say which parts they want so we can compute only those bits - in essence it is the combination of `Placement._split_tensor()` and `Shard._select_shard()`. [ghstack-poisoned]
`Placement._split_tensor()` computes and returns too much information - in general most callers call it and then throw away most of the results. Added `Placement._select_split_tensor()` which allows the caller to say which parts they want so we can compute only those bits - in essence it is the combination of `Placement._split_tensor()` and `Shard._select_shard()`. [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Contributor
|
@pytorchbot revert -m "seems to be breaking internal signals, see D90448078" -c ghfirst |
Collaborator
|
@pytorchbot successfully started a revert job. Check the current status here. |
pytorchmergebot
added a commit
that referenced
this pull request
Jan 12, 2026
This reverts commit c6583cb. Reverted #169551 on behalf of https://github.com/jeanschmidt due to seems to be breaking internal signals, see D90448078 ([comment](#169551 (comment)))
Collaborator
|
@aorenste your PR has been successfully reverted. |
Contributor
|
@pytorchbot merge -f "should not have reverted" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
hinriksnaer
pushed a commit
to hinriksnaer/pytorch
that referenced
this pull request
Jan 12, 2026
`Placement._split_tensor()` computes and returns too much information - in general most callers call it and then throw away most of the results. Added `Placement._select_split_tensor()` which allows the caller to say which parts they want so we can compute only those bits - in essence it is the combination of `Placement._split_tensor()` and `Shard._select_shard()`. Pull Request resolved: pytorch#169551 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#169549, pytorch#169550
hinriksnaer
pushed a commit
to hinriksnaer/pytorch
that referenced
this pull request
Jan 12, 2026
This reverts commit c6583cb. Reverted pytorch#169551 on behalf of https://github.com/jeanschmidt due to seems to be breaking internal signals, see D90448078 ([comment](pytorch#169551 (comment)))
hinriksnaer
pushed a commit
to hinriksnaer/pytorch
that referenced
this pull request
Jan 12, 2026
`Placement._split_tensor()` computes and returns too much information - in general most callers call it and then throw away most of the results. Added `Placement._select_split_tensor()` which allows the caller to say which parts they want so we can compute only those bits - in essence it is the combination of `Placement._split_tensor()` and `Shard._select_shard()`. Pull Request resolved: pytorch#169551 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#169549, pytorch#169550
skpark-rh
pushed a commit
to skpark-rh/pytorch
that referenced
this pull request
Jan 12, 2026
`Placement._split_tensor()` computes and returns too much information - in general most callers call it and then throw away most of the results. Added `Placement._select_split_tensor()` which allows the caller to say which parts they want so we can compute only those bits - in essence it is the combination of `Placement._split_tensor()` and `Shard._select_shard()`. Pull Request resolved: pytorch#169551 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#169549, pytorch#169550
skpark-rh
pushed a commit
to skpark-rh/pytorch
that referenced
this pull request
Jan 12, 2026
This reverts commit c6583cb. Reverted pytorch#169551 on behalf of https://github.com/jeanschmidt due to seems to be breaking internal signals, see D90448078 ([comment](pytorch#169551 (comment)))
skpark-rh
pushed a commit
to skpark-rh/pytorch
that referenced
this pull request
Jan 12, 2026
`Placement._split_tensor()` computes and returns too much information - in general most callers call it and then throw away most of the results. Added `Placement._select_split_tensor()` which allows the caller to say which parts they want so we can compute only those bits - in essence it is the combination of `Placement._split_tensor()` and `Shard._select_shard()`. Pull Request resolved: pytorch#169551 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#169549, pytorch#169550
SergeyTyshkevich
pushed a commit
to SergeyTyshkevich/chart2
that referenced
this pull request
Jan 19, 2026
ghstack-source-id: b1a095b Pull Request resolved: pytorch/pytorch#169551
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Placement._split_tensor()computes and returns too much information - in general most callers call it and then throw away most of the results. AddedPlacement._select_split_tensor()which allows the caller to say which parts they want so we can compute only those bits - in essence it is the combination ofPlacement._split_tensor()andShard._select_shard().Stack from ghstack (oldest at bottom):