Namedtuple return for symeig, eig, pstrf, qr, geqrf#16950
Namedtuple return for symeig, eig, pstrf, qr, geqrf#16950zasdfgbnm wants to merge 15 commits intopytorch:masterfrom
Conversation
|
Should be working now |
| variants: method, function | ||
|
|
||
| - func: pstrf(Tensor self, bool upper=True, Scalar tol=-1, *, Tensor(a!) u, Tensor(b!) piv) ->(Tensor(a!), Tensor(b!)) | ||
| - func: pstrf(Tensor self, bool upper=True, Scalar tol=-1, *, Tensor(a!) u, Tensor(b!) piv) ->(Tensor(a!) u, Tensor(b!) piv) |
There was a problem hiding this comment.
@vishwakftw I remember you were interested in cholesky decompositions, what do you think about these names?
Personally I have no clue what these names are but I also don't know anything on the subject
There was a problem hiding this comment.
In this case, u seems right, because pstrf is meant to return upper triangular matrices.
|
@zasdfgbnm what's your opinion on name conflicts between input and output arguments? An alternate resolution is to say that, the output name always has to be distinct from input names (and then we have to pick a name like |
|
This PR looks functionally correct but I want to discuss the matter of |
|
@ezyang I am OK with short names in general, like I don't thin there is a common way to abbreviate eigenvalues and eigenvectors, below are a list of abbreviations in different materials (these are all top ranking result in Google when searching
|
|
SGTM. @soumith suggests we use |
|
@ezyang Just renamed piv -> pivot |
…dtuple-return-qr
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Summary: More ops for #394 Differential Revision: D14118645 Pulled By: ezyang fbshipit-source-id: a98646c3ddcbe4e34452aa044951286dcf9df778
|
landed |
More ops for #394
cc: @ezyang