[effect] Remove special handling for profiler op#168389
[effect] Remove special handling for profiler op#168389angelayi wants to merge 7 commits intogh/angelayi/144/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/168389
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New Failures, 15 PendingAs of commit ee83769 with merge base e3f24fd ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@angelayi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Differential Revision: [D87680134](https://our.internmc.facebook.com/intern/diff/D87680134) [ghstack-poisoned]
Differential Revision: [D87680134](https://our.internmc.facebook.com/intern/diff/D87680134) [ghstack-poisoned]
Differential Revision: [D87680134](https://our.internmc.facebook.com/intern/diff/D87680134) [ghstack-poisoned]
Differential Revision: [D87680134](https://our.internmc.facebook.com/intern/diff/D87680134) [ghstack-poisoned]
Differential Revision: [D87680134](https://our.internmc.facebook.com/intern/diff/D87680134) [ghstack-poisoned]
Differential Revision: [D87680134](https://our.internmc.facebook.com/intern/diff/D87680134) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo [ghstack-poisoned]
|
@angelayi has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m 'Sorry for reverting your change but it seems to fail test_python_dispatch' -c nosignal test/test_python_dispatch.py::TestPythonRegistration::test_alias_analysis GH job link HUD commit link |
|
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit 296e67c. Reverted #168389 on behalf of https://github.com/huydhn due to Sorry for reverting your change but it seems to fail test_python_dispatch ([comment](#168389 (comment)))
|
@angelayi your PR has been successfully reverted. |
|
@pytorchbot merge -f 'Reverting does not fix the failure, so let us reland the PR' |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
We shouldn't need this anymore as we have a registration for the op to have no effect Differential Revision: [D87680134](https://our.internmc.facebook.com/intern/diff/D87680134) Pull Request resolved: #168389 Approved by: https://github.com/zou3519 ghstack dependencies: #167364
This reverts commit 296e67c. Reverted #168389 on behalf of https://github.com/huydhn due to Sorry for reverting your change but it seems to fail test_python_dispatch ([comment](#168389 (comment)))
We shouldn't need this anymore as we have a registration for the op to have no effect Differential Revision: [D87680134](https://our.internmc.facebook.com/intern/diff/D87680134) Pull Request resolved: #168389 Approved by: https://github.com/zou3519 ghstack dependencies: #167364
We shouldn't need this anymore as we have a registration for the op to have no effect
Stack from ghstack (oldest at bottom):
Differential Revision: D87680134
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @jataylo