Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/168297
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d51fc02 with merge base ba68238 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
malfet
left a comment
There was a problem hiding this comment.
SGTM, but it was landed waaay back
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "this seems breaks the trunk ##[error]Process completed with exit code 2." -c nosignal |
|
i revert this since the trunk breaks from this pr, let's see if this works, if not, please remerge this |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@ngimel your PR has been successfully reverted. |
This reverts commit 6707dc8. Reverted #168297 on behalf of https://github.com/yangw-dev due to this seems breaks the trunk ##[error]Process completed with exit code 2. ([comment](#168297 (comment)))
|
@pytorchbot merge -f |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot merge -f "erroneous revert" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This reverts commit 6707dc8. Reverted #168297 on behalf of https://github.com/yangw-dev due to this seems breaks the trunk ##[error]Process completed with exit code 2. ([comment](#168297 (comment)))
We suspect it's causing intermittent segfaults