Skip to content

Triton 3.6 pin update#168096

Closed
atalman wants to merge 5 commits intopytorch:mainfrom
atalman:triton_36_pin
Closed

Triton 3.6 pin update#168096
atalman wants to merge 5 commits intopytorch:mainfrom
atalman:triton_36_pin

Conversation

@atalman
Copy link
Contributor

@atalman atalman commented Nov 18, 2025 •
edited by pytorch-bot bot
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 18, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/168096

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures, 132 Pending

As of commit 29287be with merge base a2b5dfb (image):

NEW FAILURES - The following jobs have failed:

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Nov 18, 2025
@atalman atalman added ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR keep-going Don't stop on first failure, keep running tests until the end ciflow/inductor-perf-test-nightly Trigger nightly inductor perf tests ciflow/inductor-perf-compare ci-no-td Do not run TD on this PR ciflow/inductor-micro-benchmark ciflow/inductor-periodic ciflow/inductor-cu126 ciflow/inductor-micro-benchmark-cpu-x86 ciflow/h100 ciflow/inductor-windows Trigger inductor test on Windows ciflow/b200 ciflow/dynamo Trigger jobs ran periodically on main for dynamo tests and removed topic: not user facing topic category labels Nov 18, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 18, 2025

Warning: Unknown label ciflow/inductor-perf-test-nightly.
Currently recognized labels are

  • ciflow/b200
  • ciflow/b200-distributed
  • ciflow/b200-symm-mem
  • ciflow/binaries
  • ciflow/binaries_libtorch
  • ciflow/binaries_wheel
  • ciflow/dynamo
  • ciflow/h100
  • ciflow/h100-cutlass-backend
  • ciflow/h100-distributed
  • ciflow/h100-symm-mem
  • ciflow/inductor
  • ciflow/inductor-cu126
  • ciflow/inductor-micro-benchmark
  • ciflow/inductor-micro-benchmark-cpu-x86
  • ciflow/inductor-perf-compare
  • ciflow/inductor-perf-test-nightly-rocm-mi300
  • ciflow/inductor-perf-test-nightly-rocm-mi355
  • ciflow/inductor-perf-test-nightly-x86-zen
  • ciflow/inductor-perf-test-nightly-xpu
  • ciflow/inductor-periodic
  • ciflow/inductor-rocm
  • ciflow/inductor-rocm-mi200
  • ciflow/inductor-rocm-mi300
  • ciflow/linux-aarch64
  • ciflow/mps
  • ciflow/nightly
  • ciflow/op-benchmark
  • ciflow/periodic
  • ciflow/periodic-rocm-mi200
  • ciflow/periodic-rocm-mi300
  • ciflow/pull
  • ciflow/quantization-periodic
  • ciflow/riscv64
  • ciflow/rocm
  • ciflow/rocm-mi200
  • ciflow/rocm-mi300
  • ciflow/rocm-mi355
  • ciflow/rocm-navi31
  • ciflow/s390
  • ciflow/slow
  • ciflow/slow-rocm-mi200
  • ciflow/torchbench
  • ciflow/triton_binaries
  • ciflow/trunk
  • ciflow/unstable
  • ciflow/vllm
  • ciflow/win-arm64
  • ciflow/xpu

Please add the new label to .github/pytorch-probot.yml

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 18, 2025

Warning: Unknown label ciflow/inductor-windows.
Currently recognized labels are

  • ciflow/b200
  • ciflow/b200-distributed
  • ciflow/b200-symm-mem
  • ciflow/binaries
  • ciflow/binaries_libtorch
  • ciflow/binaries_wheel
  • ciflow/dynamo
  • ciflow/h100
  • ciflow/h100-cutlass-backend
  • ciflow/h100-distributed
  • ciflow/h100-symm-mem
  • ciflow/inductor
  • ciflow/inductor-cu126
  • ciflow/inductor-micro-benchmark
  • ciflow/inductor-micro-benchmark-cpu-x86
  • ciflow/inductor-perf-compare
  • ciflow/inductor-perf-test-nightly-rocm-mi300
  • ciflow/inductor-perf-test-nightly-rocm-mi355
  • ciflow/inductor-perf-test-nightly-x86-zen
  • ciflow/inductor-perf-test-nightly-xpu
  • ciflow/inductor-periodic
  • ciflow/inductor-rocm
  • ciflow/inductor-rocm-mi200
  • ciflow/inductor-rocm-mi300
  • ciflow/linux-aarch64
  • ciflow/mps
  • ciflow/nightly
  • ciflow/op-benchmark
  • ciflow/periodic
  • ciflow/periodic-rocm-mi200
  • ciflow/periodic-rocm-mi300
  • ciflow/pull
  • ciflow/quantization-periodic
  • ciflow/riscv64
  • ciflow/rocm
  • ciflow/rocm-mi200
  • ciflow/rocm-mi300
  • ciflow/rocm-mi355
  • ciflow/rocm-navi31
  • ciflow/s390
  • ciflow/slow
  • ciflow/slow-rocm-mi200
  • ciflow/torchbench
  • ciflow/triton_binaries
  • ciflow/trunk
  • ciflow/unstable
  • ciflow/vllm
  • ciflow/win-arm64
  • ciflow/xpu

Please add the new label to .github/pytorch-probot.yml

@atalman
Copy link
Contributor Author

atalman commented Nov 19, 2025

git rebase -b main

@atalman
Copy link
Contributor Author

atalman commented Nov 19, 2025

@pytorchmergebot rebase -v main

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 19, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: -v main

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick} ...

Try @pytorchbot --help for more info.

@atalman
Copy link
Contributor Author

atalman commented Nov 19, 2025

@pytorchmergebot rebase -b main

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 19, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 19, 2025

Successfully rebased triton_36_pin onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout triton_36_pin && git pull --rebase)

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 19, 2025
@atalman atalman mentioned this pull request Nov 20, 2025
Closed
@atalman
Copy link
Contributor Author

atalman commented Nov 24, 2025

@pytorchmergebot rebase -b main

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 3, 2025

@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 3, 2025

Successfully rebased triton_36_pin onto refs/remotes/origin/main, please pull locally before adding more changes (for example, via git checkout triton_36_pin && git pull --rebase)

@pytorch-auto-revert pytorch-auto-revert bot mentioned this pull request Dec 4, 2025
Open
@huydhn
Copy link
Contributor

huydhn commented Dec 4, 2025

Reverting this change somehow breaks a bunch of trunk 3.14 signals https://hud.pytorch.org/hud/pytorch/pytorch/main/1?per_page=50&name_filter=. Let's reland this asap I think

@huydhn
Copy link
Contributor

huydhn commented Dec 4, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 4, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 4, 2025

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@atalman
Copy link
Contributor Author

atalman commented Dec 4, 2025

@pytorchmergebot merge -f "lint is green, everything else was already tested"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Dec 4, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@desertfire
Copy link
Contributor

desertfire commented Dec 4, 2025

Seems like the trunk is still red after this revert-revert?

umechand-amd pushed a commit to ROCm/pytorch that referenced this pull request Dec 8, 2025
@atalman
Triton 3.6 pin update (pytorch#168096)
3c6a951 
Required for release 2.10

Rocm wheel build fix provided by: pytorch#169369

Pull Request resolved: pytorch#168096
Approved by: https://github.com/njriasan, https://github.com/malfet, https://github.com/huydhn
JacobSzwejbka pushed a commit that referenced this pull request Dec 8, 2025
@atalman @JacobSzwejbka
Triton 3.6 pin update (#168096)
d348a21 
Required for release 2.10

Rocm wheel build fix provided by: #169369

Pull Request resolved: #168096
Approved by: https://github.com/njriasan, https://github.com/malfet
JacobSzwejbka pushed a commit that referenced this pull request Dec 8, 2025
@pytorchmergebot @JacobSzwejbka
Revert "Triton 3.6 pin update (#168096)"
77b56f6 
This reverts commit 93d0d68.

Reverted #168096 on behalf of https://github.com/atalman due to Causes timeouts #169492 ([comment](#168096 (comment)))
JacobSzwejbka pushed a commit that referenced this pull request Dec 8, 2025
@atalman @JacobSzwejbka
Triton 3.6 pin update (#168096)
dff9966 
Required for release 2.10

Rocm wheel build fix provided by: #169369

Pull Request resolved: #168096
Approved by: https://github.com/njriasan, https://github.com/malfet, https://github.com/huydhn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@malfet malfet malfet approved these changes

@njriasan njriasan njriasan approved these changes

@desertfire desertfire Awaiting requested review from desertfire desertfire is a code owner

@Chillee Chillee Awaiting requested review from Chillee Chillee is a code owner

@eellison eellison Awaiting requested review from eellison eellison is a code owner

@shunting314 shunting314 Awaiting requested review from shunting314 shunting314 is a code owner

@jataylo jataylo Awaiting requested review from jataylo jataylo is a code owner

@jithunnair-amd jithunnair-amd Awaiting requested review from jithunnair-amd jithunnair-amd is a code owner

@pruthvistony pruthvistony Awaiting requested review from pruthvistony pruthvistony is a code owner

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/b200 ciflow/dynamo Trigger jobs ran periodically on main for dynamo tests ciflow/h100 ciflow/inductor ciflow/inductor-cu126 ciflow/inductor-micro-benchmark ciflow/inductor-micro-benchmark-cpu-x86 ciflow/inductor-perf-compare ciflow/inductor-perf-test-nightly Trigger nightly inductor perf tests ciflow/inductor-perf-test-nightly-rocm-mi300 Trigger inductor perf tests on ROCm MI300 ciflow/inductor-periodic ciflow/inductor-rocm-mi200 Trigger "inductor" config CI on ROCm MI200 ciflow/inductor-rocm-mi300 Trigger "inductor" config CI on ROCm MI300/MI325 ciflow/inductor-windows Trigger inductor test on Windows ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR ciflow/rocm-mi200 Trigger "default" config CI on ROCm MI200 ciflow/rocm-mi300 Trigger "default" config CI on ROCm MI300 ciflow/trunk Trigger trunk jobs on your pull request keep-going Don't stop on first failure, keep running tests until the end Merged module: dynamo module: inductor Reverted topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@atalman @pytorchmergebot @huydhn @desertfire @malfet @njriasan @jataylo