Skip to content

[pytree][compile] Slightly faster TreeSpec init#168024

Closed
anijain2305 wants to merge 2 commits intogh/anijain2305/954/basefrom
gh/anijain2305/954/head
Closed

[pytree][compile] Slightly faster TreeSpec init#168024
anijain2305 wants to merge 2 commits intogh/anijain2305/954/basefrom
gh/anijain2305/954/head

Conversation

@anijain2305
Copy link
Contributor

@anijain2305 anijain2305 commented Nov 17, 2025

Stack from ghstack (oldest at bottom):

Helps with reducing Dynamo tracing time. Earlier the generator object
would cause more polyfills.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela

Helps with reducing Dynamo tracing time. Earlier the generator object
would cause more polyfills.

[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Nov 17, 2025
Helps with reducing Dynamo tracing time. Earlier the generator object
would cause more polyfills.

ghstack-source-id: 21c4c7f
Pull Request resolved: #168024
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/168024

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 972bfeb with merge base 7a92839 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@anijain2305 anijain2305 added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Nov 17, 2025
@anijain2305
Copy link
Contributor Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 3 checks: inductor / unit-test / inductor-halide-test / test (inductor-halide, 1, 1, linux.12xlarge), inductor / inductor-test / test (inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu), trunk / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, linux.2xlarge, unstable)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@yangw-dev
Copy link
Contributor

@pytorchbot -m "Internal merge fail, These changes have conflicts when merging with master branch. Rebase this diff. please rebase the pr and try merge again" -c ghfirst

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 19, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: argument command: invalid choice: 'Internal merge fail, These changes have conflicts when merging with master branch. Rebase this diff. please rebase the pr and try merge again' (choose from 'merge', 'revert', 'rebase', 'label', 'drci', 'cherry-pick')

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick} ...

Try @pytorchbot --help for more info.

@yangw-dev
Copy link
Contributor

@pytorchbot revert -m "Internal merge fail, These changes have conflicts when merging with master branch. Rebase this diff. please rebase the pr and try merge again" -c ghfirst

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

@anijain2305 your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Nov 19, 2025
This reverts commit db1551b.

Reverted #168024 on behalf of https://github.com/yangw-dev due to Internal merge fail, These changes have conflicts when merging with master branch. Rebase this diff. please rebase the pr and try merge again ([comment](#168024 (comment)))
@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Nov 19, 2025
Helps with reducing Dynamo tracing time. Earlier the generator object
would cause more polyfills.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Nov 19, 2025
Helps with reducing Dynamo tracing time. Earlier the generator object
would cause more polyfills.

ghstack-source-id: d4f87f1
Pull Request resolved: #168024
@anijain2305
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@github-actions github-actions bot deleted the gh/anijain2305/954/head branch December 20, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td Do not run TD on this PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo Reverted topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants