Skip to content

[FlexFlash] Specify lowering w/ new BACKEND kernel option#168017

Closed
drisspg wants to merge 12 commits intogh/drisspg/221/basefrom
gh/drisspg/221/head
Closed

[FlexFlash] Specify lowering w/ new BACKEND kernel option#168017
drisspg wants to merge 12 commits intogh/drisspg/221/basefrom
gh/drisspg/221/head

Conversation

@drisspg
Copy link
Contributor

@drisspg drisspg commented Nov 17, 2025

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/168017

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (2 Unrelated Failures)

As of commit f17a038 with merge base 39ebab1 (image):

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
Khanaksahu pushed a commit to Khanaksahu/pytorch-fork that referenced this pull request Nov 17, 2025
[ghstack-poisoned]
@drisspg drisspg added the suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) label Nov 18, 2025
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
@drisspg drisspg changed the title [FlexFlash]Change option name before gets public [FlexFlash] Specify lowering w/ new BACKEND kernel option Nov 19, 2025
@drisspg
Copy link
Contributor Author

drisspg commented Nov 19, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 19, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

mask_graph: Subgraph,
kernel_options: dict[str, Any],
num_score_mod_placeholders: int,
force_impl: Literal["AUTO", "TRITON", "FLASH", "TRITON_DECODE"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May also want to use the private _Backend literal here imported from the other file is what I meant with mh last comment. force_impl: _BACKEND

Copy link
Contributor Author

@drisspg drisspg Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, ill let this land and do it in the top commit

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-jammy-cuda12.8-py3.10-gcc11 / test (default, 1, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

[ghstack-poisoned]
@drisspg
Copy link
Contributor Author

drisspg commented Nov 19, 2025

@pytorchbot merge -f "insanely long ci times"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Nov 20, 2025
drisspg added a commit that referenced this pull request Nov 20, 2025
tiendatngcs pushed a commit to tiendatngcs/pytorch-Dec25 that referenced this pull request Dec 10, 2025
@github-actions github-actions bot deleted the gh/drisspg/221/head branch December 20, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: flex attention module: inductor suppress-bc-linter Suppresses the failures of API backward-compatibility linter (Lint/bc_linter) topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants