Skip to content

Fix stable ABI to/from deprecation warnings. Add my_shape test.#167923

Closed
pearu wants to merge 5 commits intogh/pearu/153/basefrom
gh/pearu/153/head
Closed

Fix stable ABI to/from deprecation warnings. Add my_shape test.#167923
pearu wants to merge 5 commits intogh/pearu/153/basefrom
gh/pearu/153/head

Conversation

@pearu
Copy link
Collaborator

@pearu pearu commented Nov 16, 2025 •
edited
Loading

@pearu
Update
2d62cd7 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 16, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167923

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit da8b89c with merge base dc4f3c7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 16, 2025
pearu added a commit that referenced this pull request Nov 16, 2025
@pearu
Fix stable ABI to/from deprecation warnings. Add my_shape test.
dff6caa 
ghstack-source-id: 507f2bf
Pull Request resolved: #167923
@pearu pearu added open source better-engineering Relatively self-contained tasks for better engineering contributors ciflow/inductor-windows Trigger inductor test on Windows labels Nov 16, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 16, 2025

Warning: Unknown label ciflow/inductor-windows.
Currently recognized labels are

  • ciflow/b200
  • ciflow/b200-distributed
  • ciflow/b200-symm-mem
  • ciflow/binaries
  • ciflow/binaries_libtorch
  • ciflow/binaries_wheel
  • ciflow/dynamo
  • ciflow/h100
  • ciflow/h100-cutlass-backend
  • ciflow/h100-distributed
  • ciflow/h100-symm-mem
  • ciflow/inductor
  • ciflow/inductor-cu126
  • ciflow/inductor-micro-benchmark
  • ciflow/inductor-micro-benchmark-cpu-x86
  • ciflow/inductor-perf-compare
  • ciflow/inductor-perf-test-nightly-rocm-mi300
  • ciflow/inductor-perf-test-nightly-rocm-mi355
  • ciflow/inductor-perf-test-nightly-x86-zen
  • ciflow/inductor-perf-test-nightly-xpu
  • ciflow/inductor-periodic
  • ciflow/inductor-rocm
  • ciflow/inductor-rocm-mi200
  • ciflow/inductor-rocm-mi300
  • ciflow/linux-aarch64
  • ciflow/mps
  • ciflow/nightly
  • ciflow/op-benchmark
  • ciflow/periodic
  • ciflow/periodic-rocm-mi200
  • ciflow/periodic-rocm-mi300
  • ciflow/pull
  • ciflow/quantization-periodic
  • ciflow/riscv64
  • ciflow/rocm
  • ciflow/rocm-mi200
  • ciflow/rocm-mi300
  • ciflow/rocm-mi355
  • ciflow/rocm-navi31
  • ciflow/s390
  • ciflow/slow
  • ciflow/slow-rocm-mi200
  • ciflow/torchbench
  • ciflow/triton_binaries
  • ciflow/trunk
  • ciflow/unstable
  • ciflow/vllm
  • ciflow/win-arm64
  • ciflow/xpu

Please add the new label to .github/pytorch-probot.yml

@pearu pearu added ciflow/trunk Trigger trunk jobs on your pull request ciflow/inductor and removed ciflow/inductor-windows Trigger inductor test on Windows labels Nov 16, 2025
@pearu
Update
0d13cc7 
[ghstack-poisoned]
pearu added a commit that referenced this pull request Nov 16, 2025
@pearu
Fix stable ABI to/from deprecation warnings. Add my_shape test.
b22f1d1 
ghstack-source-id: c879484
Pull Request resolved: #167923
@pearu pearu marked this pull request as draft November 17, 2025 07:44
@pearu
Update
add3dc9 
[ghstack-poisoned]
pearu added a commit that referenced this pull request Nov 17, 2025
@pearu
Fix stable ABI to/from deprecation warnings. Add my_shape test.
4715d1c 
ghstack-source-id: f4844fa
Pull Request resolved: #167923
@pearu pearu marked this pull request as ready for review November 17, 2025 18:23
@janeyx99
Copy link
Contributor

janeyx99 commented Nov 17, 2025

https://github.com/pytorch/pytorch/blob/main/test/cpp_extensions/libtorch_agnostic_extension/libtorch_agnostic/csrc/kernel.cpp#L56 should already trigger the same thing that my_shape would, yes?

@pearu
Copy link
Collaborator Author

pearu commented Nov 18, 2025

https://github.com/pytorch/pytorch/blob/main/test/cpp_extensions/libtorch_agnostic_extension/libtorch_agnostic/csrc/kernel.cpp#L56 should already trigger the same thing that my_shape would, yes?

No. While the statement

auto out = new_empty(param, param.sizes());

involves IntHeaderOnlyArrayRef object, the issue is about its conversion to StableIValue that the statement above does not trigger.

@pearu pearu mentioned this pull request Nov 18, 2025
Merged
@pearu
Update
c592f2b 
[ghstack-poisoned]
pearu added a commit that referenced this pull request Nov 18, 2025
@pearu
Fix stable ABI to/from deprecation warnings. Add my_shape test.
9733d42 
ghstack-source-id: 5157d6e
Pull Request resolved: #167923
janeyx99
janeyx99 approved these changes Nov 18, 2025
View reviewed changes
Copy link
Contributor

@janeyx99 janeyx99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhh int[]

@pearu
Copy link
Collaborator Author

pearu commented Nov 18, 2025

@pytorchbot merge

@pearu
Copy link
Collaborator Author

pearu commented Nov 18, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 18, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 18, 2025

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x 9733d42b7d7965d56398207f221e56a40663ee09 returned non-zero exit code 1

Auto-merging torch/csrc/stable/stableivalue_conversions.h
CONFLICT (content): Merge conflict in torch/csrc/stable/stableivalue_conversions.h
error: could not apply 9733d42b7d7... Fix stable ABI to/from deprecation warnings. Add my_shape test.
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Details for Dev Infra team Raised by workflow job

@pearu
Update
da8b89c 
[ghstack-poisoned]
pearu added a commit that referenced this pull request Nov 18, 2025
@pearu
Fix stable ABI to/from deprecation warnings. Add my_shape test.
3eaa354 
ghstack-source-id: 223ab3b
Pull Request resolved: #167923
@pearu
Copy link
Collaborator Author

pearu commented Nov 18, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Nov 18, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pearu pearu mentioned this pull request Nov 19, 2025
Closed
pytorchmergebot pushed a commit that referenced this pull request Nov 20, 2025
@pearu @pytorchmergebot
Revise stableivalue from/to deprecation (#168155)
7fff317 
An alternative approach to #167923 to fix windows build failure to avoid massive replacement `from -> torch::stable::detail::from`.

Pull Request resolved: #168155
Approved by: https://github.com/janeyx99
ghstack dependencies: #168173
JacobSzwejbka pushed a commit that referenced this pull request Dec 8, 2025
@pearu @JacobSzwejbka
Revise stableivalue from/to deprecation (#168155)
cfd5101 
An alternative approach to #167923 to fix windows build failure to avoid massive replacement `from -> torch::stable::detail::from`.

Pull Request resolved: #168155
Approved by: https://github.com/janeyx99
ghstack dependencies: #168173
@github-actions github-actions bot deleted the gh/pearu/153/head branch December 19, 2025 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janeyx99 janeyx99 janeyx99 approved these changes

@mikaylagawarecki mikaylagawarecki mikaylagawarecki approved these changes

Assignees

No one assigned

Labels

better-engineering Relatively self-contained tasks for better engineering contributors ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pearu @janeyx99 @pytorchmergebot @mikaylagawarecki