Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167883
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 947c093 with merge base a6b6383 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
The label |
|
The label |
fduwjj
left a comment
There was a problem hiding this comment.
The implementation and rationale sounds good to me. But I just have a QQ here. Do we want to call like key_list? I feel the name list is a bit vague to me. WDYT?
21bc649 to
91aff67
Compare
|
The label |
|
The label |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This adds a `list` Store API and implements it for all backends. This is intended to be used for debugging and will allow inspecting all keys in a store locally as well as remotely in the case of TCPStore. Test plan: ``` pytest test/distributed/test_store.py ``` Pull Request resolved: pytorch#167883 Approved by: https://github.com/fduwjj
This reverts commit f890837.
91aff67 to
947c093
Compare
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 5 jobs have failed, first few of them are: trunk / linux-jammy-rocm-py3.10 / test (default, 1, 6, linux.rocm.gpu.gfx942.1), trunk / linux-jammy-rocm-py3.10 / test (default, 2, 6, linux.rocm.gpu.gfx942.1), trunk / linux-jammy-rocm-py3.10 / test (default, 3, 6, linux.rocm.gpu.gfx942.1), trunk / linux-jammy-rocm-py3.10 / test (default, 6, 6, linux.rocm.gpu.gfx942.1), Meta Internal-Only Changes Check Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 5 jobs have failed, first few of them are: trunk / linux-jammy-rocm-py3.10 / test (default, 1, 6, linux.rocm.gpu.gfx942.1), trunk / linux-jammy-rocm-py3.10 / test (default, 2, 6, linux.rocm.gpu.gfx942.1), trunk / linux-jammy-rocm-py3.10 / test (default, 3, 6, linux.rocm.gpu.gfx942.1), trunk / linux-jammy-rocm-py3.10 / test (default, 6, 6, linux.rocm.gpu.gfx942.1), Meta Internal-Only Changes Check Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: Meta Internal-Only Changes Check Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 1 checks: Meta Internal-Only Changes Check Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This reverts commit ef7fa96. Reverted #167883 on behalf of https://github.com/yangw-dev due to break some internal test, error: use of undeclared identifier, reached out author but no resp, so revert this to keep diff train hygiene ([comment](#167883 (comment)))
This adds a `list` Store API and implements it for all backends. This is intended to be used for debugging and will allow inspecting all keys in a store locally as well as remotely in the case of TCPStore. Test plan: ``` pytest test/distributed/test_store.py ``` Pull Request resolved: #167883 Approved by: https://github.com/fduwjj
This adds a
listStore API and implements it for all backends.This is intended to be used for debugging and will allow inspecting all keys in a store locally as well as remotely in the case of TCPStore.
Test plan:
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @pragupta @msaroufim @dcci