Skip to content

[Fix] Add generator and tensor variant signatures for rand*_like() functions#167824

Closed
KarhouTam wants to merge 1 commit intopytorch:mainfrom
KarhouTam:easy-fix
Closed

[Fix] Add generator and tensor variant signatures for rand*_like() functions#167824
KarhouTam wants to merge 1 commit intopytorch:mainfrom
KarhouTam:easy-fix

Conversation

@KarhouTam
Copy link
Copy Markdown
Contributor

@KarhouTam KarhouTam commented Nov 14, 2025 •
edited by pytorch-bot bot
Loading

As the title stated.

PR #166160 add generator variants to rand*_like() functions, this PR is for finding out staled signatures and fixing them.

cc @EikanWang @jgong5 @wenzhe-nrv @sanchitintel

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Nov 14, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167824

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3800013 with merge base 2984331 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: jit release notes category label Nov 14, 2025
@facebook-github-bot facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Nov 14, 2025
@pytorch-bot pytorch-bot bot removed the oncall: jit Add this issue/PR to JIT oncall triage queue label Nov 14, 2025
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Nov 14, 2025

The label oncall: jit is only applicable to issues and has been removed. Please only use this label on issues.

@KarhouTam
Copy link
Copy Markdown
Contributor Author

KarhouTam commented Nov 14, 2025

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 14, 2025
@jerryzh168 jerryzh168 requested review from albanD and cyyever November 15, 2025 03:46
@jerryzh168 jerryzh168 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 15, 2025
@KarhouTam
Copy link
Copy Markdown
Contributor Author

KarhouTam commented Nov 18, 2025

Hi, @albanD , PTAL, thanks.

@albanD
Copy link
Copy Markdown
Collaborator

albanD commented Nov 18, 2025

What is this fixing in particular? Any test or anything?

@KarhouTam
Copy link
Copy Markdown
Contributor Author

KarhouTam commented Nov 19, 2025

Hi @albanD, thank you for the review. This PR introduces signatures to be verified by is_nondeterministic() and utilized within the Torch JIT module. Additionally, it includes tests to verify the presence of the nondeterministic_seeded tag, ensuring both consistency and correctness since I updated those rand*_like() APIs in PR #166160.

albanD
albanD approved these changes Nov 20, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok ok

@KarhouTam
Copy link
Copy Markdown
Contributor Author

KarhouTam commented Nov 20, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 20, 2025
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot bot commented Nov 20, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Nov 20, 2025
@pytorchmergebot
Copy link
Copy Markdown
Collaborator

pytorchmergebot commented Nov 20, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@KarhouTam KarhouTam deleted the easy-fix branch November 27, 2025 07:18
JacobSzwejbka pushed a commit that referenced this pull request Dec 8, 2025
@KarhouTam @JacobSzwejbka
[Fix] Add generator and tensor variant signatures for rand*_like() …
cc06ad3 
…functions (#167824)

As the title stated.

PR #166160 add generator variants to `rand*_like()` functions, this PR is for finding out staled signatures and fixing them.

Pull Request resolved: #167824
Approved by: https://github.com/cyyever, https://github.com/albanD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@cyyever cyyever cyyever approved these changes

Assignees

No one assigned

Labels

Merged open source release notes: jit release notes category topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@KarhouTam @albanD @pytorchmergebot @cyyever @jerryzh168 @facebook-github-bot @pytorchbot